| Message ID | 20230220041413.1524335-1-ming.lei@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ublk: remove check IO_URING_F_SQE128 in ublk_ch_uring_cmd | expand |
On 2023/2/20 12:14, Ming Lei wrote: > sizeof(struct ublksrv_io_cmd) is 16bytes, which can be held in 64byte SQE, > so not necessary to check IO_URING_F_SQE128. > > With this change, we get chance to save half SQ ring memory. > > Fixed: 71f28f3136af ("ublk_drv: add io_uring based userspace block driver") > Signed-off-by: Ming Lei <ming.lei@redhat.com> Reviewed-by: Ziyang Zhang <ZiyangZhang@linux.alibaba.com> Regards, Zhang
On Mon, 20 Feb 2023 12:14:13 +0800, Ming Lei wrote: > sizeof(struct ublksrv_io_cmd) is 16bytes, which can be held in 64byte SQE, > so not necessary to check IO_URING_F_SQE128. > > With this change, we get chance to save half SQ ring memory. > > Applied, thanks! [1/1] ublk: remove check IO_URING_F_SQE128 in ublk_ch_uring_cmd (no commit info) Best regards,
diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index f48d213fb65e..09d29fa53939 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -1271,9 +1271,6 @@ static int ublk_ch_uring_cmd(struct io_uring_cmd *cmd, unsigned int issue_flags) __func__, cmd->cmd_op, ub_cmd->q_id, tag, ub_cmd->result); - if (!(issue_flags & IO_URING_F_SQE128)) - goto out; - if (ub_cmd->q_id >= ub->dev_info.nr_hw_queues) goto out;
sizeof(struct ublksrv_io_cmd) is 16bytes, which can be held in 64byte SQE, so not necessary to check IO_URING_F_SQE128. With this change, we get chance to save half SQ ring memory. Fixed: 71f28f3136af ("ublk_drv: add io_uring based userspace block driver") Signed-off-by: Ming Lei <ming.lei@redhat.com> --- drivers/block/ublk_drv.c | 3 --- 1 file changed, 3 deletions(-)