| Message ID | 20230614141338.3480029-1-senozhatsky@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | zram: further limit recompression threshold | expand |
Thanks Sergey On Wed, Jun 14, 2023 at 10:13 AM Sergey Senozhatsky <senozhatsky@chromium.org> wrote: > > Recompression threshold should be below huge-size-class > watermark. Acked-by: Brian Geffon <bgeffon@google.com> > > Suggested-by: Brian Geffon <bgeffon@google.com> > Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org> > --- > drivers/block/zram/zram_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index 1867f378b319..5676e6dd5b16 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -1753,7 +1753,7 @@ static ssize_t recompress_store(struct device *dev, > } > } > > - if (threshold >= PAGE_SIZE) > + if (threshold >= huge_class_size) > return -EINVAL; > > down_read(&zram->init_lock); > -- > 2.41.0.162.gfafddb0af9-goog >
On Wed, 14 Jun 2023 23:13:12 +0900 Sergey Senozhatsky <senozhatsky@chromium.org> wrote: > Recompression threshold should be below huge-size-class > watermark. The changelog explains what the code does, but not why it does it? > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -1753,7 +1753,7 @@ static ssize_t recompress_store(struct device *dev, > } > } > > - if (threshold >= PAGE_SIZE) > + if (threshold >= huge_class_size) > return -EINVAL; > > down_read(&zram->init_lock); > -- > 2.41.0.162.gfafddb0af9-goog
On (23/06/14 12:52), Andrew Morton wrote: > On Wed, 14 Jun 2023 23:13:12 +0900 Sergey Senozhatsky <senozhatsky@chromium.org> wrote: > > > Recompression threshold should be below huge-size-class > > watermark. > > The changelog explains what the code does, but not why it does it? Good point. Let me send out a V2 quickly.
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 1867f378b319..5676e6dd5b16 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1753,7 +1753,7 @@ static ssize_t recompress_store(struct device *dev, } } - if (threshold >= PAGE_SIZE) + if (threshold >= huge_class_size) return -EINVAL; down_read(&zram->init_lock);
Recompression threshold should be below huge-size-class watermark. Suggested-by: Brian Geffon <bgeffon@google.com> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org> --- drivers/block/zram/zram_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)