| Message ID | 20230621124914.185992-1-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: fix the exclusive open mask in disk_scan_partitions | expand |
On Wed, 21 Jun 2023 14:49:14 +0200, Christoph Hellwig wrote: > FMODE_EXEC has nothing to do with exclusive opens, and even is of > the wrong type. We need to check for BLK_OPEN_EXCL here. > > Applied, thanks! [1/1] block: fix the exclusive open mask in disk_scan_partitions commit: 56e71bdf324d6ab263eba1fc3fa1f3fd8bb5678e Best regards,
diff --git a/block/genhd.c b/block/genhd.c index a94952ae9e396a..3d287b32d50dfd 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -366,7 +366,7 @@ int disk_scan_partitions(struct gendisk *disk, blk_mode_t mode) } set_bit(GD_NEED_PART_SCAN, &disk->state); - bdev = blkdev_get_by_dev(disk_devt(disk), mode & ~FMODE_EXEC, NULL, + bdev = blkdev_get_by_dev(disk_devt(disk), mode & ~BLK_OPEN_EXCL, NULL, NULL); if (IS_ERR(bdev)) ret = PTR_ERR(bdev);
FMODE_EXEC has nothing to do with exclusive opens, and even is of the wrong type. We need to check for BLK_OPEN_EXCL here. Fixes: 985958b8584c ("block: fix wrong mode for blkdev_get_by_dev() from disk_scan_partitions()") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/genhd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)