| Message ID | 20230621201237.796902-2-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Submit zoned writes in order | expand |
On 6/22/23 05:12, Bart Van Assche wrote: > Two data structures in blk_mq_requeue_work() represent request lists. Make > it clear that rq_list holds requests that come from the requeue list by > renaming that data structure. > > Reviewed-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> > Cc: Damien Le Moal <dlemoal@kernel.org> > Cc: Ming Lei <ming.lei@redhat.com> > Cc: Mike Snitzer <snitzer@kernel.org> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
diff --git a/block/blk-mq.c b/block/blk-mq.c index 720b5061ffe8..41ee393c80a9 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1441,17 +1441,17 @@ static void blk_mq_requeue_work(struct work_struct *work) { struct request_queue *q = container_of(work, struct request_queue, requeue_work.work); - LIST_HEAD(rq_list); + LIST_HEAD(requeue_list); LIST_HEAD(flush_list); struct request *rq; spin_lock_irq(&q->requeue_lock); - list_splice_init(&q->requeue_list, &rq_list); + list_splice_init(&q->requeue_list, &requeue_list); list_splice_init(&q->flush_list, &flush_list); spin_unlock_irq(&q->requeue_lock); - while (!list_empty(&rq_list)) { - rq = list_entry(rq_list.next, struct request, queuelist); + while (!list_empty(&requeue_list)) { + rq = list_entry(requeue_list.next, struct request, queuelist); /* * If RQF_DONTPREP ist set, the request has been started by the * driver already and might have driver-specific data allocated