| Message ID | 20240407031708.3945702-1-yi.zhang@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [blktests,1/2] nvme/011: fix filename path | expand |
On Apr 07, 2024 / 11:17, Yi Zhang wrote: > Fixes: e55c4e0 ("nvme: don't assume namespace id") > Signed-off-by: Yi Zhang <yi.zhang@redhat.com> Applied. Thank you for catching this. I found same mistake in nvme/013 and 014 also. Fixed them as another commit.
On Mon, Apr 08, 2024 at 04:02:51AM +0000, Shinichiro Kawasaki wrote: > On Apr 07, 2024 / 11:17, Yi Zhang wrote: > > Fixes: e55c4e0 ("nvme: don't assume namespace id") > > Signed-off-by: Yi Zhang <yi.zhang@redhat.com> > > Applied. Thank you for catching this. > > I found same mistake in nvme/013 and 014 also. Fixed them as another commit. Sorry about that. Hmm, but why did these test pass at all? I'll look into it, hopefully we can make them a bit more robust.
diff --git a/tests/nvme/011 b/tests/nvme/011 index eee044c..4810459 100755 --- a/tests/nvme/011 +++ b/tests/nvme/011 @@ -29,7 +29,7 @@ test() { ns=$(_find_nvme_ns "${def_subsys_uuid}") _run_fio_verify_io --size="${nvme_img_size}" \ - --filename="$/dev/{ns}" + --filename="/dev/${ns}" _nvme_disconnect_subsys
Fixes: e55c4e0 ("nvme: don't assume namespace id") Signed-off-by: Yi Zhang <yi.zhang@redhat.com> --- tests/nvme/011 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)