| Message ID | 20240430125131.668482-13-dlemoal@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Zone write plugging fixes and cleanup | expand |
On Tue, Apr 30, 2024 at 09:51:30PM +0900, Damien Le Moal wrote: > We already have the disk variable obtained from the bio when calling > disk_get_zone_wplug(). So use that variable instead of dereferencing the > bio bdev again for the disk argument of disk_get_zone_wplug(). Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/block/blk-zoned.c b/block/blk-zoned.c index 0047fe66f22d..c819e3cc7a20 100644 --- a/block/blk-zoned.c +++ b/block/blk-zoned.c @@ -1203,8 +1203,7 @@ void blk_zone_write_plug_bio_endio(struct bio *bio) { struct gendisk *disk = bio->bi_bdev->bd_disk; struct blk_zone_wplug *zwplug = - disk_get_zone_wplug(bio->bi_bdev->bd_disk, - bio->bi_iter.bi_sector); + disk_get_zone_wplug(disk, bio->bi_iter.bi_sector); unsigned long flags; if (WARN_ON_ONCE(!zwplug))
We already have the disk variable obtained from the bio when calling disk_get_zone_wplug(). So use that variable instead of dereferencing the bio bdev again for the disk argument of disk_get_zone_wplug(). Signed-off-by: Damien Le Moal <dlemoal@kernel.org> --- block/blk-zoned.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)