diff mbox series

floppy: add missing MODULE_DESCRIPTION() macro

Message ID 20240602-md-block-floppy-v1-1-bc628ea5eb84@quicinc.com (mailing list archive)
State New, archived
Headers show
Series floppy: add missing MODULE_DESCRIPTION() macro | expand

Commit Message

Jeff Johnson June 3, 2024, 12:05 a.m. UTC 
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/floppy.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/block/floppy.c | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240602-md-block-floppy-1984117350ec

Comments

Denis Efremov (Oracle) June 3, 2024, 10:35 a.m. UTC | #1 
On 6/3/24 04:05, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/floppy.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  drivers/block/floppy.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 25c9d85667f1..854a88cf56bd 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -5016,6 +5016,7 @@ module_param(floppy, charp, 0);
>  module_param(FLOPPY_IRQ, int, 0);
>  module_param(FLOPPY_DMA, int, 0);
>  MODULE_AUTHOR("Alain L. Knaff");
> +MODULE_DESCRIPTION("Normal floppy disk support");
>  MODULE_LICENSE("GPL");
>  
>  /* This doesn't actually get used other than for module information */
> 
> ---
> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
> change-id: 20240602-md-block-floppy-1984117350ec
> 

Reviewed-by: Denis Efremov <efremov@linux.com>

Thanks,
Denis
Jeff Johnson July 9, 2024, 7:56 p.m. UTC | #2 
On 6/3/2024 3:35 AM, Denis Efremov (Oracle) wrote:
> On 6/3/24 04:05, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/floppy.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>>  drivers/block/floppy.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
>> index 25c9d85667f1..854a88cf56bd 100644
>> --- a/drivers/block/floppy.c
>> +++ b/drivers/block/floppy.c
>> @@ -5016,6 +5016,7 @@ module_param(floppy, charp, 0);
>>  module_param(FLOPPY_IRQ, int, 0);
>>  module_param(FLOPPY_DMA, int, 0);
>>  MODULE_AUTHOR("Alain L. Knaff");
>> +MODULE_DESCRIPTION("Normal floppy disk support");
>>  MODULE_LICENSE("GPL");
>>  
>>  /* This doesn't actually get used other than for module information */
>>
>> ---
>> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
>> change-id: 20240602-md-block-floppy-1984117350ec
>>
> 
> Reviewed-by: Denis Efremov <efremov@linux.com>

I don't see this in linux-next yet so following up to see if anything else is
needed to get this merged.
Jens Axboe July 10, 2024, 6:23 a.m. UTC | #3 
On Sun, 02 Jun 2024 17:05:31 -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/floppy.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> 

Applied, thanks!

[1/1] floppy: add missing MODULE_DESCRIPTION() macro
      commit: 3c1743a685b19bc17cf65af4a2eb149fd3b15c50

Best regards,
diff mbox series

Patch

diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 25c9d85667f1..854a88cf56bd 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -5016,6 +5016,7 @@  module_param(floppy, charp, 0);
 module_param(FLOPPY_IRQ, int, 0);
 module_param(FLOPPY_DMA, int, 0);
 MODULE_AUTHOR("Alain L. Knaff");
+MODULE_DESCRIPTION("Normal floppy disk support");
 MODULE_LICENSE("GPL");
 
 /* This doesn't actually get used other than for module information */