| Message ID | 20240815074519.2684107-2-nmi@metaspace.dk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | rust: fix erranous use of lock class key in rust block device bindings | expand |
On Thu, Aug 15, 2024 at 9:49 AM Andreas Hindborg <nmi@metaspace.dk> wrote: > > From: Andreas Hindborg <a.hindborg@samsung.com> > > Symbols in the bss segment are not currently exported. This is a problem > for rust modules that link against statics, that are resident in the kernel > image. This patch enables export of symbols in the bss segment. > > Fixes: 2f7ab1267dc9 ("Kbuild: add Rust support") > Signed-off-by: Andreas Hindborg <a.hindborg@samsung.com> Looks good to me. I was using this change myself for some period of time when looking into loading Rust Binder as a module, so I've verified that the change works as intended in that context. I also tried it again just now. Thanks for sending this upstream. Reviewed-by: Alice Ryhl <aliceryhl@google.com> Tested-by: Alice Ryhl <aliceryhl@google.com>
On Thu, 15 Aug 2024 07:49:30 +0000 Andreas Hindborg <nmi@metaspace.dk> wrote: > From: Andreas Hindborg <a.hindborg@samsung.com> > > Symbols in the bss segment are not currently exported. This is a problem > for rust modules that link against statics, that are resident in the kernel > image. This patch enables export of symbols in the bss segment. > > Fixes: 2f7ab1267dc9 ("Kbuild: add Rust support") > Signed-off-by: Andreas Hindborg <a.hindborg@samsung.com> Reviewed-by: Gary Guo <gary@garyguo.net> > --- > rust/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rust/Makefile b/rust/Makefile > index 1f10f92737f2..c890ec4b3618 100644 > --- a/rust/Makefile > +++ b/rust/Makefile > @@ -305,7 +305,7 @@ $(obj)/bindings/bindings_helpers_generated.rs: $(src)/helpers.c FORCE > quiet_cmd_exports = EXPORTS $@ > cmd_exports = \ > $(NM) -p --defined-only $< \ > - | awk '/ (T|R|D) / {printf "EXPORT_SYMBOL_RUST_GPL(%s);\n",$$3}' > $@ > + | awk '/ (T|R|D|B) / {printf "EXPORT_SYMBOL_RUST_GPL(%s);\n",$$3}' > $@ > > $(obj)/exports_core_generated.h: $(obj)/core.o FORCE > $(call if_changed,exports)
On Thu, Aug 15, 2024 at 9:49 AM Andreas Hindborg <nmi@metaspace.dk> wrote: > > From: Andreas Hindborg <a.hindborg@samsung.com> > > Symbols in the bss segment are not currently exported. This is a problem > for rust modules that link against statics, that are resident in the kernel > image. This patch enables export of symbols in the bss segment. > > Fixes: 2f7ab1267dc9 ("Kbuild: add Rust support") > Signed-off-by: Andreas Hindborg <a.hindborg@samsung.com> Applied to `rust-fixes` -- thanks everyone! (I am sending the notice twice for this series, since somehow the email threads got split into two in Lore, which also broke `b4`) [ Reworded slightly. - Miguel ] Cheers, Miguel
diff --git a/rust/Makefile b/rust/Makefile index 1f10f92737f2..c890ec4b3618 100644 --- a/rust/Makefile +++ b/rust/Makefile @@ -305,7 +305,7 @@ $(obj)/bindings/bindings_helpers_generated.rs: $(src)/helpers.c FORCE quiet_cmd_exports = EXPORTS $@ cmd_exports = \ $(NM) -p --defined-only $< \ - | awk '/ (T|R|D) / {printf "EXPORT_SYMBOL_RUST_GPL(%s);\n",$$3}' > $@ + | awk '/ (T|R|D|B) / {printf "EXPORT_SYMBOL_RUST_GPL(%s);\n",$$3}' > $@ $(obj)/exports_core_generated.h: $(obj)/core.o FORCE $(call if_changed,exports)