| Message ID | 20250306-rqf_flags-v1-1-bbd64918b406@debian.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | block: Name the RQF flags enum | expand |
| Context | Check | Description |
|---|---|---|
| shin/vmtest-linus-master-PR | success | PR summary |
| shin/vmtest-linus-master-VM_Test-0 | success | Logs for build-kernel |
On Thu, 06 Mar 2025 08:27:51 -0800, Breno Leitao wrote: > Commit 5f89154e8e9e3445f9b59 ("block: Use enum to define RQF_x bit > indexes") converted the RQF flags to an anonymous enum, which was > a beneficial change. This patch goes one step further by naming the enum > as "rqf_flags". > > This naming enables exporting these flags to BPF clients, eliminating > the need to duplicate these flags in BPF code. Instead, BPF clients can > now access the same kernel-side values through CO:RE (Compile Once, Run > Everywhere), as shown in this example: > > [...] Applied, thanks! [1/1] block: Name the RQF flags enum commit: e7112524e5e885181cc5ae4d258f33b9dbe0b907 Best regards,
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h index fa2a76cc2f73d..71f4f0cc3dac6 100644 --- a/include/linux/blk-mq.h +++ b/include/linux/blk-mq.h @@ -28,7 +28,7 @@ typedef enum rq_end_io_ret (rq_end_io_fn)(struct request *, blk_status_t); typedef __u32 __bitwise req_flags_t; /* Keep rqf_name[] in sync with the definitions below */ -enum { +enum rqf_flags { /* drive already may have started this one */ __RQF_STARTED, /* request for flush sequence */
Commit 5f89154e8e9e3445f9b59 ("block: Use enum to define RQF_x bit indexes") converted the RQF flags to an anonymous enum, which was a beneficial change. This patch goes one step further by naming the enum as "rqf_flags". This naming enables exporting these flags to BPF clients, eliminating the need to duplicate these flags in BPF code. Instead, BPF clients can now access the same kernel-side values through CO:RE (Compile Once, Run Everywhere), as shown in this example: rqf_stats = bpf_core_enum_value(enum rqf_flags, __RQF_STATS) Suggested-by: Yonghong Song <yonghong.song@linux.dev> Signed-off-by: Breno Leitao <leitao@debian.org> --- include/linux/blk-mq.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: c42048cee22435a6ea0de68cc02231cf359ca8b2 change-id: 20250306-rqf_flags-9adba1d2be2f Best regards,