diff mbox series

[blktests,1/3] common/nvme: add debug nvmet path variable

Message ID 20250318-test-target-v1-1-01e01142cf2b@kernel.org (mailing list archive)
State New
Headers show
Series blktests: add target test cases | expand

Commit Message

Daniel Wagner March 18, 2025, 10:38 a.m. UTC 
Signed-off-by: Daniel Wagner <wagi@kernel.org>
---
 common/nvme | 1 +
 1 file changed, 1 insertion(+)

Comments

Chaitanya Kulkarni March 18, 2025, 8:37 p.m. UTC | #1 
On 3/18/25 03:38, Daniel Wagner wrote:
> Signed-off-by: Daniel Wagner <wagi@kernel.org>
> ---
>   common/nvme | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/common/nvme b/common/nvme
> index 3761329d39e3763136f60a4751ad15de347f6e9b..a3176ecff2e5fbc0fbe09460c21e9f50c68d3bce 100644
> --- a/common/nvme
> +++ b/common/nvme
> @@ -26,6 +26,7 @@ nvmet_blkdev_type=${nvmet_blkdev_type:-"device"}
>   NVMET_BLKDEV_TYPES=${NVMET_BLKDEV_TYPES:-"device file"}
>   nvme_target_control="${NVME_TARGET_CONTROL:-}"
>   NVMET_CFS="/sys/kernel/config/nvmet/"
> +NVMET_DFS="/sys/kernel/debug/nvmet/"
>   nvme_trtype=${nvme_trtype:-}
>   nvme_adrfam=${nvme_adrfam:-}
>   
>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck
Shinichiro Kawasaki April 4, 2025, 8:03 a.m. UTC | #2 
On Mar 18, 2025 / 11:38, Daniel Wagner wrote:
> Signed-off-by: Daniel Wagner <wagi@kernel.org>
> ---
>  common/nvme | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/common/nvme b/common/nvme
> index 3761329d39e3763136f60a4751ad15de347f6e9b..a3176ecff2e5fbc0fbe09460c21e9f50c68d3bce 100644
> --- a/common/nvme
> +++ b/common/nvme
> @@ -26,6 +26,7 @@ nvmet_blkdev_type=${nvmet_blkdev_type:-"device"}
>  NVMET_BLKDEV_TYPES=${NVMET_BLKDEV_TYPES:-"device file"}
>  nvme_target_control="${NVME_TARGET_CONTROL:-}"
>  NVMET_CFS="/sys/kernel/config/nvmet/"
> +NVMET_DFS="/sys/kernel/debug/nvmet/"

This causes the shellcheck warning SC2034.

  common/nvme:29:1: warning: NVMET_DFS appears unused. Verify use (or export if used externally). [SC2034]

I suggest to annotate "# shellcheck disable=SC2034" above the added line.
Daniel Wagner April 4, 2025, 10:08 a.m. UTC | #3 
On Fri, Apr 04, 2025 at 08:03:33AM +0000, Shinichiro Kawasaki wrote:
> On Mar 18, 2025 / 11:38, Daniel Wagner wrote:
> > Signed-off-by: Daniel Wagner <wagi@kernel.org>
> > ---
> >  common/nvme | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/common/nvme b/common/nvme
> > index 3761329d39e3763136f60a4751ad15de347f6e9b..a3176ecff2e5fbc0fbe09460c21e9f50c68d3bce 100644
> > --- a/common/nvme
> > +++ b/common/nvme
> > @@ -26,6 +26,7 @@ nvmet_blkdev_type=${nvmet_blkdev_type:-"device"}
> >  NVMET_BLKDEV_TYPES=${NVMET_BLKDEV_TYPES:-"device file"}
> >  nvme_target_control="${NVME_TARGET_CONTROL:-}"
> >  NVMET_CFS="/sys/kernel/config/nvmet/"
> > +NVMET_DFS="/sys/kernel/debug/nvmet/"
> 
> This causes the shellcheck warning SC2034.
> 
>   common/nvme:29:1: warning: NVMET_DFS appears unused. Verify use (or export if used externally). [SC2034]
> 
> I suggest to annotate "# shellcheck disable=SC2034" above the added line.

Will do. I keep forgetting to run shellcheck, sorry about that.
diff mbox series

Patch

diff --git a/common/nvme b/common/nvme
index 3761329d39e3763136f60a4751ad15de347f6e9b..a3176ecff2e5fbc0fbe09460c21e9f50c68d3bce 100644
--- a/common/nvme
+++ b/common/nvme
@@ -26,6 +26,7 @@  nvmet_blkdev_type=${nvmet_blkdev_type:-"device"}
 NVMET_BLKDEV_TYPES=${NVMET_BLKDEV_TYPES:-"device file"}
 nvme_target_control="${NVME_TARGET_CONTROL:-}"
 NVMET_CFS="/sys/kernel/config/nvmet/"
+NVMET_DFS="/sys/kernel/debug/nvmet/"
 nvme_trtype=${nvme_trtype:-}
 nvme_adrfam=${nvme_adrfam:-}