| Message ID | 20250401192139605xby4g5ak51tei46zArAT8@zte.com.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | block: ps3disk: Use str_read_write() helper | expand |
On 4/1/25 5:21 AM, shao.mingyin@zte.com.cn wrote: > From: Feng Wei <feng.wei8@zte.com.cn> > > Remove hard-coded strings by using the str_read_write() helper. > > Signed-off-by: Feng Wei <feng.wei8@zte.com.cn> > Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn> > --- > drivers/block/ps3disk.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/block/ps3disk.c b/drivers/block/ps3disk.c > index dc9e4a14b885..b7fe90b6fdef 100644 > --- a/drivers/block/ps3disk.c > +++ b/drivers/block/ps3disk.c > @@ -9,6 +9,7 @@ > #include <linux/ata.h> > #include <linux/blk-mq.h> > #include <linux/slab.h> > +#include <linux/string_choices.h> > #include <linux/module.h> > > #include <asm/lv1call.h> > @@ -233,7 +234,7 @@ static irqreturn_t ps3disk_interrupt(int irq, void *data) > op = "flush"; > } else { > read = !rq_data_dir(req); > - op = read ? "read" : "write"; > + op = str_read_write(read); > } > if (status) { > dev_dbg(&dev->sbd.core, "%s:%u: %s failed 0x%llx\n", __func__, If you're doing this, why not kill off the useless 'read' variable as well?
diff --git a/drivers/block/ps3disk.c b/drivers/block/ps3disk.c index dc9e4a14b885..b7fe90b6fdef 100644 --- a/drivers/block/ps3disk.c +++ b/drivers/block/ps3disk.c @@ -9,6 +9,7 @@ #include <linux/ata.h> #include <linux/blk-mq.h> #include <linux/slab.h> +#include <linux/string_choices.h> #include <linux/module.h> #include <asm/lv1call.h> @@ -233,7 +234,7 @@ static irqreturn_t ps3disk_interrupt(int irq, void *data) op = "flush"; } else { read = !rq_data_dir(req); - op = read ? "read" : "write"; + op = str_read_write(read); } if (status) { dev_dbg(&dev->sbd.core, "%s:%u: %s failed 0x%llx\n", __func__,