From patchwork Thu Jul 27 13:52:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Gurtovoy X-Patchwork-Id: 9866935 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2C94E6035E for ; Thu, 27 Jul 2017 13:53:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D9FF20223 for ; Thu, 27 Jul 2017 13:53:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 11E0C2882E; Thu, 27 Jul 2017 13:53:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3D9C120223 for ; Thu, 27 Jul 2017 13:53:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751482AbdG0NxV (ORCPT ); Thu, 27 Jul 2017 09:53:21 -0400 Received: from mail-db5eur01on0083.outbound.protection.outlook.com ([104.47.2.83]:28608 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751446AbdG0NxT (ORCPT ); Thu, 27 Jul 2017 09:53:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xsdaFQIz1AqcOWIZ77fR2dEV71QrdHwljHHSoS3ap8Y=; b=pzJziclzXiyK7JJUQlRYGmJpcb6fShP2Znu4+f8ZLWQfU+R9Ycrfde0FxdyFoB8v03k56TT/8rwrN63Nej6JNNjEDN0o8868PRETrDtjQ9jln4a9bfftwjgxoC+gzOKhc+rJMQxtaubn7gT1bP4pbptT1Lxi4EqDdaldaWPRHls= Received: from AM3PR05CA0152.eurprd05.prod.outlook.com (2603:10a6:207:3::30) by DB6PR0501MB2533.eurprd05.prod.outlook.com (2603:10a6:4:5e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1282.10; Thu, 27 Jul 2017 13:53:16 +0000 Received: from AM5EUR03FT004.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::202) by AM3PR05CA0152.outlook.office365.com (2603:10a6:207:3::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1282.10 via Frontend Transport; Thu, 27 Jul 2017 13:53:16 +0000 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; intel.com; dkim=none (message not signed) header.d=none; intel.com; dmarc=pass action=none header.from=mellanox.com; Received-SPF: Pass (protection.outlook.com: domain of mellanox.com designates 193.47.165.134 as permitted sender) receiver=protection.outlook.com; client-ip=193.47.165.134; helo=mtlcas13.mtl.com; Received: from mtlcas13.mtl.com (193.47.165.134) by AM5EUR03FT004.mail.protection.outlook.com (10.152.16.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1240.9 via Frontend Transport; Thu, 27 Jul 2017 13:53:13 +0000 Received: from MTLCAS13.mtl.com (10.0.8.78) by mtlcas13.mtl.com (10.0.8.78) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Thu, 27 Jul 2017 16:53:13 +0300 Received: from MTLCAS01.mtl.com (10.0.8.71) by MTLCAS13.mtl.com (10.0.8.78) with Microsoft SMTP Server (TLS) id 15.0.1178.4 via Frontend Transport; Thu, 27 Jul 2017 16:53:12 +0300 Received: from [10.223.3.143] (10.223.3.143) by MTLCAS01.mtl.com (10.0.8.71) with Microsoft SMTP Server (TLS) id 14.3.301.0; Thu, 27 Jul 2017 16:52:21 +0300 Subject: Re: [BUG] nvme driver crash To: Omar Sandoval , Christoph Hellwig References: <20170725222408.fq2fncwtid3fhvqh@kernel.org> <20170726173443.GA25527@infradead.org> <20170726191221.GA22421@vader.DHCP.thefacebook.com> CC: Shaohua Li , , , sagig , Keith Busch From: Max Gurtovoy Message-ID: <53919f26-3886-350a-119b-59e9c4b8ea4d@mellanox.com> Date: Thu, 27 Jul 2017 16:52:15 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170726191221.GA22421@vader.DHCP.thefacebook.com> X-Originating-IP: [10.223.3.143] X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:193.47.165.134; IPV:NLI; CTRY:IL; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39400400002)(39410400002)(39850400002)(39840400002)(39860400002)(39450400003)(2980300002)(438002)(3190300001)(189002)(24454002)(199003)(377454003)(5660300001)(189998001)(83506001)(33646002)(36756003)(53546010)(64126003)(4001350100001)(626005)(4326008)(50466002)(230700001)(3846002)(6116002)(478600001)(31686004)(50986999)(6246003)(77096006)(76176999)(54356999)(229853002)(356003)(6666003)(31696002)(86362001)(38730400002)(7736002)(305945005)(2950100002)(2906002)(65826007)(8936002)(54906002)(47776003)(81156014)(23746002)(81166006)(65956001)(106466001)(8676002)(65806001)(3940600001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2533; H:mtlcas13.mtl.com; FPR:; SPF:Pass; PTR:mail13.mellanox.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; AM5EUR03FT004; 1:HS9irUbTkHvBbr+wuhs260fUaEUr7hz72IBWSi?= =?Windows-1252?Q?48Bx1TgFRUCjCUWokBG7K06lPZlPh9VJOCrM3YvWYc9uPxRAanhhtP/r?= =?Windows-1252?Q?pcWq9sYb02W+s7LimMou7V9SI85xQgS4DuhcVXzU/TOtWuLT+qs0VMTc?= =?Windows-1252?Q?KTlTup1J2FMEsngRP++xCVkg424empBLTil5srNGzLIEKf2mRucundhd?= =?Windows-1252?Q?gyML6qwZujWHn+6TX/0kZZylyQPNExqOBwa5fzkVjjviY7EWYNzOqRRu?= =?Windows-1252?Q?rXvPWIoERLQu7aHIqEF1jpgcU2kz41TY0hUuBSvapReKJwEsehJjXuKO?= =?Windows-1252?Q?JXAXhrnQxhBh/VlnF+ZgxwyAxbEYsq2JhYMj2WuFMXhBnmIGbKBTFs3t?= =?Windows-1252?Q?AOZG6CqyWX7FEmS2mExF/CL9aWvji/1NnA3s6SYnDDoIBIdlFmE4LxNh?= =?Windows-1252?Q?6VSdoYa+MTiYTNKXv0jt50VvOvxNu+BLJSd8W+g3yiusVJjeJ+25NsDB?= =?Windows-1252?Q?NHtyQmooLpi/2cF0h9wd/MLVj/gfcIyX1hBOFMKB1brGjMcq7SngJIb1?= =?Windows-1252?Q?hCg9fDFoGWGtjHNh8rzuEcSuWE0djBRNEWZCKgxI/qoaNqOrkx27x0/s?= =?Windows-1252?Q?RgvC8zEGxWAcrb6JOtAZCjbkU6/DbwRl0eL7QC8vZDyjuQSTEA9oNVFc?= =?Windows-1252?Q?vTgRJ6ZWHUNxRMzRWM1GZ8Hwocf735RuIlmrrY+IEi38r3uwojWDt/kB?= =?Windows-1252?Q?N5cLDia+haCifH+r0AM04l5B+ZMGNfwVdltqOb1HRCTdgVbyiJCk3xug?= =?Windows-1252?Q?eg7pJ4+4Ai8DK45omR9L0cRKHbv/RUL4t+vALB5HqTufcQgebZWKT4Ln?= =?Windows-1252?Q?DZTK+j8o0hAmDmkrKi5K2RFnBDCYOczG41cKADN+LyqC5e5FtTdzUI50?= =?Windows-1252?Q?KhYrJEh1IViIkJmjp9ky3/QGpYMJqawsxgoH6MKbdbxF7KrIbL9JAWsy?= =?Windows-1252?Q?I8v79G+pJFcxHzWt1LeJ3FryMf0EDxAbXV0p2DnvRl/mVHjl6Vi24JE1?= =?Windows-1252?Q?KDV4hPiM5TLZs=3D?= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 58db9b54-cd37-41db-73d3-08d4d4f6d36d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(8251501002)(2017030254075)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB6PR0501MB2533; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DB6PR0501MB2533; 3:aQEpeFIREb8/wlXJvHHpPmTmSHBPiNNqihpu?= =?Windows-1252?Q?L+d96rQ+7EbREgDWhOI/y6+7cDdqSXzqYKULphP4XZNIYSuL3koZMNox?= =?Windows-1252?Q?bo8U3tRSWEhyxx80EEQpPNeJ/hkgXo+QY+mcBuYhGziMfWU122qoHMYY?= =?Windows-1252?Q?GRHFphvRnVLISUhuJeCE+JihnvVLgE+rpGPdgkHENPdUcz4sK9+/7AMv?= =?Windows-1252?Q?3eDQCo9I4Lc9xEi9bH51/RztI6HS0nS641pYPXtTB3NM1O7v64oUXA8p?= =?Windows-1252?Q?l6rf8Zd4GIGoJTl8X1D9oFyBxzG0dDg8MztXmL9So1pxnmtwIN+Ji5Cp?= =?Windows-1252?Q?z7GwhrJHvm9I8jHQszK/bv/mKySP/lJurhqHtr/sSdKo/M30wRSk5wy2?= =?Windows-1252?Q?Egpv377Ev8PcTX7Lv8fI/77M7dYqRwujFzddXunW6tKPEO1E0xAnjara?= =?Windows-1252?Q?p01pUdxKPT5sYiJ0nZLV1A3I5ZeHzxY4z4f1xh6S9qfjx+mFW/5mCy8I?= =?Windows-1252?Q?JZ4ogAe6zEchFE1vRjiCPnfRouxnyQT0Mflhk44IEUktw/uvE7JlnyXS?= =?Windows-1252?Q?RUQ6VJJN5EG+sy9E4af18PrVMeP7pKy7hUe8FwH6Zy6unnbRO6b0anLR?= =?Windows-1252?Q?dA1xKxyArW3bYm2zg5hjewrVJcICWoYLkdbjVepboGZT85cBViWj8h/a?= =?Windows-1252?Q?BhqlezXS8X4h6Js35oGCZTqMJItghbriuZ5Pgv+/nrDFsUrg2aPhNpLq?= =?Windows-1252?Q?b0tVjqiL3Alz1rZ8BB/c9gJVgaNX6P/VAvX8JyBhA2WEosCjU1c6mHkd?= =?Windows-1252?Q?Ejutis0Q+7LCpwp8oIiDffGJoWpGmXJn07jm3pPtytyGe83aL3EwOCCZ?= =?Windows-1252?Q?RpVJCzVqXgAnZ0+bycaq1SUlSfZGM11SGz/HqL1c2dNNPbbwx9vv0d4T?= =?Windows-1252?Q?uYfEg/FifIrEda4BOTn1ZIIG1aiNy8u/TEFA4Tsgmb/P0su+mXPxPw04?= =?Windows-1252?Q?Sex/rKQg5YFTcHuI0l6s43a82Ry4t660KK0Nb7xnd0qBuC9KLQ=3D=3D?= X-MS-TrafficTypeDiagnostic: DB6PR0501MB2533: X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2533; 25:V4WoqLENws2Ri1Ln7Sba+FPEI54pZ1q9myKIcJA95D2yTOdZ7160ubheHBbJ+hbqw1YJSm0X0TBrug6ILODRNTRjl373Ou2j7YE0GcNv0eHX76q0a85vc+acPG/Mv4i0dvSABruHPMNOUgY+r/3qLzca8sOCU3iHUKwtSRjcTSwhyl84EKfw9w4LR/B5THcM4UyIXOaeb2vL72N28cumLNK/ZuFLeQcs3iU8cpN3furlrjE1BrbN6nhQYyTCy/1lTdciwrpEig8gzPGox1F+XQp6zsqnC27AUznnOck9fmmOMKFT8+vd+xzyV0lWwUnjEW3nsJThQgqJ8OjU0DHlzt7X2sQa2igjT1IKCde4oywYruYpDnpY31hYcf/xkgag1OG6PBlhi0eaIWosvgYYO2rKQOttIjuFCl+Z7sYlM+6R91Dbw0WOZyVvaqDf0D488r7vB4XSOdq8ecyQVltB5FbGuMGvkGa/eIi1MCh7Fao8Hp6Wi0ch/VP/JWtSyfsxerYbtAobyOkAOpNF/IXCIeZewaSiWIsRN+vBad3yJl2kcqPAZKht6QBKYBmvF/UH+DxNydouOHzI88CZqKUyqnkr1A7FPh66Y0rAkbytbfmB9k2qkLULw+FewKnzbZx3wQEv3jWSrMfUxqXkItmRJl+o4r84BG1lr1KuA7s3mssM4Wv8wIAdqcaYWHhNFUrBQWUc0aqLGDnLRr0vSBdstebo6jSaiA08E8CbFSgagMrdmoE7Tfoe2Q+AVqz75wssb1N7awP9rdKY8bMHps6iPcT2WeZKHV+lfGt0PdITLadvPADSFTu154YgkjMipolydcoytfNaDaPaHlskXoWgbHoC7nZ0g3LacCDqhEdPYBdmTaMEMEhrAmcQtJd+u1OC1ssb1h6G6oK/p0gfR7R3XMiAXfNoge2NV3WaEgG 7uJw= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2533; 31:iv1C2VjhVZP5X42hqyU9JkPOoJh/gRuJYMgaig2kKEPGmmrZBlPFMbvKG/+hHgP0N3yylJOI5dTTLophXhbD/2keUgYj7bLq+bFcR5gV/KEtA94kMEaYPV67DkDAUnvj8Lm0GJZPHyAMF4aK6gXH5Kii/PqYvEseWMItf87sJFF773DEpBpZbsBBIYc+F5ASId4HPRjX3hWUXtpp1gi+A2OcdqepdySfdC2LslebxAZDFLHJHloEWOrgjrDZuAEcOuYx5OCSadgU5EV/s4457ke5Na2VYuca7dbHgbXnXAi2lQApgrWoaoA5DLp8zdE2S5lAkAuHlaShNM9dRMMjzcusAGXlR0chT0X3k0BKv/GziWJv9klEXXiMpDc8g7Dk3suH5emmTDgCjFqYskRvryTTm0Esm5qR9Ec+XRrfC5Ag2tbasx+I0yE9Bt3l9W7KgrwEXiqQNsMNeIs6nZmISZ9ESYO3w1C5bNdFGRibP4b7NFGVUp6eQ/K0RWuhlCacQAiXkcCFKzEcSCNJeyKggOeH6zknCT/mhmQFwpbUisrYyckGooFa4qlSIHW0whSNFivze/PkCfZNcamxQAmlLC/y0/HY27ZBlVpbthTAqEc0YvP/jWM4x0wzhCRbifE0ND6WhcVkj79wopvRDJr3Srx82R9/TdkFOwhiMNIwYiv6gUU3XGlKAC43+ApAknqfDAurISbvMFbCaLrA+lFdMw== X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2533; 20:O1yHrlNqpdkt9UpHsUq5kSLSe8tVquzQoFaAiQE7uOfuk5baKuCXWmQ0t4GWe7nN5VEi6nVEyzby1laxuKHg5M32X5NRAxK0MRL2bHmSCqieo2OZQ0yiWd8fnyJ2pD+3trN2aRouDZKPbeH2pMhs0RLI+hrSlaU2fSx+VOubSMj8CJc18aM49OXg8UlzYp/vQ2ESI6VAtTI3JeCyyCboPXihmRS1Q6FXcXfdKpyWHK/g3vKAnfrcbGH1Y9okGTg9ZWFlt1nTeD3xIpGdZo4x3/3Xir+3uNznCPonU/rSg4S/28zzL9Gphr5bksxOBOiuFfPT8Zmr4SKNGq/8JdXYRGaVohj4ymbE6KktaogqbsU/5dW0egGa7+fJx7fior2dh545nout7u8f8FspJJfuIRjRK/RUOU8/Whm5piXb2QjpuMtk8FMF9P2IsVn7lpiMi8x5QtfzVti83rujTP25jY/YLBcresBdsHN7nYEtts5sblXvXvBZXxaCEXWeH8RU X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(13016025)(5005006)(13018025)(93006095)(93004095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123558100)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR0501MB2533; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR0501MB2533; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DB6PR0501MB2533; 4:E5IArkeDUkcicXBpAdI/2EcUjaYukYBbxbvW?= =?Windows-1252?Q?3Ks6kLPk4PXSYIsymBsf4nNah2ojdswjvdwTFmj56SYzPJgOc6wfInZf?= =?Windows-1252?Q?kZlViedwIw7JxYERmwUN5PfyYZrJfiqjcrG3SSdxnAIkRERVYYU7EXzi?= =?Windows-1252?Q?x2++Tc6YNLwvk7zDm5y0ZHroZTAiiBeiVgLEc2awfLbjmKJ8C1jCG4QC?= =?Windows-1252?Q?ZpZyK9zHdRfF05r+b9ro8kifrcztjfDB8US3tGfTaqqPOzPgiygZdQS3?= =?Windows-1252?Q?yB330vljSqjrd0zOxA2rfybezzjItS9u1whMEK9fVU7IymWYns4PhYCC?= =?Windows-1252?Q?O16019qSxgvMMIjM621fUgrFi2MXtmItoV2pdjsG97nlb4X1DApiA8yc?= =?Windows-1252?Q?5L3M8CwJv/YxbTeFdudpGP7/bVWxdOtum2AToTWagtjSWc1oZD8yYYwd?= =?Windows-1252?Q?A8TysLw/JItfmvJpYnrYY8/wCiEJEMisBPu9pT286FD+Lc7tt/7Xaojj?= =?Windows-1252?Q?9s8Kw9PuiTpZRL6N6lcQaiyFf0IJ0iFdlzLc1d9lP703lD6cbJRD1Xvm?= =?Windows-1252?Q?of6eA0JJ0c1ejlCWkdBcw8jMBA2oP6fskGRx0HJkD9483ZPUb3o64h6S?= =?Windows-1252?Q?O26I4HgFMmlTb4+cKlRyRHZ/w5ab0lZH3nG49suBbl7eqseE22E3h8TI?= =?Windows-1252?Q?16UsFfYn1zlvUd+w0cEmdRbk/2WpWUu5RrTzU+ggZmFOtP+oWVfkB8zg?= =?Windows-1252?Q?UxpIUogvzJT3T6VoaKrvylzr2igGp1oXfqquM54oSPu6jeajU3WumGfx?= =?Windows-1252?Q?PraMyEcqdf3LA+vyNL3DMVIhL/XKzbZ9TkcZMFRcyRbJnysvf0Nhq4RN?= =?Windows-1252?Q?2g4RLfE+pJBDlsnALpxWkPuWUUcJYL6JJ5ftB2EgiZf72y+tdI8pBNAL?= =?Windows-1252?Q?CmZr18g//SWRjiulwsKSBtMTzxRWUBoQNnx41nE40CO1MaF2OSwtihRa?= =?Windows-1252?Q?40zX5XIeTX+FAB4GNgvSYXRJ5XMy0F3XP3jVAU+J35tpWZ3xIq6Asj+j?= =?Windows-1252?Q?D5s9PB/iAf6UDSRPJ2UYW1pbZcSeh813TysA5TqtkrS2Es8v4W5d7Yao?= =?Windows-1252?Q?2DPB/s1nn1c1JIoh77VimUrSo5IeRsFOmJwMaVZsEj1CQtw7spYWN9aK?= =?Windows-1252?Q?x8yNqsh27dgTOIpk+wtbG9hl825rAibhYLsPWXW+sUihi9BP6pFEczcc?= =?Windows-1252?Q?9Zywb+mCKqSCP5y58LZLq0Qcd7D1w+bTs/hu1kaS1xSNsJ994klS9Tan?= =?Windows-1252?Q?RpLxevkcPX/9iSG/dWctuxwlRsxhrvky48kc8v8pM98irRI=3D?= X-Forefront-PRVS: 03818C953D X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DB6PR0501MB2533; 23:zz+2eqSpJpywkRwfmimGv7og6LwfgnK9aPL?= =?Windows-1252?Q?OtQi7GGROEEce8BgbNxxGF5G9G4DTqh7rURXgKG7+RFoE0PYHJO8dyWC?= =?Windows-1252?Q?btkcArWhMjINtwajkBZ8SvqGWPiFENyIlhR1PUgd98aFlOMu5bEgfo1t?= =?Windows-1252?Q?FNf8leJB2aZ5ARQ5VKmtP0wb1a9Yp4tClMmkhL1RLM/uXERljc1mzRfW?= =?Windows-1252?Q?/9WzI5kY8O8wTGKFwUZ03bEEtt9OjeyEiUH2pYbzKCp/uP/siL+PJsOx?= =?Windows-1252?Q?fQ6T+NC5z1BZYiM+oNyKOfiHzG5+4TW9oiEHc/MKm7gYjutWH5PqiMzT?= =?Windows-1252?Q?rYymgj2GK864pOqShiYemhV7ZKvUDrTsylqgYfZBBj9IOF5uF7qG0DEo?= =?Windows-1252?Q?L8tAeDoMKaqE0jaC55UuoigEHrc/LfIKTmvVnBHvhLMxyYBR928s5epJ?= =?Windows-1252?Q?XAhnhvdAwJnOi+8s+oj1hXfurhliMZv7Ews5Yk+64VzhpLRSPUJSOeC6?= =?Windows-1252?Q?3/8dOFSF+nN31umTO5/8YR7DN+DfviNkjutKnro9m4FRL3tR6k+oteic?= =?Windows-1252?Q?TCFQhNtJ1GfwgItABQydQf2cGeMdKqwECMDcMJpVCr8294yHGZ1raA6O?= =?Windows-1252?Q?rj9lDifUO3ddFFewm4HnAc9ds4i+Yf2Pw4i7crSgYCbs5dIUQJPMaRcb?= =?Windows-1252?Q?tSpx9Po2fyhIcRk0z12xOHjao5kRpzL3Nb+/SKKObiVqjLwS4rPrA+0S?= =?Windows-1252?Q?tVMC2kaZzrbO6UhxqOzRUahZMDLoChYkF4oWa4XGZrYIop63kDUMi76B?= =?Windows-1252?Q?dDSlwkr4jGks9zeXrdGLHRBnj7QCliOipbBVIvtylwGbNBgOuBI7FoTH?= =?Windows-1252?Q?O34gEafJO2U8TZQu8mPgud+rCqYp4vEp8dM8Y8A8xUsl3IZcRRVaZV6C?= =?Windows-1252?Q?6tfBYx+7JpCoKQX7blv2bFgla3ypHXSDAwHIf9clzy1axeDiFz/FRoyP?= =?Windows-1252?Q?Z11ExbiL8asO9X96KRNK/UABqGd66aAPyrujE+dVhlKc0m260kFskWlN?= =?Windows-1252?Q?v/HaDxuKP12pjPFxdoMOmOk0ZB+u/H0MtY5JH4/T51El1H8vlQ8/jNZf?= =?Windows-1252?Q?Qsx3lGeL35UisrLZizRsArzcHQtT+az73wg4kMZ19fB3klXSYlHFwDq/?= =?Windows-1252?Q?H9kpMa8SogeGVUqlq/BtHeaolPTpX6YqvmUmCCPUVOHsMF0/ucjgm1gW?= =?Windows-1252?Q?SCebnsG69zh+4lqu0jm9p4BfT83f/ytBK+az8qFpzGk3nJ2gxRfW9DQJ?= =?Windows-1252?Q?mrZVSqneeZ2kHT6J1sIBpSRkaH4LAeJ1gqrQywUjGNv8eVkJC2H3gmBR?= =?Windows-1252?Q?KsSjhqD8kJ9BAtcFQUbVEqchz4VV9wrshtmLONyxIQfN8DHlKsOAMK0X?= =?Windows-1252?Q?lNY6koGnrGy12OW7oKoMX4YQ6D0bZGBzzOo2LsOYaJQimP/QQgNCwzvw?= =?Windows-1252?Q?ytJXHC6E=3D?= X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DB6PR0501MB2533; 6:phHb/naH3Nwjle1g18VMv2rS1inT2SxHpKnL?= =?Windows-1252?Q?N/hAMPuj8L1Q8dMgdcATjPYRKMYtckrRm0CoCJS8SVok+GY7EEELghOb?= =?Windows-1252?Q?xjY/fXO+cGIo+bkJrlv0+L9Xhw9m0odqKSibgLEvtWNeBpHhcndGEfyb?= =?Windows-1252?Q?WUGQTp8neJTGYjkxk5YDAtxTcDKusXZW03Ge4GXBzwlIKNYtrhTomPXm?= =?Windows-1252?Q?h5Ss/uug6eImUENgA6NR2juAKZ3+U9qMLHxk3qTwU764qftl+ov+3gys?= =?Windows-1252?Q?gsYnLA5FrgHak155Z5NMDgPUE52ZpWUs4a1xYv2AdI/uhs9ePuX8eYXd?= =?Windows-1252?Q?1HIC8XPDUEHKwM2CZ9/TTvEfwNostwikYJaSOYkVDzK1iUDO/BESKhst?= =?Windows-1252?Q?WeGbeV3nkhaoo0xEFYagKE6p03B8nzhXHz9PxmSH4muOf+pRVjyJ/w9j?= =?Windows-1252?Q?X7ueW/wEafqc7HhuooYR13hb3uB2hJK1qxrMCh/yD36WXCKOGKUCy8+P?= =?Windows-1252?Q?FrJxuGN5bYx3HptFz9zmMfkWVAZhBv7wcTlIG1P9AtEUsnqkRN1pwLl0?= =?Windows-1252?Q?m7ZBO2v/VFaNOWODW/aqqelK8QtnrO34uKoz6pT1huEOjk6xfNyfNQWx?= =?Windows-1252?Q?luclaD3tu0zQ9mfaxvcKTfsywGHMnVv8JCbGWR0QRRphUkeqJOU+v0Ze?= =?Windows-1252?Q?XDw/48cONn48TONJg/E/DQcmQGQF3GH3EGv+UBohB4GS6/l05kmqu7LH?= =?Windows-1252?Q?k7iSiSSm7m8Tq2k3aB0+deoNylf+oPJyRBeUmQhSCyTZc1KRIzCYc1DK?= =?Windows-1252?Q?4fsgaEYzmujz0k1K/3mKICcIAW+42nd6NimIJUp3WochWsntkYy5/x1K?= =?Windows-1252?Q?I/6tbLK425cIekxLQZEqEIi19VhKutrxyps3fRWZnLkOdMQlICQGT19P?= =?Windows-1252?Q?7ieT9JXi1cYWybXBsHefpt3A2YhOxDAL7bORnwJuopp/8n6bXciijJAP?= =?Windows-1252?Q?FPOnqUF3ZCQUr9ZJUNPnqH0HTIV87SSzY6oO84GGILcESagMrRPpdHLX?= =?Windows-1252?Q?btziCb2WQXFRFhuW84tgcDZXnRm5wXNkIkJy?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2533; 5:TxzlXW4Dr18nf2GhJpxUSAMQ5WiUwRp8KPilKLCFjUOuVgal+jk0HmPg8FNsljUMDdCrIDM/bRr0jyNKhx5joMm+CnBFXXRT+SfUdW7DNvpgMwONnfEpXfMlpLlPR4F2rkVWpIpXRZCAuZBoolGsqhXBYYkb9fwNuCStAKR46EhfCQS8fvqJMoGVg3rdZEFzGbg/pqcrneb8tEktxlZ0BXiK4uKDWr7jl3Nsoupb2TIOCz0rgnVAVjtx4RDb88ZzHjnjpdimZjUnYyEkMcKLaVqd/tz9NBCLdSiwjLi+QEoaAjgsyG79PY874Q7UiEVuNXe85N72FHffKNY6Z/H+C0xsFaLDVWrHNI692p/6SmFsroYbyx4HtSLYwYDVULQbjR4o4VhJFBgxp6tFFVnJ76iABqYO8qRTZRa8tQsp0ZAYQtcpU2KmTDyEi0nYf/vTLSf4Rm6dw+xk/Cif7CZ1QFDC8M9n9ERA1R44UZ8XgbLN+4uMCv6g999rUfK3teK6; 24:z3bFM1d+Csc3C7JH0f8dZ0VyWVKfv7uMTXPSUxNJvNH2MWizgkBgZcQhElrVO2PNYRZ+c6zdE4G9lvUHztyDEA1qWsFgXipmz9NE/kJLkG0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2533; 7:zs+fHHY/QvRKz2KgsSLbs1d+P1n0u952d2LCpkzCP8JadAuXTmMeDiyF92N7+sPApWPANrrnB2iPW585UuqTz8SWmUDsvc/eGre7JxV8dCzQtEhnZP1XaOOXl/2BYNDTBUr6OuQXDHZK2Vy/H8G/rW/41MqTWLGVh2+oksryi1ACDIEbNQbr6UTUZPoU4vrFBgbZZfcLZ8EgbekSAU2ys5YVS4yE2Mhc1etT8fQQV57ucymn4DOwFaAlm9HhzsapB81CG4HbfSID/YACsP8cWx11QfpLZU+btORJM9Iy4jFqwhAu9HavmibCBAdb1Oqj7J4TaqAqijZCQdzh+R7aHL8obw/kGbsIILJcPPW1Lj72T1FGB43SAQmudJeSF0WznkxJPZeGEaAd4mfJ1c6/TVBmpVttNDkzhuEgRrvcuKCs1KOA7KwkVolnY9cQbFUeg3E75eEAiD+txHaBc2Hgm1W1KIR0vRIYOM7DMeCGG/s8d1QlN8TDqi0omMpIwY93MoLrXewuMshsyG69JuGjAlit5XGLlBNLtoHuLbdHuSpDU+FR4iX+FD9TGN9eBmkX5aKe267e7Xkj4L9xsVvwuj2ewOAwLcsLKbu9u/2n5fIwxeHc0Ynn6FnG/2p7E8QT2QcKaVseWxLgTAd8IPFgvE1Q94tUwCV+hLzQ+36k2kHWN74gHQwErqpqCWWioRC5ycTBe/o/hQJwD9Hdra48lZYHR3u7wlPo37Er1F2EvOMYZXYjLLd6A1ErE6LSugHk5hdo5B5y7U3ZHjXiPdMw/0ax5RkD6vOl6BGKrcpoHkA= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2017 13:53:13.7010 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b; Ip=[193.47.165.134]; Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2533 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 7/26/2017 10:12 PM, Omar Sandoval wrote: > On Wed, Jul 26, 2017 at 10:34:43AM -0700, Christoph Hellwig wrote: >> On Tue, Jul 25, 2017 at 03:24:08PM -0700, Shaohua Li wrote: >>> Disable CONIFG_SMP, kernel crashes at boot time, here is the log. >> >> I can reproduce the issue. Unfortunately the addresss in the bug >> doesn't make any sense to me when resolving it using gdb, as t just >> points to the line where blk_mq_init_queue calls >> blk_alloc_queue_node. >> >> Can you check if you get better results in your build? > > It's crashing on that line because ctrl->tagset is NULL, which is > because... > > irq_create_affinity_masks() returns NULL on !CONFIG_SMP > -> pci_irq_get_affinity() returns NULL > -> blk_mq_pci_map_queues() returns -EINVAL > -> blk_mq_alloc_tag_set() returns -EINVAL > -> nvme_dev_add() doesn't set ctrl->tagset > > The two-fold fix would be to make the nvme driver handle > blk_mq_alloc_tag_set() failing and to fall back to a dumb mapping in > blk_mq_pci_map_queues(), but I don't know what the best way to do those > is. > Adding Sagi and Keith. Christoph, I've send some fix few months ago to that but haven't got a green light: nvme: don't ignore tagset allocation failures the nvme_dev_add() function silently ignores failures. In case blk_mq_alloc_tag_set fails, we hit NULL deref while calling blk_mq_init_queue during nvme_alloc_ns with tagset == NULL. Instead, we'll not issue the scan_work in case tagset allocation failed and leave the ctrl functional. Signed-off-by: Max Gurtovoy Reviewed-by: Keith Busch --- drivers/nvme/host/core.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) maybe we can rebase and consider it again ? diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 9b3b57f..493722a 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -2115,9 +2115,9 @@ void nvme_queue_scan(struct nvme_ctrl *ctrl) { /* * Do not queue new scan work when a controller is reset during - * removal. + * removal or if the tagset doesn't exist. */ - if (ctrl->state == NVME_CTRL_LIVE) + if (ctrl->state == NVME_CTRL_LIVE && ctrl->tagset) schedule_work(&ctrl->scan_work); } EXPORT_SYMBOL_GPL(nvme_queue_scan);