From patchwork Thu Jan 26 20:47:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9540071 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 12033601D3 for ; Thu, 26 Jan 2017 20:48:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EEFB025E13 for ; Thu, 26 Jan 2017 20:48:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E244428329; Thu, 26 Jan 2017 20:48:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1CBD125E13 for ; Thu, 26 Jan 2017 20:48:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752770AbdAZUsP (ORCPT ); Thu, 26 Jan 2017 15:48:15 -0500 Received: from mail-by2nam01on0050.outbound.protection.outlook.com ([104.47.34.50]:36352 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752737AbdAZUsM (ORCPT ); Thu, 26 Jan 2017 15:48:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandiskcorp.onmicrosoft.com; s=selector1-sandisk-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jAV0aG0CHQ0l3lt5tskb2omOpoF1j212IlfGzG4k81s=; b=HE6x+r286TS3AcHo/V46lXiHh+0URctNvk+CKbyGFYliscEriB28erzhmE1F5uohZq8miYGGbL7dsP9MuVWGc/xfEYvB122Mo4t29PWv7F5r74hnQY6aOxlbeqPLLY/UC68pNrKri3oFIbfchy7R6Dr9X2QaQh9POdYsNobQ9AE= Received: from BY2PR02CA0032.namprd02.prod.outlook.com (10.141.216.22) by DM2PR02MB1290.namprd02.prod.outlook.com (10.161.142.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.12; Thu, 26 Jan 2017 20:48:03 +0000 Received: from BN1BFFO11FD002.protection.gbl (2a01:111:f400:7c10::1:130) by BY2PR02CA0032.outlook.office365.com (2a01:111:e400:2c40::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.12 via Frontend Transport; Thu, 26 Jan 2017 20:48:03 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; ce.jp.nec.com; dkim=none (message not signed) header.d=none;ce.jp.nec.com; dmarc=bestguesspass action=none header.from=sandisk.com; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.21 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.21; helo=milsmgep15.sandisk.com; Received: from milsmgep15.sandisk.com (63.163.107.21) by BN1BFFO11FD002.mail.protection.outlook.com (10.58.144.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.2 via Frontend Transport; Thu, 26 Jan 2017 20:48:01 +0000 Received: from MILHUBIP04.sdcorp.global.sandisk.com (Unknown_Domain [10.201.67.162]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id FE.4B.65426.BAD5A885; Thu, 26 Jan 2017 12:35:58 -0800 (PST) Received: from milsmgip12.sandisk.com (10.177.9.6) by MILHUBIP04.sdcorp.global.sandisk.com (10.177.9.97) with Microsoft SMTP Server id 14.3.319.2; Thu, 26 Jan 2017 12:47:57 -0800 X-AuditID: 0ac94369-7dfff7000001ff92-14-588a5dab92c0 Received: from exp-402881.sandisk.com ( [10.177.9.6]) by (Symantec Messaging Gateway) with SMTP id 10.8A.09762.9706A885; Thu, 26 Jan 2017 12:47:57 -0800 (PST) Subject: Re: [dm-devel] split scsi passthrough fields out of struct request V2 To: Jens Axboe , "hch@lst.de" References: <1485365126-23210-1-git-send-email-hch@lst.de> <1485455329.2540.7.camel@sandisk.com> <1485456745.2540.9.camel@sandisk.com> <20170126185924.GA25289@lst.de> CC: "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "snitzer@redhat.com" , "linux-raid@vger.kernel.org" , "dm-devel@redhat.com" , "j-nomura@ce.jp.nec.com" , Bart Van Assche From: Bart Van Assche Message-ID: <71e22257-0592-fdd3-25e5-a78ceced2ab9@sandisk.com> Date: Thu, 26 Jan 2017 12:47:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjkeLIzCtJLcpLzFFi42LhOum8SHddbFeEwfVvZhb/9xxjs9j7bjar xcrVR5ksJnYfAnJvaVu0z9/FaNF9fQebRdvGr4wOHB5Pfy1l95jY/I7dY/fNBjaP9/uusnl8 3iQXwBrFZZOSmpNZllqkb5fAlfFlFnvBC4uKAz/usDUw3jXoYuTkkBAwkdjRtoi9i5GLQ0hg KZPE5sOP2CCcbYwS/Yuus8NU7Tt0mwUisZhRYvr87UAOB4ewgJ/EhysSIDUiAhYSH2Z8gqrZ xSRx6/VdRhCHWeAHk8SN813MIFVsAkYS397PZAGxeQXsJG58v8MGYrMIqEp82nqeFWSoqEAE kG0EUSIocXLmE7ByTgErib6NHxhBbGYBA4kji+awQtjyEtvfzmEG2SUhcJdVYtqSx0wgCSEB dYmTS+YzTWAUnoVk1iwk/bOQ9C9gZF7FKJabmVOcm55aYGiqV5yYl5JZnK2XnJ+7iRESO5k7 GO8+8T7EKMDBqMTDyyDbFSHEmlhWXJl7iFGCg1lJhNc+FCjEm5JYWZValB9fVJqTWnyIUZqD RUmc1+3elzAhgfTEktTs1NSC1CKYLBMHp1QDY6B+8/IoidbtBlaZN3e/Sfub6vD90tJpPAfX vb0Qf6KYm5393+IlHwo4F5ZOrWiZ8mSWxaIf75bfcEnuceJQ6L3Nzim7S8z7p2Q4Uyy/9Pqg 6oT51WHfLMNWFh3S0ut+lGhw0Tkm+/FVMe/1Bkd0QuPmLg7hFQ136Jl5LmTXmtkLoxe8mzxJ UomlOCPRUIu5qDgRAGSTH6eZAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplluLIzCtJLcpLzFFi42Lh2sjJplub0BVh8H4tv8X/PcfYLA7+bGO0 2PtuNqvFytVHmSwmdh9is9h7S9uiff4uRovu6zvYLNo2fmV04PR4+mspu8fE5nfsHrtvNrB5 vN93lc1j2przTB6fN8kFsEVx2aSk5mSWpRbp2yVwZXyZxV7wwqLiwI87bA2Mdw26GDk5JARM JPYdus3SxcjFISSwkFGi9+RG5i5GDg5hAT+JD1ckQGpEBCwkPsz4BFWzi0ni1uu7jCAOs8Av Jon3X6cyg1SxCRhJfHs/kwXE5hWwk7jx/Q4biM0ioCrxaet5VpChogIRQLYRRImgxMmZT8DK OQWsJPo2fmAEsZkF9CR2XP/FCmHLS2x/O4d5AiPfLCQts5CUzUJStoCReRWjWG5mTnFuemaB oZFecWJeSmZxtl5yfu4mRkhAR+1gvD7R/BAjEwenVAPjjBtvfx01mu37xmrBUp95MkWmai3i 3PHv3Biv3H8hmbj1cYrPeUmFWVeiLU6ptEXy3N6Qoc5xl7nthbDijljbopNyrqsnbZJfHadX /OOp6AYxrv18nkskjPNfZP6I6rO9Y+F7+/oD/wNtF7vmGbKt/7fP+9Wy7fNPP2rqU2BwN576 vs4m6t9PJZbijERDLeai4kQAFIK1JBgCAAA= X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.21; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(39840400002)(39860400002)(39850400002)(39410400002)(2980300002)(438002)(24454002)(199003)(189002)(377454003)(2270400002)(64126003)(77096006)(230700001)(92566002)(50466002)(23746002)(47776003)(65806001)(65956001)(68736007)(53936002)(36756003)(5001770100001)(97736004)(305945005)(4001350100001)(189998001)(4001430100002)(107886002)(575784001)(356003)(31696002)(69596002)(83506001)(50986999)(54356999)(106466001)(65826007)(5660300001)(229853002)(33646002)(53416004)(86362001)(626004)(76176999)(2501003)(8936002)(54906002)(6666003)(2950100002)(2906002)(93886004)(81166006)(4326007)(38730400001)(81156014)(31686004)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR02MB1290; H:milsmgep15.sandisk.com; FPR:; SPF:Pass; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD002; 1:xyfSDFdNlQ9ZnKoShYUJZTkTRTwJYhaHXwmdMfzsnNRq+g3qfUrDSgtsw06PP5HuO6Qh1uZKLk7JXw/06CXYiUiSWN8LMUCR0tv7jeiPdYjBWVSbXc9EPThpViCG0hkB9UKWr8AOcnw8qLuXOWa49R+tASaaeG8ybksn9xe4MTrkoxguaq4Yn1vBJva8++S/BXlMfkacmnZAoq1XYudwuBEja+qpy490cGliCm1g4Prq9G5qNUGQW/fKQqHA4ifs2Yh+RPRen31ACKViZfCNsfKKTm5leWTOLpGLEnkBwplHAAZiBX9RmaD/691mzg8eJ1DefS6Yq4dZf9qezDGsmWzsSk2pDNdd9z4xuXK5Hk3BNa6zdmbkw+VFmLtfeT+ggQmdyPJHpNpGfFu2YjYlqEZXYFwHIteBd5kCdzhITq3T53O1TpKEVzbwd+/1OLwdR+KlFyXiysM3doN2ETf5KFpDq/41mKqvL8myoE1qRJ8uy4ubfqxBrBDr6P08kIml X-MS-Office365-Filtering-Correlation-Id: 64f1c216-8de1-4fc9-01f4-08d4462c9f10 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002); SRVR:DM2PR02MB1290; X-Microsoft-Exchange-Diagnostics: 1; DM2PR02MB1290; 3:1aAEoOIN5uV9D6LUYYO1Hq9Op+flSO6VV4MeX38tLK5+D7i5IojsbISpqaOaUlcbzCslE3M0iG8f/N3NJVxPSRR4o/9Z49dTI6/gANKy3+Abs8TX0p+4/ljGy8WEwCnLOu/1ErYGvuBGjkXNC3JnHcPbhc2Vr+KMZrh1wxMH5MgFpWU2MYiEBjkxlVJ/iZCLjp/SEfc7XlAUB0f8ekmIR7OHYJtuA75qsbgeRjxSqnt5IyxdssQ1mwOTgzZ5j1xCWtGI7fBR/y2Guh7095sJ+EguKY7NFyegU6yAA1EIGoIafS8go5u7sk3yvFkCGHOIVVkOo14HwTSTPZ9HKXsdm1Pjo7I+YuPkEfr7mWNVSi2L3UYQm68HaTtVXqWNsofS5tr94DoIVS5rhLeC4RkGMw==; 25:X/hXuM+ULWXPRLixvJmJF4qX3vmoBuaFrJWO+PD5L55E60PeEr64Fe5k3wHZCg5h+LeGbhfIcYxFp9n2ROiPM70VZyJh9wyKKv4hfrTfNCpDu7/vwSHnlwnabuyAB2CodODkJhteabm1u/B0zjfvqWez2cz97Si6zFg8RX2D6eDz1xqal5NVcXoGzeKgLdE9uR4fbF+qEiS+ozHwPMhMhM9i6YlS8yz+wwOJZBWrYO9uA09hkCCS9sjeS06txLUSZqPfbLj7S3uhn9WBSCMrNhJUOmGrIQxq/5C1f9Fw13UY68wE38d0LWCQQYOqLvVxkFysCr8qLOOiCyfGPd4Ypgt3S8gg5csAFpV1wf1XO1pthiQvD2vxit/UtdAFplQPhOCxBqHS7o1ekKzS+wtDXZAe0gDbcouA8kGqATKegMf2bUlr5isFd69Cr5aXn3CoQWeNb3s0URH0lZd0CnXZVQ== X-Microsoft-Exchange-Diagnostics: 1; DM2PR02MB1290; 31:S9D+MOxvILulbBRJlmouW8LNDolCdX6ba2SFOq5Hcf/5oRF3cDJnjNBoGRHKSJ55x/ognfYbl6OSF3ilsRFgMXM7QDvSPuhOZ+EqVe7hGlKeuA4u8XBuFyYiupDW6Ywe44elBmBI5Yvo5/hl2bCt7KROpTcwy83XolKMUgMBI1lC8RgeJvA1wi0QHLygXxLMotqcTY4n8CguRJzpI9iTu9+h/jrY7bZxpmSr+bIq/43AJ7/Jro1uf8LU2OqwWqp9OVV4ZoLrVTycTLdpDPnJxg==; 20:Uf2VD6erNVaPKP72Iqu7ehfjQ5gRaP05tC7Bu9C3FsL0ynBfBwmoiwX4acALupRO5EQLbLY9CHZllNRGXxNDzX4LpADhKsVGhqHc4DKRUMa6kVzv0kvd4Sgb5AAannNrYP5qJyUR6iD9/NkKwanmi32FEz0+GE52XAWNSWBEgZVvhAWGb4JgE6oqLhZudCtmCD3brNE7rC0PBEXdlzVVhU3Do+RSGzHZHoeG+D8CZrYNS5QbZf3SrrjbpEjnP3Bj4utzbzEaUtS4tXCUVfY6xsMfV65yHT6q5x1K7r51yHlOwxfJeRheasFivZ5qV/IedE+Uf5prLDMhigGjoPSaAHs/9jlAwTetNdRDTCGVPb4HTodQ3riU3+9osdqpsawcP5o20WdBXgxZWCq6n8TEduvhanDSNhAb05VjvCCGd9HEO3i3c9gUHLKvEZGcb/kRaMTQTQV8Gp4HxKeYY633RA12ineNr8UA8D88J1F3wdUued+uOKYm2hFWwCHhMJYY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(13016025)(13018025)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(6072148); SRVR:DM2PR02MB1290; BCL:0; PCL:0; RULEID:; SRVR:DM2PR02MB1290; X-Microsoft-Exchange-Diagnostics: 1; DM2PR02MB1290; 4:pvwhgLSxlXrczHwACFX6GpC0OPdKGaX9LpD8Ds8yudJ6JDdGt8Bv4bpPZAsnyK2Zf6ep6B/Ie5ipc1CxG2Leaychr0AXZi3IXRMuR4rpUh8xxArzRaHAxiHJ5ab2p7vFlbqNJlrXjUTBVpJPnntggAH9Qvjfvb2WqI+dd4jt/V/dNqF/AnvvBnXNY0LZw7znJLjxAQr6K6koLwbmp1pzpQyje1w3EZMN72Zffq6QEwwxV4YsOtdP8TdyYRZnWWNl64NFybTZpkJ8/whnIjk9exwzPFg4V0w9SSG1EAcBmrvpJ91hkhh5ipDfo84KaxSHv4sIHF+BuhkZBtQmRBWdhgsHcc+bd1I/fcU2VxoXzucAHyZfmyqaUJHpfp4TP1+mrt/MnUwudFCDOU1A/Tlz2mlSzzU2OSGR+u2C+JLokYcW1GKjTfa94gRvYoxn0Q//Xy7V1Bl9WcdHUABN4Xyo1aaa7gFXoEHlRGlzw8oq3ff7y4iw0zCVD1YV7yiORwi/ro0qWXQ0gVFDzU/OUpoexFjOylnPGEKId7D650Di/vNsOY4HbhfU4k8wBDTIX2RcYYikRAjV3XxAIvcr/cgFOICrBQP9qZ4S3YSEYyv9RuCLDZ2UowqfZZR9zar9SzbJ X-Forefront-PRVS: 019919A9E4 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM2PR02MB1290; 23:FmTOPdWlaGYeOifgGQBwUcU9wPq149pMFL63+?= =?Windows-1252?Q?kVe/vWUPNPe722k273wR7RCgg4mwjsl4uNIoPG0K8lPhgTeTsSEX5YwW?= =?Windows-1252?Q?/bYVSPXupA9aNBSid8HM1JipVDPCz28PCz7UhG0lIybNCYxkjn7Y8iir?= =?Windows-1252?Q?bZIbvr7GWWDyx55PoBIZCusV/BAuVW2lleGGH7PefBU3UlBe1BWV8wwH?= =?Windows-1252?Q?qX25OIZumDpQsehB1o08RMzRhzRjAwh0Me6upJ8gwakE7d/VljYI7xpT?= =?Windows-1252?Q?e6RfLrYXTXygPVcTCJPUyh9BD7vI4Dq0EUYxraG+mAbvozUDuA7qIayZ?= =?Windows-1252?Q?W3oYTOQ9NpTDs+8e5AyI2rFExt+Zc919ihW/gKKjkbtMXemlkTPt9Nm/?= =?Windows-1252?Q?3wbqJ+KiXYotvPib8MdC76xJR7E+NI8aO+zLRzOW7Qz4hvqM6gRD7Nbw?= =?Windows-1252?Q?qR+Nz1w7VRkSlyAvz7vhlAuTZKw/YSd8P+9jtvR8HHFIfDoo9vt2VRju?= =?Windows-1252?Q?RwirYRxkRrjsnt95Jr6exbZmfURDFWva2NgQ1fRmFO80EaROUXsXNM5y?= =?Windows-1252?Q?f0R+IefD18t64R8GzBkVNMXcJpupN+o/tmTqpausKOAz7azm/ADy7XqD?= =?Windows-1252?Q?w1j0VTcAnA9sU7UfQ3qhu1G/jcJeLNxDw1SCK5s3Lc/2A3n5EVJ6/mQT?= =?Windows-1252?Q?+d1M/c9Wb5e/PrhUUxuQUYD9hsJL7ZnFJ/KVkb0doPTz7MtrfV7yoMxt?= =?Windows-1252?Q?CqBWizCSm9eu4R7GKlsKj24ohYr6qYmcR1FKOJHqUs2mk3ciKVd2kvlx?= =?Windows-1252?Q?AJ7Y1oq/5lbnHjTkvbKHJLvmPolve4DVBDgTyNJzR3Y9wd3LgfUCPEvy?= =?Windows-1252?Q?mXyJCRRajubAPfpNBHJe1sKg8ghMx6q6wn3UNr6HsoIB7ZlH6JclLWfE?= =?Windows-1252?Q?+arC8jguosU/2mLpRa7SlY2EN9Iw2PeeWeMRlQcHRBF9BrhdVNM/RYHR?= =?Windows-1252?Q?KzYQd+Z95kzQOR6WH9S48dxu7kGBiYqpXoZsUi93PzsFkE2GXmJS29P/?= =?Windows-1252?Q?kPd9h/DbcZEr1Bh9Yuib77r9P7eDtdbCsSgJQC7/Ii9rlb564zMHCxxq?= =?Windows-1252?Q?X2GnPijtG6yUctzL5EpDajvYm0iMMcMirK3zOKCGJ4RcifWJO5xGQqX4?= =?Windows-1252?Q?+HCr5fmCM1m8TSQ9jEXIWfjyXvwPLaaGij6v8fCY/FanN6VnzvRXkeBS?= =?Windows-1252?Q?cVLXiwXrpPaNX6AhbYYF0CoAoxYGNz+TNC38RJOfzXQDLBr5oKVN4mJd?= =?Windows-1252?Q?3wFQaOM4nJ3Gy7xDXl1sXfH4V2e4OakqntmKqy7lj3phtV0I81ztGIIV?= =?Windows-1252?Q?F4RzEAr/NQAtd6L5T/6LrYBemuJLqmzYifhyLKpP+8AQSblwBZJjZGoe?= =?Windows-1252?Q?Udo/VY0IDJFhEdXUe+DsN63zi0WdV66stU8lzAbJPD46H9CDHTwh0OlZ?= =?Windows-1252?Q?EotUTqcUBQmI8x2DAdVRcLABUnnjuJlW9RI/JQLrkb9VXasmKWkzPKjd?= =?Windows-1252?Q?LPtIt0VgtR/mKusQ45LxVoPGTahZHqQTtNhQi/BSEqLM1r0s1GCNPVpO?= =?Windows-1252?Q?uzU/3fo/Mii7Z6c70G310s=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR02MB1290; 6:ifdKcD5Fcf1Yry4hyaJo++WWArj4KYB9NHfA9jw3jOKhwgTEZcN0QakpsIf1cm7+Sg17zdEkInZe6TuPcXoKbKNXHKqCN2tDUPcxae94csaIeRYyXcv5PkGC1bPg0MNAhrou4cSRUj7efpellAXOHom7GnKQTQXaE19j7x//a5+AnDtGY8P9Git9PxqUMvLffCgY8LSWcQh3B5TjxG/82QhzhNCYq/2Q4IAQ8NxMHKmbzlTgPNvodumpSUwhOAEU9vhTWmXxQWAOKsz2TeoQtgwwlHILn0NOsjsJlkAvOgOGtA4YjSTSAl4D1Fy3OHilCyU8H6xmLmmlDNexnTQDhmX2nw1gaIdJv08mVtLQVL3tuZnB3llKHpLhvYcvILWCikqIPyb9Nx+0HYzpEAVGrFIYrvB6ThbUc8TwrdziAfQu3ErLwsCY30Rvzfs/vhNuuEj7eJuJ3hh1ufvMXBeH+w==; 5:BBg2vCJ/btnozsetnaxFol2E8a51DBpt61IgdvttZsBa9wxklDANBuS7wDCY995Kac0WGg+IKItq97Tsb32P0dN3gIyp5CjtALvIpa6xUkpBqkZ73GwVolFEU/q9JxOdQWVmcV5kXVCF2AsaPeoOvA==; 24:xdrqiQtymN144YRcUxAFvbaxP5XfKNl1/T/NR2Ya38eoYwmou1ztxihwUnJoy8q9UDtn70iqEOmk88+MDp45LD7faRwwHbPByydvlpmMdtM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM2PR02MB1290; 7:xTqW/VR2HIbnurKt3l8kLCD2yOoFPxXcKMRXYLXcKmGem4F9w+L/8x06eOynj/7WCRRJ/+WVcqR1OxfL7cPwAeVcpQKKyAazWy9wo9Gs9P4PKPE6/nQ8A0LJmn33zhl5dois1ONsZtFwZCTUlmDVqjZlGpZx+oe8MBpAiKOHNaQe37kKeoYHrP3KBeYsPBTNYTleHrMLGKkKxA0SUQSaCbp7qrM+LtphJwbT8N/biE6uTQ8FLKKM+M8udppqHhCwdVQjyacRmCe3I6ZEEVn3OqyewRE+FiOu/GvlmZ+j+FoOgcejElMt7nKWH3Kf128vSuK66PQpxL3zkg+CfUKhI2OEXKZAFjCvXQUCl+K3p1PLMZMSQtY677WfYyyEH29tD4+UFxaRLEBFAEND2ZuMTB9c7Lgx+unBAYX1sQ8maryp3VD2lA5tFnbJpcPkouFMcpWzjO9rqKE97E9txC3LDA== X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2017 20:48:01.9258 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d; Ip=[63.163.107.21]; Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR02MB1290 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 01/26/2017 11:01 AM, Jens Axboe wrote: > On 01/26/2017 11:59 AM, hch@lst.de wrote: >> On Thu, Jan 26, 2017 at 11:57:36AM -0700, Jens Axboe wrote: >>> It's against my for-4.11/block, which you were running under Christoph's >>> patches. Maybe he's using an older version? In any case, should be >>> pretty trivial for you to hand apply. Just ensure that .flags is set to >>> 0 for the common cases, and inherit 'flags' when it is passed in. >> >> No, the flush op cleanups you asked for last round create a conflict >> with your patch. They should be trivial to fix, though. > > Ah, makes sense. And yes, as I said, should be trivial to hand apply the > hunk that does fail. Hello Jens and Christoph, With the below patch applied the test got a little further but did not pass unfortunately. I tried to analyze the new call stack but it's not yet clear to me what is going on. The patch I had applied on Christoph's tree: --- block/blk-mq-sched.c | 2 +- block/blk-mq.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c index 3bd66e50ec84..7c9318755fab 100644 --- a/block/blk-mq-sched.c +++ b/block/blk-mq-sched.c @@ -116,7 +116,7 @@ struct request *blk_mq_sched_get_request(struct request_queue *q, ctx = blk_mq_get_ctx(q); hctx = blk_mq_map_queue(q, ctx->cpu); - blk_mq_set_alloc_data(data, q, 0, ctx, hctx); + blk_mq_set_alloc_data(data, q, data->flags, ctx, hctx); if (e) { data->flags |= BLK_MQ_REQ_INTERNAL; diff --git a/block/blk-mq.c b/block/blk-mq.c index 83640869d9e4..6697626e5d32 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -248,7 +248,7 @@ EXPORT_SYMBOL_GPL(__blk_mq_alloc_request); struct request *blk_mq_alloc_request(struct request_queue *q, int rw, unsigned int flags) { - struct blk_mq_alloc_data alloc_data; + struct blk_mq_alloc_data alloc_data = { .flags = flags }; struct request *rq; int ret; @@ -1369,7 +1369,7 @@ static blk_qc_t blk_mq_make_request(struct request_queue *q, struct bio *bio) { const int is_sync = op_is_sync(bio->bi_opf); const int is_flush_fua = op_is_flush(bio->bi_opf); - struct blk_mq_alloc_data data; + struct blk_mq_alloc_data data = { }; struct request *rq; unsigned int request_count = 0, srcu_idx; struct blk_plug *plug; @@ -1491,7 +1491,7 @@ static blk_qc_t blk_sq_make_request(struct request_queue *q, struct bio *bio) const int is_flush_fua = op_is_flush(bio->bi_opf); struct blk_plug *plug; unsigned int request_count = 0; - struct blk_mq_alloc_data data; + struct blk_mq_alloc_data data = { }; struct request *rq; blk_qc_t cookie; unsigned int wb_acct;