mbox series

[GIT,PULL] nvme fixes for Linux 5.16

Message ID YZ+X/qGC6/w3bp2c@infradead.org (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL] nvme fixes for Linux 5.16 | expand

Pull-request

git://git.infradead.org/nvme.git tags/nvme-5.16-2021-11-25

Message

Christoph Hellwig Nov. 25, 2021, 2:04 p.m. UTC
The following changes since commit efcf5932230b9472cfdbe01c858726f29ac5ec7d:

  block: avoid to touch unloaded module instance when opening bdev (2021-11-22 18:35:37 -0700)

are available in the Git repository at:

  git://git.infradead.org/nvme.git tags/nvme-5.16-2021-11-25

for you to fetch changes up to 95ec70a9f3f9133304a0295af58d4f05ed27661c:

  nvmet: use IOCB_NOWAIT only if the filesystem supports it (2021-11-23 17:22:43 +0100)

----------------------------------------------------------------
nvme fixes for Linux 5.16

 - add a NO APST quirk for a Kioxia device (Enzo Matsumiya)
 - fix write zeroes pi (Klaus Jensen)
 - various TCP transport fixes (Maurizio Lombardi and Varun Prakash)
 - ignore invalid fast_io_fail_tmo values (Maurizio Lombardi)
 - use IOCB_NOWAIT only if the filesystem supports it (Maurizio Lombardi)

----------------------------------------------------------------
Enzo Matsumiya (1):
      nvme-pci: add NO APST quirk for Kioxia device

Klaus Jensen (1):
      nvme: fix write zeroes pi

Maurizio Lombardi (6):
      nvmet-tcp: fix a race condition between release_queue and io_work
      nvmet-tcp: add an helper to free the cmd buffers
      nvmet-tcp: fix memory leak when performing a controller reset
      nvme-tcp: fix memory leak when freeing a queue
      nvme-fabrics: ignore invalid fast_io_fail_tmo values
      nvmet: use IOCB_NOWAIT only if the filesystem supports it

Varun Prakash (2):
      nvmet-tcp: fix incomplete data digest send
      nvme-tcp: validate R2T PDU in nvme_tcp_handle_r2t()

 drivers/nvme/host/core.c          | 29 +++++++++++++++++--
 drivers/nvme/host/fabrics.c       |  3 ++
 drivers/nvme/host/tcp.c           | 61 +++++++++++++++++++--------------------
 drivers/nvme/target/io-cmd-file.c |  2 ++
 drivers/nvme/target/tcp.c         | 44 ++++++++++++++++++++--------
 5 files changed, 93 insertions(+), 46 deletions(-)

Comments

Jens Axboe Nov. 25, 2021, 2:55 p.m. UTC | #1
On 11/25/21 7:04 AM, Christoph Hellwig wrote:
>  drivers/nvme/host/core.c          | 29 +++++++++++++++++--
>  drivers/nvme/host/fabrics.c       |  3 ++
>  drivers/nvme/host/tcp.c           | 61 +++++++++++++++++++--------------------
>  drivers/nvme/target/io-cmd-file.c |  2 ++
>  drivers/nvme/target/tcp.c         | 44 ++++++++++++++++++++--------
>  5 files changed, 93 insertions(+), 46 deletions(-)

This doesn't match what I get:

 drivers/nvme/host/core.c          | 29 +++++++++++++++++++---
 drivers/nvme/host/fabrics.c       |  3 +++
 drivers/nvme/host/tcp.c           | 61 +++++++++++++++++++++++-----------------------
 drivers/nvme/target/io-cmd-file.c |  4 ++-
 drivers/nvme/target/tcp.c         | 44 ++++++++++++++++++++++++---------
 5 files changed, 94 insertions(+), 47 deletions(-)

Hmm?
Christoph Hellwig Nov. 25, 2021, 3:05 p.m. UTC | #2
On Thu, Nov 25, 2021 at 07:55:38AM -0700, Jens Axboe wrote:
> On 11/25/21 7:04 AM, Christoph Hellwig wrote:
> >  drivers/nvme/host/core.c          | 29 +++++++++++++++++--
> >  drivers/nvme/host/fabrics.c       |  3 ++
> >  drivers/nvme/host/tcp.c           | 61 +++++++++++++++++++--------------------
> >  drivers/nvme/target/io-cmd-file.c |  2 ++
> >  drivers/nvme/target/tcp.c         | 44 ++++++++++++++++++++--------
> >  5 files changed, 93 insertions(+), 46 deletions(-)
> 
> This doesn't match what I get:
> 
>  drivers/nvme/host/core.c          | 29 +++++++++++++++++++---
>  drivers/nvme/host/fabrics.c       |  3 +++
>  drivers/nvme/host/tcp.c           | 61 +++++++++++++++++++++++-----------------------
>  drivers/nvme/target/io-cmd-file.c |  4 ++-
>  drivers/nvme/target/tcp.c         | 44 ++++++++++++++++++++++++---------
>  5 files changed, 94 insertions(+), 47 deletions(-)
> 
> Hmm?

Looks like the diffstt doesn't include the the requested reformatting
in io-cmd-file.c.  But I have no idea why.
Jens Axboe Nov. 25, 2021, 3:59 p.m. UTC | #3
On 11/25/21 8:05 AM, Christoph Hellwig wrote:
> On Thu, Nov 25, 2021 at 07:55:38AM -0700, Jens Axboe wrote:
>> On 11/25/21 7:04 AM, Christoph Hellwig wrote:
>>>  drivers/nvme/host/core.c          | 29 +++++++++++++++++--
>>>  drivers/nvme/host/fabrics.c       |  3 ++
>>>  drivers/nvme/host/tcp.c           | 61 +++++++++++++++++++--------------------
>>>  drivers/nvme/target/io-cmd-file.c |  2 ++
>>>  drivers/nvme/target/tcp.c         | 44 ++++++++++++++++++++--------
>>>  5 files changed, 93 insertions(+), 46 deletions(-)
>>
>> This doesn't match what I get:
>>
>>  drivers/nvme/host/core.c          | 29 +++++++++++++++++++---
>>  drivers/nvme/host/fabrics.c       |  3 +++
>>  drivers/nvme/host/tcp.c           | 61 +++++++++++++++++++++++-----------------------
>>  drivers/nvme/target/io-cmd-file.c |  4 ++-
>>  drivers/nvme/target/tcp.c         | 44 ++++++++++++++++++++++++---------
>>  5 files changed, 94 insertions(+), 47 deletions(-)
>>
>> Hmm?
> 
> Looks like the diffstt doesn't include the the requested reformatting
> in io-cmd-file.c.  But I have no idea why.

Funky... I pulled it and pushed it out, just double check if it looks
consistent with what you expect.