| Message ID | a2de79b3de30fe70c457953af935dadd49441f00.1670069909.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: sed-opal: Don't include <linux/kernel.h> | expand |
On Sat, Dec 03, 2022 at 01:18:49PM +0100, Christophe JAILLET wrote: > #include <uapi/linux/sed-opal.h> > -#include <linux/kernel.h> > + > +#include <linux/compiler_types.h> /* for __user */ Not sure we really need the comment here, we don't comment on the other includes either. Also why the added empty line?
Le 05/12/2022 à 08:10, Christoph Hellwig a écrit : > On Sat, Dec 03, 2022 at 01:18:49PM +0100, Christophe JAILLET wrote: >> #include <uapi/linux/sed-opal.h> >> -#include <linux/kernel.h> >> + >> +#include <linux/compiler_types.h> /* for __user */ > > Not sure we really need the comment here, we don't comment on the > other includes either. Also why the added empty line? > Ok for the comment, I'll remove it. In header files, sometimes, when not obvious, we find such comments. Sometimes we don't. For the empty line, it was mostly a matter of taste. My goal was to explicitly show that one was <uapi/linux, and the other one only <linux/ I'll remove it as well. My main point, was only to remove kernel.h. CJ
diff --git a/include/linux/sed-opal.h b/include/linux/sed-opal.h index 6f837bb6c715..87f981c70894 100644 --- a/include/linux/sed-opal.h +++ b/include/linux/sed-opal.h @@ -11,7 +11,9 @@ #define LINUX_OPAL_H #include <uapi/linux/sed-opal.h> -#include <linux/kernel.h> + +#include <linux/compiler_types.h> /* for __user */ +#include <linux/types.h> struct opal_dev;
There is no need to include <linux/kernel.h> here. Prefer the less invasive <linux/types.h> and <linux/compiler_types.h> which are needed in this .h file itself. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Let see if build-bots agree with me! --- include/linux/sed-opal.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)