From patchwork Wed May 23 21:41:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Perches X-Patchwork-Id: 10422435 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 516E660224 for ; Wed, 23 May 2018 21:41:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3DA4C29268 for ; Wed, 23 May 2018 21:41:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2EA9B2927B; Wed, 23 May 2018 21:41:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9FE0B29268 for ; Wed, 23 May 2018 21:41:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934270AbeEWVli (ORCPT ); Wed, 23 May 2018 17:41:38 -0400 Received: from smtprelay0027.hostedemail.com ([216.40.44.27]:41972 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933066AbeEWVlg (ORCPT ); Wed, 23 May 2018 17:41:36 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 54E2C180A884F; Wed, 23 May 2018 21:41:35 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: can72_64abd0a8a1e21 X-Filterd-Recvd-Size: 3017 Received: from XPS-9350.home (unknown [47.151.150.235]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Wed, 23 May 2018 21:41:31 +0000 (UTC) Message-ID: Subject: Re: [PATCH] block drivers/block: Use octal not symbolic permissions From: Joe Perches To: Jens Axboe , "Ed L. Cashin" , Philipp Reisner , Lars Ellenberg , Jiri Kosina , Josef Bacik , linux-block@vger.kernel.org, Ilya Dryomov , Sage Weil , Alex Elder , Philip Kelleher , "Michael S. Tsirkin" , Jason Wang , Konrad Rzeszutek Wilk , Roger Pau =?ISO-8859-1?Q?Monn=E9?= , Boris Ostrovsky , Juergen Gross Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org Date: Wed, 23 May 2018 14:41:30 -0700 In-Reply-To: <6bf44255-145f-bf14-e254-860731ff9296@kernel.dk> References: <5e97a292c1ba38a6b5a0caa271d85dc3de1b2aa7.1527105857.git.joe@perches.com> <6bf44255-145f-bf14-e254-860731ff9296@kernel.dk> X-Mailer: Evolution 3.28.1-2 Mime-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 2018-05-23 at 15:27 -0600, Jens Axboe wrote: > On 5/23/18 2:05 PM, Joe Perches wrote: > > Convert the S_ symbolic permissions to their octal equivalents as > > using octal and not symbolic permissions is preferred by many as more > > readable. > > > > see: https://lkml.org/lkml/2016/8/2/1945 > > > > Done with automated conversion via: > > $ ./scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace > > > > Miscellanea: > > > > o Wrapped modified multi-line calls to a single line where appropriate > > o Realign modified multi-line calls to open parenthesis > > Honestly, I see this as pretty needless churn. It's just for consistency and the ability to highlight somewhat unusual permissions uses like just 0400. Apply it at your leisure or ignore it. btw: Joshua Morris' email address is bouncing. Maybe it should be removed from MAINTAINERS. --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) F: drivers/block/rsxx/ diff --git a/MAINTAINERS b/MAINTAINERS index 9051a9ca24a2..0d546a10d0b9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5598,7 +5598,6 @@ F: drivers/base/firmware_loader/ F: include/linux/firmware.h FLASH ADAPTER DRIVER (IBM Flash Adapter 900GB Full Height PCI Flash Card) -M: Joshua Morris M: Philip Kelleher S: Maintained