From patchwork Thu Apr 27 23:12:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 9703719 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BEAD1602CC for ; Thu, 27 Apr 2017 23:12:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B9BE826247 for ; Thu, 27 Apr 2017 23:12:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ABA9E277D9; Thu, 27 Apr 2017 23:12:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 17FA926247 for ; Thu, 27 Apr 2017 23:12:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754713AbdD0XMM (ORCPT ); Thu, 27 Apr 2017 19:12:12 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:34067 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752832AbdD0XML (ORCPT ); Thu, 27 Apr 2017 19:12:11 -0400 Received: by mail-pf0-f177.google.com with SMTP id e64so2789630pfd.1 for ; Thu, 27 Apr 2017 16:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=NvcUbb8Nl1qmDBiE3bJF4Qzl3IzqNcf5frcGEuVT2Fc=; b=j9srjtH666b2BDDNgOhco+VH6/KqDyMKHhbBdwwBpUPDywk/4kkN02YRRd5xIgI/xe 3qMERD7XnGaPXCxqc8w0gWIYVxdsc9FwwROzbIXpnsOfqOqYFeK52E/+cW7Zi+4VUD+v xAQG5+M44K1WRInIidOIy4/iI4kdOgUu8lqPNySkd2+DXQ8E74pUJaug6GjjlGxNyk0x +iI/apWQZq4qQC6FsgBK3/+ZYvxFvbJUct19aXy6Eyu6d6N5FESAbZOx0FYwBzh+vLLH 8dmHGB3N8R3iQpu10SfYHL2+lUtF6FEXRQl+fRQgTExLaXuIn2veRP2ihZyGe2RmTdht HMtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=NvcUbb8Nl1qmDBiE3bJF4Qzl3IzqNcf5frcGEuVT2Fc=; b=GdxbVk7IBc4KBDS21u9sNCsP320cnCMAGSzEUFkePH2gPPjQpYUSZHJtfnzjp0vBtI KwU6hnI6o78PTAhSdi1mWv0OilNUjRYvRtYwlY+WovG/OBYue0GmVdZD3hCmLt3bXxMS i4qSVI32LkrGaFjK3KNpmuQA5gjoWvItjxrf/MIqbxIk3UZ7Kflr94n3FRkgn+gZKfnz auY1OrJ3ufN76427zlPxB56JdEgg/clI/TCRjxbY0hWIKdlbBYBRdr7gplbrZZ/G5oD3 5vkoKNGSptGA9VgCMNDxZHtOKvomrULSUBCkJW8YkFM5+39dzpYXxN7wHOFSmqwvejYW Kq7A== X-Gm-Message-State: AN3rC/6CO3XQpwdCC43nDtBnZaZkT9NK9Rw/49vlLzrk31RgqMJNSh9G qwhVHTsDYKx61Q== X-Received: by 10.98.108.68 with SMTP id h65mr8436140pfc.98.1493334731149; Thu, 27 Apr 2017 16:12:11 -0700 (PDT) Received: from [192.168.1.176] (66.29.164.166.static.utbb.net. [66.29.164.166]) by smtp.gmail.com with ESMTPSA id d83sm7019785pfe.40.2017.04.27.16.12.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Apr 2017 16:12:10 -0700 (PDT) Subject: Re: [PATCH 0/6] Fixup mtip32xx for scheduling To: linux-block@vger.kernel.org References: <1493333494-600-1-git-send-email-axboe@fb.com> Cc: ming.lei@redhat.com, hch@lst.de From: Jens Axboe Message-ID: Date: Thu, 27 Apr 2017 17:12:08 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1493333494-600-1-git-send-email-axboe@fb.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 04/27/2017 04:51 PM, Jens Axboe wrote: > This attempts a cleaner solution, where we simply mark a request > as having come from the reserved pool. mtip32xx can then be > converted to using that info, and moving it's internal command > issue over to the regular block infrastructure. > > First three are prep/cleanup patches for mtip32xx, which an easier > conversion of the driver. I forgot one hunk when I split it up. When I tested it just now, you end up with a warning spew from blk_execute_rq_nowait(), since the request is not marked as passthrough. This needs to go on top of 5/6 to squash that: diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c index cf11d36..5c849ff 100644 --- a/drivers/block/mtip32xx/mtip32xx.c +++ b/drivers/block/mtip32xx/mtip32xx.c @@ -195,7 +195,7 @@ static struct mtip_cmd *mtip_get_int_command(struct driver_data *dd) if (mtip_check_surprise_removal(dd->pdev)) return NULL; - rq = blk_mq_alloc_request(dd->queue, 0, BLK_MQ_REQ_RESERVED); + rq = blk_mq_alloc_request(dd->queue, REQ_OP_DRV_IN, BLK_MQ_REQ_RESERVED); if (IS_ERR(rq)) return NULL;