From patchwork Wed Nov 14 13:35:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Johannes Thumshirn X-Patchwork-Id: 10682637 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A66BC3CF1 for ; Wed, 14 Nov 2018 13:35:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B174286E6 for ; Wed, 14 Nov 2018 13:35:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8FCFD2B38B; Wed, 14 Nov 2018 13:35:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3778A2B38C for ; Wed, 14 Nov 2018 13:35:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732504AbeKNXiq (ORCPT ); Wed, 14 Nov 2018 18:38:46 -0500 Received: from mx2.suse.de ([195.135.220.15]:52886 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726823AbeKNXiq (ORCPT ); Wed, 14 Nov 2018 18:38:46 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 331D3B076 for ; Wed, 14 Nov 2018 13:35:28 +0000 (UTC) From: Johannes Thumshirn To: David Sterba Cc: Linux BTRFS Mailinglist , Johannes Thumshirn Subject: [PATCH 0/6] btrfs: fix compiler warning with make W=1 Date: Wed, 14 Nov 2018 14:35:14 +0100 Message-Id: <20181114133520.16069-1-jthumshirn@suse.de> X-Mailer: git-send-email 2.16.4 MIME-Version: 1.0 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patchset fixes most of the compiler warnings encountered when building btrfs with make W=1. There are two more compiler warnings left in raid56.c: CC [M] fs/btrfs/raid56.o fs/btrfs/raid56.c: In function ‘finish_rmw’: fs/btrfs/raid56.c:1185:6: warning: variable ‘p_stripe’ set but not used [-Wunused-but-set-variable] int p_stripe = -1; ^ fs/btrfs/raid56.c: In function ‘finish_parity_scrub’: fs/btrfs/raid56.c:2343:6: warning: variable ‘p_stripe’ set but not used [-Wunused-but-set-variable] int p_stripe = -1; ^ but I'm currently unsure how an appropriate fix would look like. As far as I can tell these variables have always been unused since they have been introduced. There are still warnings left emitted by kernel-doc but these are subject to another patchset, this one only addresses the warnings generated by gcc. Johannes Thumshirn (6): btrfs: remove unused drop_on_err in btrfs_mkdir() btrfs: remove set but not used variable err in btrfs_add_link btrfs: remove unused function btrfs_sysfs_feature_update() btrfs: remove unused variable tree in bio_readpage_error() btrfs: remove unused variable tree in end_compressed_bio_write() btrfs: unconditionally provide function prototypes from free-space-tree.h fs/btrfs/compression.c | 2 -- fs/btrfs/extent_io.c | 3 --- fs/btrfs/free-space-tree.h | 2 -- fs/btrfs/inode.c | 16 ++++++---------- fs/btrfs/sysfs.c | 33 --------------------------------- fs/btrfs/sysfs.h | 2 -- 6 files changed, 6 insertions(+), 52 deletions(-) Reviewed-by: Nikolay Borisov Reviewed-by: Qu Wenruo