From patchwork Thu May 16 08:47:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Thumshirn X-Patchwork-Id: 10945959 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8642F14DB for ; Thu, 16 May 2019 08:48:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 781E628ACE for ; Thu, 16 May 2019 08:48:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6C8C828AD0; Thu, 16 May 2019 08:48:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5930028ACE for ; Thu, 16 May 2019 08:48:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727110AbfEPIsd (ORCPT ); Thu, 16 May 2019 04:48:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:33006 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726486AbfEPIsH (ORCPT ); Thu, 16 May 2019 04:48:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 99F5AAF61; Thu, 16 May 2019 08:48:05 +0000 (UTC) From: Johannes Thumshirn To: David Sterba Cc: Linux BTRFS Mailinglist , Chris Mason , Richard Weinberger , David Gstir , Nikolay Borisov , Johannes Thumshirn Subject: [PATCH v2 00/13] Add support for SHA-256 checksums Date: Thu, 16 May 2019 10:47:50 +0200 Message-Id: <20190516084803.9774-1-jthumshirn@suse.de> X-Mailer: git-send-email 2.16.4 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patchset add support for adding new checksum types in BTRFS. Currently BTRFS only supports CRC32C as data and metadata checksum, which is good if you only want to detect errors due to data corruption in hardware. But CRC32C isn't able cover other use-cases like de-duplication or cryptographically save data integrity guarantees. The following properties made SHA-256 interesting for these use-cases: - Still considered cryptographically sound - Reasonably well understood by the security industry - Result fits into the 32Byte/256Bit we have for the checksum in the on-disk format - Small enough collision space to make it feasible for data de-duplication - Fast enough to calculate and offloadable to crypto hardware via the kernel's crypto_shash framework. The patchset also provides mechanisms for plumbing in different hash algorithms relatively easy. Unfortunately this patchset also partially reverts commit: 9678c54388b6 ("btrfs: Remove custom crc32c init code") This is an intermediate submission, as a) mkfs.btrfs support is still missing and b) David requested to have three hash algorithms, where 1 is crc32c, one cryptographically secure and one in between. Johannes Thumshirn (13): btrfs: use btrfs_csum_data() instead of directly calling crc32c btrfs: resurrect btrfs_crc32c() btrfs: use btrfs_crc32c{,_final}() in for free space cache btrfs: don't assume ordered sums to be 4 bytes btrfs: dont assume compressed_bio sums to be 4 bytes btrfs: format checksums according to type for printing btrfs: add common checksum type validation btrfs: check for supported superblock checksum type before checksum validation btrfs: Simplify btrfs_check_super_csum() and get rid of size assumptions btrfs: add boilerplate code for directly including the crypto framework btrfs: directly call into crypto framework for checsumming btrfs: remove assumption about csum type form btrfs_print_data_csum_error() btrfs: add sha256 as another checksum algorithm fs/btrfs/Kconfig | 3 +- fs/btrfs/btrfs_inode.h | 33 +++++++-- fs/btrfs/check-integrity.c | 12 ++-- fs/btrfs/compression.c | 40 +++++++---- fs/btrfs/compression.h | 2 +- fs/btrfs/ctree.h | 28 +++++++- fs/btrfs/disk-io.c | 146 ++++++++++++++++++++++++++-------------- fs/btrfs/disk-io.h | 2 - fs/btrfs/extent-tree.c | 6 +- fs/btrfs/file-item.c | 38 ++++++----- fs/btrfs/free-space-cache.c | 10 ++- fs/btrfs/inode.c | 20 ++++-- fs/btrfs/ordered-data.c | 13 ++-- fs/btrfs/ordered-data.h | 4 +- fs/btrfs/scrub.c | 39 ++++++++--- fs/btrfs/send.c | 2 +- include/uapi/linux/btrfs_tree.h | 6 +- 17 files changed, 275 insertions(+), 129 deletions(-)