[v5,0/4] btrfs: support xxhash64 checksums

Message

Johannes Thumshirn Aug. 30, 2019, 11:36 a.m. UTC

Now that Nikolay's XXHASH64 support for the Crypto API has landed and BTRFS is
prepared for an easy addition of new checksums, this patchset implements
XXHASH64 as a second, fast but not cryptographically secure checksum hash.

For changelogs, please see the individual patches.

David Sterba (1):
  btrfs: sysfs: export supported checksums

Johannes Thumshirn (3):
  btrfs: turn checksum type define into a enum
  btrfs: create structure to encode checksum type and length
  btrfs: add xxhash64 to checksumming algorithms

 fs/btrfs/Kconfig                |  1 +
 fs/btrfs/ctree.c                | 23 +++++++++++++++++++++++
 fs/btrfs/ctree.h                | 20 ++------------------
 fs/btrfs/disk-io.c              |  1 +
 fs/btrfs/super.c                |  1 +
 fs/btrfs/sysfs.c                | 29 +++++++++++++++++++++++++++++
 include/uapi/linux/btrfs_tree.h |  5 ++++-
 7 files changed, 61 insertions(+), 19 deletions(-)

Comments

David Sterba Aug. 30, 2019, 3:06 p.m. UTC | #1

On Fri, Aug 30, 2019 at 01:36:07PM +0200, Johannes Thumshirn wrote:
> Now that Nikolay's XXHASH64 support for the Crypto API has landed and BTRFS is
> prepared for an easy addition of new checksums, this patchset implements
> XXHASH64 as a second, fast but not cryptographically secure checksum hash.
> 
> For changelogs, please see the individual patches.
> 
> David Sterba (1):
>   btrfs: sysfs: export supported checksums
> 
> Johannes Thumshirn (3):
>   btrfs: turn checksum type define into a enum
>   btrfs: create structure to encode checksum type and length
>   btrfs: add xxhash64 to checksumming algorithms

I'll add 1 and 2 to misc-next as they aren't risky, xxhash will wait
until the code freeze. The sysfs export needs more work but it's not
urgent now, would be ok with the rest of hash updates.

Johannes Thumshirn Sept. 3, 2019, 7:49 a.m. UTC | #2

On 30/08/2019 17:06, David Sterba wrote:
> On Fri, Aug 30, 2019 at 01:36:07PM +0200, Johannes Thumshirn wrote:
>> Now that Nikolay's XXHASH64 support for the Crypto API has landed and BTRFS is
>> prepared for an easy addition of new checksums, this patchset implements
>> XXHASH64 as a second, fast but not cryptographically secure checksum hash.
>>
>> For changelogs, please see the individual patches.
>>
>> David Sterba (1):
>>   btrfs: sysfs: export supported checksums
>>
>> Johannes Thumshirn (3):
>>   btrfs: turn checksum type define into a enum
>>   btrfs: create structure to encode checksum type and length
>>   btrfs: add xxhash64 to checksumming algorithms
> 
> I'll add 1 and 2 to misc-next as they aren't risky, xxhash will wait
> until the code freeze. The sysfs export needs more work but it's not
> urgent now, would be ok with the rest of hash updates.
> 

Yeah the sysfs stuff broke with the ctree.h -> ctree.c move, sorry for
that. I'm just curious why it didn't break with my GCC...