[v4,0/4] btrfs: bypass UUID API aliasing

Message

Andy Shevchenko Feb. 24, 2020, 3:37 p.m. UTC

UUID API has been converted to differentiate UUID and GUID.
Btrfs is using aliases to the new API for some time.

Bypass that aliasing by converting btrfs to use API calls directly.

The series has been compiled only.

P.S. It may be applied either to btrfs tree or to UUID one.

Change v3:
- rebase to latest kernel base (Linux Next)
- explain in cover letter purpose of conversion (Johannes)

Andy Shevchenko (4):
  uuid: Add inline helpers to import / export UUIDs
  uuid: Provide a GUID generator for raw buffer
  Btrfs: Switch to use new generic UUID API
  uuid: Remove no more needed macro

 fs/btrfs/disk-io.c     |  6 +++---
 fs/btrfs/ioctl.c       |  4 +---
 fs/btrfs/root-tree.c   |  4 +---
 fs/btrfs/transaction.c |  7 +++----
 include/linux/uuid.h   | 22 +++++++++++++++++++++-
 lib/uuid.c             | 10 ++++++++++
 6 files changed, 39 insertions(+), 14 deletions(-)

Comments

David Sterba Feb. 24, 2020, 5:26 p.m. UTC | #1

On Mon, Feb 24, 2020 at 05:37:48PM +0200, Andy Shevchenko wrote:
> UUID API has been converted to differentiate UUID and GUID.
> Btrfs is using aliases to the new API for some time.
> 
> Bypass that aliasing by converting btrfs to use API calls directly.
> 
> The series has been compiled only.

Now it looks good to me, all the objections have been addressed, thanks.

> P.S. It may be applied either to btrfs tree or to UUID one.

Both works for me. There are no conflicts with current btrfs queue and I
don't expect anything serious in the future.

Christoph Hellwig Feb. 24, 2020, 5:58 p.m. UTC | #2

On Mon, Feb 24, 2020 at 06:26:45PM +0100, David Sterba wrote:
> On Mon, Feb 24, 2020 at 05:37:48PM +0200, Andy Shevchenko wrote:
> > UUID API has been converted to differentiate UUID and GUID.
> > Btrfs is using aliases to the new API for some time.
> > 
> > Bypass that aliasing by converting btrfs to use API calls directly.
> > 
> > The series has been compiled only.
> 
> Now it looks good to me, all the objections have been addressed, thanks.
> 
> > P.S. It may be applied either to btrfs tree or to UUID one.
> 
> Both works for me. There are no conflicts with current btrfs queue and I
> don't expect anything serious in the future.

Please pick it up through the btrfs tree.