| Message ID | cover.1604015464.git.boris@bur.io (mailing list archive) |
|---|---|
| Headers | show |
| Series | btrfs: free space tree mounting fixes | expand |
On 10/29/20 7:57 PM, Boris Burkov wrote: > This patch set cleans up issues surrounding enabling and disabling various > free space cache features and their reporting in /proc/mounts. Because the > improvements became somewhat complex, the series starts by lifting rw mount > logic into a single place. > > The first patch is a setup patch that unifies very similar logic between a > normal rw mount and a ro->rw remount. This is a useful setup step for adding > more functionality to ro->rw remounts. > > The second patch fixes the omission of orphan inode cleanup on a few trees > during ro->rw remount. > > The third patch adds enabling the free space tree to ro->rw remount. > > The fourth patch adds a method for clearing oneshot mount options after mount. > > The fifth patch adds support for clearing the free space tree on ro->rw remount. > > The sixth patch sets up for more accurate /proc/mounts by ensuring that > cache_generation > 0 iff space_cache is enabled. > > The seventh patch is the more accurate /proc/mounts logic. > > The eighth patch is a convenience kernel message that complains when we skip > changing the free space tree on remount. > > The ninth patch removes the space cache v1 free space item and free space > inodes when space cache v1 is disabled (nospace_cache or space_cache=v2). > > The tenth patch stops re-creating the free space objects when we are not > using space_cache=v1 > Looks good, you can add Reviewed-by: Josef Bacik <josef@toxicpanda.com> To the series, thanks, Josef
This patch set cleans up issues surrounding enabling and disabling various free space cache features and their reporting in /proc/mounts. Because the improvements became somewhat complex, the series starts by lifting rw mount logic into a single place. The first patch is a setup patch that unifies very similar logic between a normal rw mount and a ro->rw remount. This is a useful setup step for adding more functionality to ro->rw remounts. The second patch fixes the omission of orphan inode cleanup on a few trees during ro->rw remount. The third patch adds enabling the free space tree to ro->rw remount. The fourth patch adds a method for clearing oneshot mount options after mount. The fifth patch adds support for clearing the free space tree on ro->rw remount. The sixth patch sets up for more accurate /proc/mounts by ensuring that cache_generation > 0 iff space_cache is enabled. The seventh patch is the more accurate /proc/mounts logic. The eighth patch is a convenience kernel message that complains when we skip changing the free space tree on remount. The ninth patch removes the space cache v1 free space item and free space inodes when space cache v1 is disabled (nospace_cache or space_cache=v2). The tenth patch stops re-creating the free space objects when we are not using space_cache=v1 changes for v6: Rebase all patches on newer misc-next Patch 1/10: Fix unnecessary re-ordering of discard resume and most of mount_rw. Patch 2/10: No change. Patch 3/10: No change. Patch 4/10: Handle unclean rebase. Patch 5/10: No change. Patch 6/10: No change. Patch 7/10: No change. Patch 8/10: No change. Patch 9/10: No change. Patch 10/10: No change. changes for v5: Patch 1/10: No change. Patch 2/10: No change. Patch 3/10: No change. Patch 4/10: New. Patch 5/10: New. Patch 6/10: Handles remounts for no<->v1. Was Patch 4. Patch 7/10: No change. Was Patch 5 Patch 8/10: Warns/undoes flags on skipped clear as well as skipped create. Was Patch 6. Patch 9/10: No change. Was Patch 7. Patch 10/10: No change. Was Patch 8. changes for v4: Patch 1/8: New Patch 2/8: New Patch 3/8: (was Patch 1) Made much simpler by lifting of Patch 1. Simply add free space tree creation to lifted rw mount logic. Patch 4/8: Split out from old Patch 2. Add an fs_info flag to avoid surprises when a different transaction updates the cache_generation. Patch 5/8: Split out from old Patch 2, but no change logically. Patch 6/8: Split out from old Patch 1. Formatting fixes. Patch 7/8: (was Patch 3) Rely on delayed_iput running after orphan cleanup (setup in patch 2) to pull iputs out of mount path, per review. Patch 8/8: No change. changes for v3: Patch 1/4: Change failure to warning logging. Patch 2/4: New; fixes mount option printing. Patch 3/4: Fix orphan inode vs. delayed iput bug, change remove function to take inode as a sink. Patch 4/4: No changes. changes for v2: Patch 1/3: made remount _only_ work in ro->rw case, added comment. Patch 2/3: added btrfs_ prefix to non-static function, removed bad whitespace. Boris Burkov (10): btrfs: lift rw mount setup from mount and remount btrfs: cleanup all orphan inodes on ro->rw remount btrfs: create free space tree on ro->rw remount btrfs: clear oneshot options on mount and remount btrfs: clear free space tree on ro->rw remount btrfs: keep sb cache_generation consistent with space_cache btrfs: use sb state to print space_cache mount option btrfs: warn when remount will not change the free space tree btrfs: remove free space items when disabling space cache v1 btrfs: skip space_cache v1 setup when not using it fs/btrfs/block-group.c | 42 +------- fs/btrfs/ctree.h | 3 + fs/btrfs/disk-io.c | 195 +++++++++++++++++++++--------------- fs/btrfs/disk-io.h | 2 + fs/btrfs/free-space-cache.c | 121 ++++++++++++++++++++++ fs/btrfs/free-space-cache.h | 6 ++ fs/btrfs/super.c | 70 +++++++------ fs/btrfs/transaction.c | 2 + 8 files changed, 286 insertions(+), 155 deletions(-)