mbox series

[0/2] btrfs: fiemap fix and optimization

Message ID cover.1709202499.git.fdmanana@suse.com (mailing list archive)
Headers show
Series btrfs: fiemap fix and optimization | expand

Message

Filipe Manana Feb. 29, 2024, 11:56 a.m. UTC
From: Filipe Manana <fdmanana@suse.com>

One more fix for a regression introduced recently introduced to fiemap,
which can actually have serious consequences, as explained in the change
log of the first patch. The other is just a small optimization.
More details in the change logs.

Filipe Manana (2):
  btrfs: fix race when detecting delalloc ranges during fiemap
  btrfs: reuse cloned extent buffer during fiemap to avoid re-allocations

 fs/btrfs/extent_io.c | 253 +++++++++++++++++++++++++++++++------------
 1 file changed, 184 insertions(+), 69 deletions(-)

Comments

Josef Bacik March 1, 2024, 9:06 p.m. UTC | #1
On Thu, Feb 29, 2024 at 11:56:20AM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> One more fix for a regression introduced recently introduced to fiemap,
> which can actually have serious consequences, as explained in the change
> log of the first patch. The other is just a small optimization.
> More details in the change logs.
> 
> Filipe Manana (2):
>   btrfs: fix race when detecting delalloc ranges during fiemap
>   btrfs: reuse cloned extent buffer during fiemap to avoid re-allocations
> 
>  fs/btrfs/extent_io.c | 253 +++++++++++++++++++++++++++++++------------
>  1 file changed, 184 insertions(+), 69 deletions(-)
> 

Man I just made a whole mess of this whole thing.  I didn't take into account
the cloned leaf buffer thing.  I really hate our reliance on the extent lock to
protect so much vood here, but in the end I don't think there's much we can do
about it.

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef