| Message ID | cover.1710763611.git.fdmanana@suse.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | btrfs: remove a couple pointless callback wrappers | expand |
On 18.03.24 13:15, fdmanana@kernel.org wrote: > From: Filipe Manana <fdmanana@suse.com> > > Trivial stuff, details in the change logs. > > Filipe Manana (2): > btrfs: remove pointless readahead callback wrapper > btrfs: remove pointless writepages callback wrapper > > fs/btrfs/extent_io.c | 5 ++--- > fs/btrfs/extent_io.h | 5 ++--- > fs/btrfs/inode.c | 11 ----------- > 3 files changed, 4 insertions(+), 17 deletions(-) > Looks good, Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
On 3/18/24 17:44, fdmanana@kernel.org wrote: > From: Filipe Manana <fdmanana@suse.com> > > Trivial stuff, details in the change logs. > > Filipe Manana (2): > btrfs: remove pointless readahead callback wrapper > btrfs: remove pointless writepages callback wrapper Reviewed-by: Anand Jain <anand.jain@oracle.com> Thanks. > fs/btrfs/extent_io.c | 5 ++--- > fs/btrfs/extent_io.h | 5 ++--- > fs/btrfs/inode.c | 11 ----------- > 3 files changed, 4 insertions(+), 17 deletions(-) >
On Mon, Mar 18, 2024 at 12:14:54PM +0000, fdmanana@kernel.org wrote: > From: Filipe Manana <fdmanana@suse.com> > > Trivial stuff, details in the change logs. > > Filipe Manana (2): > btrfs: remove pointless readahead callback wrapper > btrfs: remove pointless writepages callback wrapper Reviewed-by: David Sterba <dsterba@suse.com>
在 2024/3/18 22:44, fdmanana@kernel.org 写道: > From: Filipe Manana <fdmanana@suse.com> > > Trivial stuff, details in the change logs. I guess it's just exposed by some random code reading? No automatic tools to expose such single line wrapper? > > Filipe Manana (2): > btrfs: remove pointless readahead callback wrapper > btrfs: remove pointless writepages callback wrapper Anyway looks good to me. Reviewed-by: Qu Wenruo <wqu@suse.com> Thanks, Qu > > fs/btrfs/extent_io.c | 5 ++--- > fs/btrfs/extent_io.h | 5 ++--- > fs/btrfs/inode.c | 11 ----------- > 3 files changed, 4 insertions(+), 17 deletions(-) >
On Mon, Mar 18, 2024 at 8:12 PM Qu Wenruo <quwenruo.btrfs@gmx.com> wrote: > > > > 在 2024/3/18 22:44, fdmanana@kernel.org 写道: > > From: Filipe Manana <fdmanana@suse.com> > > > > Trivial stuff, details in the change logs. > > I guess it's just exposed by some random code reading? Yes, by reading. > > No automatic tools to expose such single line wrapper? Not that I know of. Maybe some coccinelle script could do it, dunno. > > > > > Filipe Manana (2): > > btrfs: remove pointless readahead callback wrapper > > btrfs: remove pointless writepages callback wrapper > > Anyway looks good to me. > > Reviewed-by: Qu Wenruo <wqu@suse.com> > > Thanks, > Qu > > > > fs/btrfs/extent_io.c | 5 ++--- > > fs/btrfs/extent_io.h | 5 ++--- > > fs/btrfs/inode.c | 11 ----------- > > 3 files changed, 4 insertions(+), 17 deletions(-) > >
On Tue, Mar 19, 2024 at 06:42:26AM +1030, Qu Wenruo wrote: > > > 在 2024/3/18 22:44, fdmanana@kernel.org 写道: > > From: Filipe Manana <fdmanana@suse.com> > > > > Trivial stuff, details in the change logs. > > I guess it's just exposed by some random code reading? > > No automatic tools to expose such single line wrapper? --- dentifier FUNC, CALL; type TYPE; @@ TYPE FUNC(...) { * return CALL(...); } --- but not all trivial helpers should be removed, some of them have a semantic value or pair another fuction that is not trivial.
From: Filipe Manana <fdmanana@suse.com> Trivial stuff, details in the change logs. Filipe Manana (2): btrfs: remove pointless readahead callback wrapper btrfs: remove pointless writepages callback wrapper fs/btrfs/extent_io.c | 5 ++--- fs/btrfs/extent_io.h | 5 ++--- fs/btrfs/inode.c | 11 ----------- 3 files changed, 4 insertions(+), 17 deletions(-)