| Message ID | cover.1715783315.git.anand.jain@oracle.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | part3 trivial adjustments for return variable coding style | expand |
Any RB please? Thanks, Anand On 5/16/24 19:12, Anand Jain wrote: > This is part 3 of the series, containing renaming with optimization of the > return variable. > > Some of the patches are new it wasn't part of v1 or v2. The new patches follow > verb-first format for titles. Older patches not renamed for backward reference. > > Patchset passed tests -g quick without regressions, sending them first. > > Patch 3/6 and 4/6 can be merged; they are separated for easier diff. > > v2 part2: > https://lore.kernel.org/linux-btrfs/cover.1713370756.git.anand.jain@oracle.com/ > v1: > https://lore.kernel.org/linux-btrfs/cover.1710857863.git.anand.jain@oracle.com/ > > Anand Jain (6): > btrfs: btrfs_cleanup_fs_roots handle ret variable > btrfs: simplify ret in btrfs_recover_relocation > btrfs: rename ret in btrfs_recover_relocation > btrfs: rename err in btrfs_recover_relocation > btrfs: btrfs_drop_snapshot optimize return variable > btrfs: rename and optimize return variable in btrfs_find_orphan_roots > > fs/btrfs/disk-io.c | 38 ++++++++++++++-------------- > fs/btrfs/extent-tree.c | 48 ++++++++++++++++++------------------ > fs/btrfs/relocation.c | 56 +++++++++++++++++++----------------------- > fs/btrfs/root-tree.c | 32 ++++++++++++------------ > 4 files changed, 85 insertions(+), 89 deletions(-) >
On Thu, May 16, 2024 at 07:12:09PM +0800, Anand Jain wrote: > This is part 3 of the series, containing renaming with optimization of the > return variable. > > Some of the patches are new it wasn't part of v1 or v2. The new patches follow > verb-first format for titles. Older patches not renamed for backward reference. > > Patchset passed tests -g quick without regressions, sending them first. > > Patch 3/6 and 4/6 can be merged; they are separated for easier diff. Splitting the patches like might seem strange but reviewing the changes individually is indeed a bit easier so you can keep it like that. > v2 part2: > https://lore.kernel.org/linux-btrfs/cover.1713370756.git.anand.jain@oracle.com/ > v1: > https://lore.kernel.org/linux-btrfs/cover.1710857863.git.anand.jain@oracle.com/ > > Anand Jain (6): > btrfs: btrfs_cleanup_fs_roots handle ret variable > btrfs: simplify ret in btrfs_recover_relocation > btrfs: rename ret in btrfs_recover_relocation > btrfs: rename err in btrfs_recover_relocation > btrfs: btrfs_drop_snapshot optimize return variable > btrfs: rename and optimize return variable in btrfs_find_orphan_roots I've edited the subject lines from the previous series, please have a look and copy the subjects when the kind of change is the same in the patch. Also use the () when a function si mentioned in the subject. Thanks.
On 5/21/24 23:21, David Sterba wrote: > On Thu, May 16, 2024 at 07:12:09PM +0800, Anand Jain wrote: >> This is part 3 of the series, containing renaming with optimization of the >> return variable. >> >> Some of the patches are new it wasn't part of v1 or v2. The new patches follow >> verb-first format for titles. Older patches not renamed for backward reference. >> >> Patchset passed tests -g quick without regressions, sending them first. >> >> Patch 3/6 and 4/6 can be merged; they are separated for easier diff. > > Splitting the patches like might seem strange but reviewing the changes > individually is indeed a bit easier so you can keep it like that. > >> v2 part2: >> https://lore.kernel.org/linux-btrfs/cover.1713370756.git.anand.jain@oracle.com/ >> v1: >> https://lore.kernel.org/linux-btrfs/cover.1710857863.git.anand.jain@oracle.com/ >> >> Anand Jain (6): >> btrfs: btrfs_cleanup_fs_roots handle ret variable >> btrfs: simplify ret in btrfs_recover_relocation >> btrfs: rename ret in btrfs_recover_relocation >> btrfs: rename err in btrfs_recover_relocation >> btrfs: btrfs_drop_snapshot optimize return variable >> btrfs: rename and optimize return variable in btrfs_find_orphan_roots > > I've edited the subject lines from the previous series, please have a > look and copy the subjects when the kind of change is the same in the > patch. Also use the () when a function si mentioned in the subject. > Thanks. yep. I have updated the patch titles in v4. Thx. Anand