mbox series

[0/3] btrfs-progs: btrfstune --remove-simple-quota

Message ID cover.1720732480.git.boris@bur.io (mailing list archive)
Headers show
Series btrfs-progs: btrfstune --remove-simple-quota | expand

Message

Boris Burkov July 11, 2024, 9:18 p.m. UTC
To be able to nuke simple quotas entirely if you decide you don't want
them (and especially the OWNER_REFs) in your filesystem after all.

If you run
btrfstune --remove-simple-quota <dev>
on an unmounted filesystem, it will be as if simple quotas never existed
on that filesystem.

Boris Burkov (3):
  btrfs-progs: add a helper for clearing all the items in a tree
  btrfs-progs: btrfstune: fix documentation for --enable-simple-quota
  btrfs-progs: btrfstune: add ability to remove squotas

 kernel-shared/disk-io.c                       |  39 +++++
 kernel-shared/disk-io.h                       |   2 +
 kernel-shared/free-space-tree.c               |  42 +----
 .../065-btrfstune-simple-quota/test.sh        |  33 ++++
 tune/main.c                                   |  18 +-
 tune/quota.c                                  | 160 ++++++++++++++++++
 tune/tune.h                                   |   1 +
 7 files changed, 253 insertions(+), 42 deletions(-)
 create mode 100755 tests/misc-tests/065-btrfstune-simple-quota/test.sh

Comments

Anand Jain Jan. 4, 2025, 10:35 a.m. UTC | #1
btrfstune --help shows -q as the option to enable simple quota, which 
does not work.

David, has this set missed integration? OR Boris could push?

The whole series looks good to me.

Reviewed-by: Anand Jain <anand.jain@oracle.com>

Thx.


On 12/7/24 02:48, Boris Burkov wrote:
> To be able to nuke simple quotas entirely if you decide you don't want
> them (and especially the OWNER_REFs) in your filesystem after all.
> 
> If you run
> btrfstune --remove-simple-quota <dev>
> on an unmounted filesystem, it will be as if simple quotas never existed
> on that filesystem.
> 
> Boris Burkov (3):
>    btrfs-progs: add a helper for clearing all the items in a tree
>    btrfs-progs: btrfstune: fix documentation for --enable-simple-quota
>    btrfs-progs: btrfstune: add ability to remove squotas
> 
>   kernel-shared/disk-io.c                       |  39 +++++
>   kernel-shared/disk-io.h                       |   2 +
>   kernel-shared/free-space-tree.c               |  42 +----
>   .../065-btrfstune-simple-quota/test.sh        |  33 ++++
>   tune/main.c                                   |  18 +-
>   tune/quota.c                                  | 160 ++++++++++++++++++
>   tune/tune.h                                   |   1 +
>   7 files changed, 253 insertions(+), 42 deletions(-)
>   create mode 100755 tests/misc-tests/065-btrfstune-simple-quota/test.sh
>
Qu Wenruo Jan. 5, 2025, 11:17 p.m. UTC | #2
Sorry I forgot to merge them for so long..

Now merged into devel branch with all reviewed-by tags, and some small 
modifications:

- Put the doc fix first
- Add the missing man page entry for "--enable-simple-quota"
- Make remove_all_tree_items() to use btrfs_clear_tree() helper
- Add the missing man page entry for "--remove-simple-quota"

Thanks,
Qu

在 2025/1/4 21:05, Anand Jain 写道:
> 
> btrfstune --help shows -q as the option to enable simple quota, which 
> does not work.
> 
> David, has this set missed integration? OR Boris could push?
> 
> The whole series looks good to me.
> 
> Reviewed-by: Anand Jain <anand.jain@oracle.com>
> 
> Thx.
> 
> 
> On 12/7/24 02:48, Boris Burkov wrote:
>> To be able to nuke simple quotas entirely if you decide you don't want
>> them (and especially the OWNER_REFs) in your filesystem after all.
>>
>> If you run
>> btrfstune --remove-simple-quota <dev>
>> on an unmounted filesystem, it will be as if simple quotas never existed
>> on that filesystem.
>>
>> Boris Burkov (3):
>>    btrfs-progs: add a helper for clearing all the items in a tree
>>    btrfs-progs: btrfstune: fix documentation for --enable-simple-quota
>>    btrfs-progs: btrfstune: add ability to remove squotas
>>
>>   kernel-shared/disk-io.c                       |  39 +++++
>>   kernel-shared/disk-io.h                       |   2 +
>>   kernel-shared/free-space-tree.c               |  42 +----
>>   .../065-btrfstune-simple-quota/test.sh        |  33 ++++
>>   tune/main.c                                   |  18 +-
>>   tune/quota.c                                  | 160 ++++++++++++++++++
>>   tune/tune.h                                   |   1 +
>>   7 files changed, 253 insertions(+), 42 deletions(-)
>>   create mode 100755 tests/misc-tests/065-btrfstune-simple-quota/test.sh
>>
> 
>