| Message ID | cover.1740427964.git.fdmanana@suse.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | btrfs: some fixes around automatic block group reclaim | expand |
On Tue, 25 Feb 2025 at 11:58, <fdmanana@kernel.org> wrote: > > From: Filipe Manana <fdmanana@suse.com> > > Fix a couple races that should be mostly harmless but trigger KCSAN warnings > and fix the accounting of reclaimed bytes. More details in the change logs. > > Filipe Manana (3): > btrfs: get zone unusable bytes while holding lock at btrfs_reclaim_bgs_work() > btrfs: get used bytes while holding lock at btrfs_reclaim_bgs_work() > btrfs: fix reclaimed bytes accounting after automatic block group reclaim I'd say 2 and 3 would better be folded into one patch. The split is a bit confusing. > > fs/btrfs/block-group.c | 55 ++++++++++++++++++++++++++++++++---------- > 1 file changed, 42 insertions(+), 13 deletions(-) > > -- > 2.45.2 > >
On Tue, Feb 25, 2025 at 11:38 AM Daniel Vacek <neelx@suse.com> wrote: > > On Tue, 25 Feb 2025 at 11:58, <fdmanana@kernel.org> wrote: > > > > From: Filipe Manana <fdmanana@suse.com> > > > > Fix a couple races that should be mostly harmless but trigger KCSAN warnings > > and fix the accounting of reclaimed bytes. More details in the change logs. > > > > Filipe Manana (3): > > btrfs: get zone unusable bytes while holding lock at btrfs_reclaim_bgs_work() > > btrfs: get used bytes while holding lock at btrfs_reclaim_bgs_work() > > btrfs: fix reclaimed bytes accounting after automatic block group reclaim > > I'd say 2 and 3 would better be folded into one patch. The split is a > bit confusing. I find it less confusing, because it's 2 different problems being solved and easier to review and reason about. > > > > > fs/btrfs/block-group.c | 55 ++++++++++++++++++++++++++++++++---------- > > 1 file changed, 42 insertions(+), 13 deletions(-) > > > > -- > > 2.45.2 > > > >
On Tue, 25 Feb 2025 at 12:40, Filipe Manana <fdmanana@kernel.org> wrote: > > On Tue, Feb 25, 2025 at 11:38 AM Daniel Vacek <neelx@suse.com> wrote: > > > > On Tue, 25 Feb 2025 at 11:58, <fdmanana@kernel.org> wrote: > > > > > > From: Filipe Manana <fdmanana@suse.com> > > > > > > Fix a couple races that should be mostly harmless but trigger KCSAN warnings > > > and fix the accounting of reclaimed bytes. More details in the change logs. > > > > > > Filipe Manana (3): > > > btrfs: get zone unusable bytes while holding lock at btrfs_reclaim_bgs_work() > > > btrfs: get used bytes while holding lock at btrfs_reclaim_bgs_work() > > > btrfs: fix reclaimed bytes accounting after automatic block group reclaim > > > > I'd say 2 and 3 would better be folded into one patch. The split is a > > bit confusing. > > I find it less confusing, because it's 2 different problems being > solved and easier to review and reason about. OK > > > > > > > > fs/btrfs/block-group.c | 55 ++++++++++++++++++++++++++++++++---------- > > > 1 file changed, 42 insertions(+), 13 deletions(-) > > > > > > -- > > > 2.45.2 > > > > > >
On Tue, Feb 25, 2025 at 10:57:06AM +0000, fdmanana@kernel.org wrote: > From: Filipe Manana <fdmanana@suse.com> > > Fix a couple races that should be mostly harmless but trigger KCSAN warnings > and fix the accounting of reclaimed bytes. More details in the change logs. > > Filipe Manana (3): > btrfs: get zone unusable bytes while holding lock at btrfs_reclaim_bgs_work() > btrfs: get used bytes while holding lock at btrfs_reclaim_bgs_work() > btrfs: fix reclaimed bytes accounting after automatic block group reclaim Reviewed-by: David Sterba <dsterba@suse.com>
From: Filipe Manana <fdmanana@suse.com> Fix a couple races that should be mostly harmless but trigger KCSAN warnings and fix the accounting of reclaimed bytes. More details in the change logs. Filipe Manana (3): btrfs: get zone unusable bytes while holding lock at btrfs_reclaim_bgs_work() btrfs: get used bytes while holding lock at btrfs_reclaim_bgs_work() btrfs: fix reclaimed bytes accounting after automatic block group reclaim fs/btrfs/block-group.c | 55 ++++++++++++++++++++++++++++++++---------- 1 file changed, 42 insertions(+), 13 deletions(-)