diff mbox series

btrfs: remove no longer used btrfs_transaction_in_commit()

Message ID 00e9779bc56f516852e1488cc89403ca2d7d3a7c.1707838285.git.fdmanana@suse.com (mailing list archive)
State New, archived
Headers show
Series btrfs: remove no longer used btrfs_transaction_in_commit() | expand

Commit Message

Filipe Manana Feb. 13, 2024, 3:37 p.m. UTC 
From: Filipe Manana <fdmanana@suse.com>

The function btrfs_transaction_in_commit() is no longer used, its last
use was removed in commit 11aeb97b45ad ("btrfs: don't arbitrarily slow
down delalloc if we're committing"), so just remove it.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
 fs/btrfs/transaction.c | 13 -------------
 fs/btrfs/transaction.h |  1 -
 2 files changed, 14 deletions(-)

Comments

Anand Jain Feb. 13, 2024, 3:46 p.m. UTC | #1 
Reviewed-by: Anand Jain <anand.jain@oracle.com>
David Sterba Feb. 13, 2024, 7:54 p.m. UTC | #2 
On Tue, Feb 13, 2024 at 03:37:57PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> The function btrfs_transaction_in_commit() is no longer used, its last
> use was removed in commit 11aeb97b45ad ("btrfs: don't arbitrarily slow
> down delalloc if we're committing"), so just remove it.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: David Sterba <dsterba@suse.com>
Johannes Thumshirn Feb. 15, 2024, 11:38 a.m. UTC | #3 
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
diff mbox series

Patch

diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
index 3575b2bf3042..6c201bdbaac7 100644
--- a/fs/btrfs/transaction.c
+++ b/fs/btrfs/transaction.c
@@ -1957,19 +1957,6 @@  static void update_super_roots(struct btrfs_fs_info *fs_info)
 		super->uuid_tree_generation = root_item->generation;
 }
 
-int btrfs_transaction_in_commit(struct btrfs_fs_info *info)
-{
-	struct btrfs_transaction *trans;
-	int ret = 0;
-
-	spin_lock(&info->trans_lock);
-	trans = info->running_transaction;
-	if (trans)
-		ret = (trans->state >= TRANS_STATE_COMMIT_START);
-	spin_unlock(&info->trans_lock);
-	return ret;
-}
-
 int btrfs_transaction_blocked(struct btrfs_fs_info *info)
 {
 	struct btrfs_transaction *trans;
diff --git a/fs/btrfs/transaction.h b/fs/btrfs/transaction.h
index 681109c5f441..4e451ab173b1 100644
--- a/fs/btrfs/transaction.h
+++ b/fs/btrfs/transaction.h
@@ -277,7 +277,6 @@  int btrfs_write_marked_extents(struct btrfs_fs_info *fs_info,
 				struct extent_io_tree *dirty_pages, int mark);
 int btrfs_wait_tree_log_extents(struct btrfs_root *root, int mark);
 int btrfs_transaction_blocked(struct btrfs_fs_info *info);
-int btrfs_transaction_in_commit(struct btrfs_fs_info *info);
 void btrfs_put_transaction(struct btrfs_transaction *transaction);
 void btrfs_add_dropped_root(struct btrfs_trans_handle *trans,
 			    struct btrfs_root *root);