From patchwork Mon Oct 12 13:22:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhaolei X-Patchwork-Id: 7375111 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 8FEC89F750 for ; Mon, 12 Oct 2015 13:25:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CE8A5206BE for ; Mon, 12 Oct 2015 13:25:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 098AA206A4 for ; Mon, 12 Oct 2015 13:25:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752380AbbJLNYy (ORCPT ); Mon, 12 Oct 2015 09:24:54 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:19752 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752243AbbJLNYw (ORCPT ); Mon, 12 Oct 2015 09:24:52 -0400 X-IronPort-AV: E=Sophos;i="5.15,520,1432569600"; d="scan'208";a="101738556" Received: from unknown (HELO edo.cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 12 Oct 2015 21:27:14 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (localhost.localdomain [127.0.0.1]) by edo.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id t9CDOJt4026200 for ; Mon, 12 Oct 2015 21:24:19 +0800 Received: from localhost.localdomain (10.167.226.114) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server id 14.3.181.6; Mon, 12 Oct 2015 21:24:45 +0800 From: Zhao Lei To: CC: Zhao Lei Subject: [PATCH 05/11] btrfs-progs: inspect: set return value of error case Date: Mon, 12 Oct 2015 21:22:58 +0800 Message-ID: <089dd78bdaf8e25721ba718248a66b00e1b68284.1444655800.git.zhaolei@cn.fujitsu.com> X-Mailer: git-send-email 1.8.5.1 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In case of open_file_or_dir() failed, ret is not set to right value, and the function will return unwanted value(ret of sprintf). Signed-off-by: Zhao Lei --- cmds-inspect.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cmds-inspect.c b/cmds-inspect.c index 879fd43..a13a170 100644 --- a/cmds-inspect.c +++ b/cmds-inspect.c @@ -243,6 +243,7 @@ static int cmd_inspect_logical_resolve(int argc, char **argv) if (path_fd < 0) { fprintf(stderr, "ERROR: can't access " "'%s'\n", full_path); + ret = -ENOENT; goto out; } }