diff mbox

[3/4] Btrfs: clean up an error code in btrfs_init_space_info()

Message ID 0dc924c5f2a3c4d999e12feaccee5f970cea1315.1453199864.git.dsterba@suse.com (mailing list archive)
State Accepted
Headers show

Commit Message

David Sterba Jan. 19, 2016, 10:43 a.m. UTC 
From: Dan Carpenter <dan.carpenter@oracle.com>

If we return 1 here, then the caller treats it as an error and returns
-EINVAL.  It causes a static checker warning to treat positive returns
as an error.

Fixes: 1aba86d67f34 ('Btrfs: fix easily get into ENOSPC in mixed case')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---
 fs/btrfs/extent-tree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 8c912894a5bd..9d70330c6ebf 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -10509,7 +10509,7 @@  int btrfs_init_space_info(struct btrfs_fs_info *fs_info)
 
 	disk_super = fs_info->super_copy;
 	if (!btrfs_super_root(disk_super))
-		return 1;
+		return -EINVAL;
 
 	features = btrfs_super_incompat_flags(disk_super);
 	if (features & BTRFS_FEATURE_INCOMPAT_MIXED_GROUPS)