diff mbox series

btrfs-progs: fsfeatures: remove the EXPERIMENTAL flags for block group tree runtime feature

Message ID 11d75f3cce7b1f9f265e08580cca293984ad68d8.1676358661.git.wqu@suse.com (mailing list archive)
State New, archived
Headers show
Series btrfs-progs: fsfeatures: remove the EXPERIMENTAL flags for block group tree runtime feature | expand

Commit Message

Qu Wenruo Feb. 14, 2023, 7:11 a.m. UTC
This block group tree support is already in the v6.1 kernel, and I know
some adventurous users are already recompiling their progs to take
advantage of the new feature.

Especially the block group tree feature would reduce the mount time from
several minutes to several seconds for one of my friend.
(Of course, he is doing an offline convert using btrfstune)

I see now reason to hide this feature behind experimental flags.

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 common/fsfeatures.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Wang Yugui Feb. 14, 2023, 7:42 a.m. UTC | #1
Hi,

> This block group tree support is already in the v6.1 kernel, and I know
> some adventurous users are already recompiling their progs to take
> advantage of the new feature.
> 
> Especially the block group tree feature would reduce the mount time from
> several minutes to several seconds for one of my friend.
> (Of course, he is doing an offline convert using btrfstune)

Should we add support to btrfstune in this patch too?

Best Regards
Wang Yugui (wangyugui@e16-tech.com)
2023/02/14

> I see now reason to hide this feature behind experimental flags.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
>  common/fsfeatures.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/common/fsfeatures.c b/common/fsfeatures.c
> index 169e47e92582..ddd9c9419e84 100644
> --- a/common/fsfeatures.c
> +++ b/common/fsfeatures.c
> @@ -175,7 +175,6 @@ static const struct btrfs_feature mkfs_features[] = {
>  		.desc		= "support zoned devices"
>  	},
>  #endif
> -#if EXPERIMENTAL
>  	{
>  		.name		= "block-group-tree",
>  		.compat_ro_flag	= BTRFS_FEATURE_COMPAT_RO_BLOCK_GROUP_TREE,
> @@ -185,7 +184,6 @@ static const struct btrfs_feature mkfs_features[] = {
>  		VERSION_NULL(default),
>  		.desc		= "block group tree to reduce mount time"
>  	},
> -#endif
>  #if EXPERIMENTAL
>  	{
>  		.name		= "extent-tree-v2",
> @@ -228,7 +226,6 @@ static const struct btrfs_feature runtime_features[] = {
>  		VERSION_TO_STRING2(default, 5,15),
>  		.desc		= "free space tree (space_cache=v2)"
>  	},
> -#if EXPERIMENTAL
>  	{
>  		.name		= "block-group-tree",
>  		.compat_ro_flag	= BTRFS_FEATURE_COMPAT_RO_BLOCK_GROUP_TREE,
> @@ -238,7 +235,6 @@ static const struct btrfs_feature runtime_features[] = {
>  		VERSION_NULL(default),
>  		.desc		= "block group tree to reduce mount time"
>  	},
> -#endif
>  	/* Keep this one last */
>  	{
>  		.name		= "list-all",
> -- 
> 2.39.1
diff mbox series

Patch

diff --git a/common/fsfeatures.c b/common/fsfeatures.c
index 169e47e92582..ddd9c9419e84 100644
--- a/common/fsfeatures.c
+++ b/common/fsfeatures.c
@@ -175,7 +175,6 @@  static const struct btrfs_feature mkfs_features[] = {
 		.desc		= "support zoned devices"
 	},
 #endif
-#if EXPERIMENTAL
 	{
 		.name		= "block-group-tree",
 		.compat_ro_flag	= BTRFS_FEATURE_COMPAT_RO_BLOCK_GROUP_TREE,
@@ -185,7 +184,6 @@  static const struct btrfs_feature mkfs_features[] = {
 		VERSION_NULL(default),
 		.desc		= "block group tree to reduce mount time"
 	},
-#endif
 #if EXPERIMENTAL
 	{
 		.name		= "extent-tree-v2",
@@ -228,7 +226,6 @@  static const struct btrfs_feature runtime_features[] = {
 		VERSION_TO_STRING2(default, 5,15),
 		.desc		= "free space tree (space_cache=v2)"
 	},
-#if EXPERIMENTAL
 	{
 		.name		= "block-group-tree",
 		.compat_ro_flag	= BTRFS_FEATURE_COMPAT_RO_BLOCK_GROUP_TREE,
@@ -238,7 +235,6 @@  static const struct btrfs_feature runtime_features[] = {
 		VERSION_NULL(default),
 		.desc		= "block group tree to reduce mount time"
 	},
-#endif
 	/* Keep this one last */
 	{
 		.name		= "list-all",