From patchwork Fri Sep 28 03:02:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Dong X-Patchwork-Id: 1516521 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id F38F23FE1C for ; Fri, 28 Sep 2012 03:02:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756499Ab2I1DCw (ORCPT ); Thu, 27 Sep 2012 23:02:52 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:35711 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755482Ab2I1DCu (ORCPT ); Thu, 27 Sep 2012 23:02:50 -0400 Received: by pbbrr4 with SMTP id rr4so4493761pbb.19 for ; Thu, 27 Sep 2012 20:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=VLWNBpszvgPxQZOz2M8ycNQmQmX4Ds2QRp8aylDfbZk=; b=TqLQjvpIWq38zzZC1Hl7Sqfo29S8whh18MIsxmK/LSF2diNLVX3M0INezkUCfRnnER ZPd39nWbpJI+KWkG3Vxfp5tSPRNi+MFESSRVdidaNKmIeF0uvE53ta3e7CRGVKQbrsoQ PM4CLMPeg05QWwaSXhraobzy/0KgluCdnrkl2UVCOk1shnHfwDXR/ztJ7w/WRO0TLKSA I5AGGmTLclPU0IWJNrJFoFhBma5JIry7JkBvO46XRrhMLRA0VPyyHb7L59InRFlpbHox PK3HR51pp4hIrjwiXcReODfa18IbUvWC/ADjm+KJ03N1JvgFVMMj7/CJxpDxcfYUoXzM kfFQ== Received: by 10.68.134.99 with SMTP id pj3mr16557010pbb.13.1348801370071; Thu, 27 Sep 2012 20:02:50 -0700 (PDT) Received: from localhost.localdomain ([110.75.120.250]) by mx.google.com with ESMTPS id vl8sm4818130pbc.37.2012.09.27.20.02.48 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 27 Sep 2012 20:02:49 -0700 (PDT) From: Robin Dong To: linux-btrfs@vger.kernel.org Cc: Robin Dong Subject: [PATCH v2 2/2] btrfs-progs: limit the min value of total_bytes Date: Fri, 28 Sep 2012 11:02:40 +0800 Message-Id: <1348801360-1851-2-git-send-email-robin.k.dong@gmail.com> X-Mailer: git-send-email 1.7.3.2 In-Reply-To: <1348801360-1851-1-git-send-email-robin.k.dong@gmail.com> References: <1348801360-1851-1-git-send-email-robin.k.dong@gmail.com> Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org From: Robin Dong Using mkfs.btrfs like: mkfs.btrfs -b 1048576 /dev/sda will report error: mkfs.btrfs: volumes.c:796: btrfs_alloc_chunk: Assertion `!(ret)' failed. Aborted because the length of dev_extent is 4MB. But if we use mkfs.btrfs with 8MB total bytes, the newly mounted btrfs filesystem would not contain even one empty file. So 12MB will be good min-value for block_count. Signed-off-by: Robin Dong --- mkfs.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/mkfs.c b/mkfs.c index 8420482..496faa8 100644 --- a/mkfs.c +++ b/mkfs.c @@ -1345,7 +1345,11 @@ int main(int ac, char **av) &dev_block_count, &mixed, nodiscard); if (block_count == 0) block_count = dev_block_count; - else if (block_count > dev_block_count) { + else if (block_count < 3 * BTRFS_MKFS_SYSTEM_GROUP_SIZE) { + fprintf(stderr, "Illegal total number of bytes %u\n", + block_count); + exit(1); + } else if (block_count > dev_block_count) { fprintf(stderr, "%s is smaller than requested size\n", file); exit(1); }