From patchwork Mon Oct 8 08:10:41 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Dong X-Patchwork-Id: 1564241 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id AD01740276 for ; Mon, 8 Oct 2012 08:11:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754054Ab2JHILC (ORCPT ); Mon, 8 Oct 2012 04:11:02 -0400 Received: from mail-da0-f46.google.com ([209.85.210.46]:40606 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754036Ab2JHIKy (ORCPT ); Mon, 8 Oct 2012 04:10:54 -0400 Received: by mail-da0-f46.google.com with SMTP id n41so1433328dak.19 for ; Mon, 08 Oct 2012 01:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=i8JxJRe0oGoItN1JE4RpYkPnHqkyI2eYzU28mHBHRvI=; b=An7r17tTXLYrvpFhCbNgsnpxCOadlPatrCmVUzTHClhWKrwuvA1pyk82D/A03/Kmdq 558YSmFZWlA89DBEvagcwzeRbfdgxAU1RzZGMq7Rr4tHDxX/NfaGqTVPAUSecXR3Ln94 VJIJMr0DfsCGA3hPhXhqImHCRfds41JxHg+mOpGTf/EFqVkLhYbG+mGBGuEXiK2U/uab kSG6vdHe+JIuu336kFiVReb5gcpe5q3ohyHqD/L2YQEe7UM6cwva+Sm+9styyOgttspq LKDxOf4WLZD8rJOsI3sx3gzehNMgjbi47BV73h6Z571SQaVRI5cxXGRWoFOsOCGL7ufE puKg== Received: by 10.68.235.38 with SMTP id uj6mr50970575pbc.3.1349683853872; Mon, 08 Oct 2012 01:10:53 -0700 (PDT) Received: from localhost.localdomain ([110.75.120.247]) by mx.google.com with ESMTPS id kt2sm10352989pbc.73.2012.10.08.01.10.52 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 08 Oct 2012 01:10:53 -0700 (PDT) From: Robin Dong To: linux-btrfs@vger.kernel.org Cc: Robin Dong Subject: [PATCH v3 2/2] btrfs-progs: limit the min value of total_bytes Date: Mon, 8 Oct 2012 16:10:41 +0800 Message-Id: <1349683841-27981-2-git-send-email-robin.k.dong@gmail.com> X-Mailer: git-send-email 1.7.3.2 In-Reply-To: <1349683841-27981-1-git-send-email-robin.k.dong@gmail.com> References: <1349683841-27981-1-git-send-email-robin.k.dong@gmail.com> Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org From: Robin Dong Using mkfs.btrfs like: mkfs.btrfs -b 1048576 /dev/sda will report error: mkfs.btrfs: volumes.c:796: btrfs_alloc_chunk: Assertion `!(ret)' failed. Aborted because the length of dev_extent is 4MB. For the single/single case it's 5MB but for the dup/dup it's 156MB. It's due to the known bug in the blockgroup creation with multiple devices (applies on dup as well here) that leads to: # btrfs fi df . System, DUP: total=8.00MB, used=4.00KB System: total=4.00MB, used=0.00 Data+Metadata, DUP: total=64.00MB, used=24.00KB Data+Metadata: total=8.00MB, used=0.00 8*2 + 4 + 64*2 + 8 = 156 Signed-off-by: Robin Dong Reviewed-by: David Sterba --- mkfs.c | 7 ++++++- utils.h | 1 + 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/mkfs.c b/mkfs.c index 93672b9..982a113 100644 --- a/mkfs.c +++ b/mkfs.c @@ -1345,7 +1345,12 @@ int main(int ac, char **av) &dev_block_count, &mixed, nodiscard); if (block_count == 0) block_count = dev_block_count; - else if (block_count > dev_block_count) { + else if (block_count < BTRFS_MKFS_SYSTEM_MAX_SIZE) { + fprintf(stderr, "Illegal total number of bytes %u " + "(smaller than %u)\n", + block_count, BTRFS_MKFS_SYSTEM_MAX_SIZE); + exit(1); + } else if (block_count > dev_block_count) { fprintf(stderr, "%s is smaller than requested size\n", file); exit(1); } diff --git a/utils.h b/utils.h index c147c12..b63f69a 100644 --- a/utils.h +++ b/utils.h @@ -20,6 +20,7 @@ #define __UTILS__ #define BTRFS_MKFS_SYSTEM_GROUP_SIZE (4 * 1024 * 1024) +#define BTRFS_MKFS_SYSTEM_MAX_SIZE (156 * 1024 * 1024) int make_btrfs(int fd, const char *device, const char *label, u64 blocks[6], u64 num_bytes, u32 nodesize,