From patchwork Wed Feb 27 11:21:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Shilong X-Patchwork-Id: 2192921 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 2B3133FC8F for ; Wed, 27 Feb 2013 11:21:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932242Ab3B0LVq (ORCPT ); Wed, 27 Feb 2013 06:21:46 -0500 Received: from mail-da0-f52.google.com ([209.85.210.52]:36102 "EHLO mail-da0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758670Ab3B0LVp (ORCPT ); Wed, 27 Feb 2013 06:21:45 -0500 Received: by mail-da0-f52.google.com with SMTP id x33so253241dad.25 for ; Wed, 27 Feb 2013 03:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=uY6JJJHfH4qGSb/J4dh/SBhjh7vcDJyRny18tHEc2Ac=; b=aCJbUMwAyjrICq16Y/1N0ZcMVJUnfXx20zZykfFms2N8QmJ9Bh1/kVl3TRzBvVIf2D wALy5wNff03LDVDjJC9MmP9ASzGUbcVaXkD3hSO+VVBeAAq/3b9yF0h6k77UF05AErD7 uLl+eI0V2DRegogKRSFPdnr1A5nvc8YBASy6k0/oLCfYWQqxnFxCcqxXlI3mTmg7Q+sE b+rrgsYpgfDOAMabNrdDrmyW9hJtFZxAJgaGxct/bCGjFQXDXcsX+484c0A0rrtobJgI XUdeQx+oU4IbzPHe7p9L61zGAA5Iy9PhgZ+q7+H2vmOJHS+fu3jJPR63SVhlaVqAi+bq YFow== X-Received: by 10.68.24.33 with SMTP id r1mr2741578pbf.139.1361964105271; Wed, 27 Feb 2013 03:21:45 -0800 (PST) Received: from localhost.localdomain ([112.23.170.203]) by mx.google.com with ESMTPS id g4sm5068775pax.4.2013.02.27.03.21.43 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 27 Feb 2013 03:21:44 -0800 (PST) From: Wang Shilong To: linux-btrfs@vger.kernel.org Cc: wangshilong1991@gmail.com, miaox@cn.fujitsu.com, sensille@gmx.net Subject: [PATCH 3/3] Btrfs: remove reduplicate check about root in the function btrfs_clean_quota_tree Date: Wed, 27 Feb 2013 19:21:40 +0800 Message-Id: <1361964100-2503-1-git-send-email-wangshilong1991@gmail.com> X-Mailer: git-send-email 1.7.11.7 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org From: Wang Shilong The check work has been done just before the function btrfs_clean_quota_tree is called, it is not necessary to check it again, remove it. Signed-off-by: Wang Shilong --- fs/btrfs/qgroup.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c index 69fa487..aee4b1c 100644 --- a/fs/btrfs/qgroup.c +++ b/fs/btrfs/qgroup.c @@ -742,9 +742,6 @@ static int btrfs_clean_quota_tree(struct btrfs_trans_handle *trans, int ret; int nr = 0; - if (!root) - return -EINVAL; - path = btrfs_alloc_path(); if (!path) return -ENOMEM;