From patchwork Thu Mar 28 11:34:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Shilong X-Patchwork-Id: 2356111 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id BE10E3FDDA for ; Thu, 28 Mar 2013 11:35:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752747Ab3C1Let (ORCPT ); Thu, 28 Mar 2013 07:34:49 -0400 Received: from mail-pb0-f52.google.com ([209.85.160.52]:64513 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752589Ab3C1Les (ORCPT ); Thu, 28 Mar 2013 07:34:48 -0400 Received: by mail-pb0-f52.google.com with SMTP id ma3so5762237pbc.25 for ; Thu, 28 Mar 2013 04:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=X1LNPTwr4q4BO1kWHi9B+w+Jmn9FmFs1HuSm99B+m70=; b=Xi9SmhU/LU1s8uTSIj5mVeMOQyOhGfUU1eaJ5RmGr0QU/ivvy1VpxlNIFtFiV1atH7 jmhcNIV+kcGHN2QiSunV6RVblOKYG+uYQlpj4UODUsRQKJLdP5dmqbaY8kBMmq4twNkz ErSzZK4ImmkniiIc2IN7SykXmwkB9o4Ygyc1EQvk/mEUr+obhuzHxF9x9HYbmPnNTyQJ Vc1qx1peE3UJyd4qMqGvNEsxbepvuYUuEFIpqTZ5pTyEroFi8EdHvxoexLj5BdxLJydy 6QhOmoKILaNC3qIVMr0SQ7DeFHzQZMkshl0ODdYRtleJqFItie1mEaVjVBPi4DQmC/ug ff5w== X-Received: by 10.68.180.193 with SMTP id dq1mr35313056pbc.67.1364470488261; Thu, 28 Mar 2013 04:34:48 -0700 (PDT) Received: from localhost.localdomain.localdomain ([183.209.136.54]) by mx.google.com with ESMTPS id hs8sm25253492pbc.27.2013.03.28.04.34.44 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 28 Mar 2013 04:34:46 -0700 (PDT) From: Wang Shilong To: linux-btrfs@vger.kernel.org Cc: sensille@gmx.net, wangsl-fnst@cn.fujitsu.com, wangshilong1991@gmail.com Subject: [PATCH] Btrfs: fix a warning when disabling quota Date: Thu, 28 Mar 2013 19:34:41 +0800 Message-Id: <1364470481-1952-1-git-send-email-wangshilong1991@gmail.com> X-Mailer: git-send-email 1.7.11.7 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org From: Wang Shilong Steps to reproduce: mkfs.btrfs mount btrfs quota enable btrfs sub create /subv i=1 while [ $i -le 10000 ] do dd if=/dev/zero of=/subv/data_$i bs=1K count=1 i=$(($i+1)) if [ $i -eq 500 ] then btrfs quota disable $mnt fi done dmesg Obviously, this warn_on() is unnecessary, and it will be easily triggered. Just remove it. Signed-off-by: Wang Shilong --- fs/btrfs/qgroup.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c index 14fca77..0d37b1f 100644 --- a/fs/btrfs/qgroup.c +++ b/fs/btrfs/qgroup.c @@ -423,8 +423,6 @@ void btrfs_free_qgroup_config(struct btrfs_fs_info *fs_info) qgroup = rb_entry(n, struct btrfs_qgroup, node); rb_erase(n, &fs_info->qgroup_tree); - WARN_ON(!list_empty(&qgroup->dirty)); - while (!list_empty(&qgroup->groups)) { list = list_first_entry(&qgroup->groups, struct btrfs_qgroup_list,