From patchwork Fri Mar 29 13:05:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Shilong X-Patchwork-Id: 2365281 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id E5AF7DFB79 for ; Fri, 29 Mar 2013 13:05:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755097Ab3C2NFg (ORCPT ); Fri, 29 Mar 2013 09:05:36 -0400 Received: from mail-pb0-f52.google.com ([209.85.160.52]:65041 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754825Ab3C2NFg (ORCPT ); Fri, 29 Mar 2013 09:05:36 -0400 Received: by mail-pb0-f52.google.com with SMTP id ma3so254498pbc.25 for ; Fri, 29 Mar 2013 06:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:mime-version :content-type:content-transfer-encoding; bh=pfdXlKzXSu4rxWpT38iuzJqcwwU04e9t4pWy93BvqjY=; b=DHqs9Z5zxePC+G5lziwUxVYFMScIY/xEBYAqrr55dJRDMDrR0Zo90/7EeOPDtBPjaY wXJzUIa50g79e3I5NIyu85hN3IUEwF9VLXqbj//obFmCWIUiVLNjusI+O7ld8j4FlMad YiJU1yF+qvxobuv8OYsmdDYAYgNHjvLY+ybIWfIyWbNjLFu6Z/aU2yRJ0kftHBIZBORP TnZmPygSG7TfaWHfysXbtcll9YU6xT3JgdUdOk4RQsLaaXRdK1zl+ie0XeUBbSrz+jks p1zbvV3zpCpnA4CJyJFZ/1KGw69IO1jzpLqWVp6OEReAMQthni1LJArPF1BMbI6YWjmB LbEg== X-Received: by 10.66.146.232 with SMTP id tf8mr4418039pab.32.1364562335457; Fri, 29 Mar 2013 06:05:35 -0700 (PDT) Received: from localhost.localdomain.localdomain ([112.2.229.71]) by mx.google.com with ESMTPS id t5sm2818375pbi.10.2013.03.29.06.05.33 (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 29 Mar 2013 06:05:34 -0700 (PDT) From: Wang Shilong To: linux-btrfs@vger.kernel.org Cc: list.btrfs@jan-o-sch.net, wangsl-fnst@cn.fujitsu.com Subject: [PATCH] Btrfs: fix double free in the iterate_extent_inodes() Date: Fri, 29 Mar 2013 21:05:30 +0800 Message-Id: <1364562330-1606-1-git-send-email-wangshilong1991@gmail.com> X-Mailer: git-send-email 1.7.11.7 MIME-Version: 1.0 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org From: Wang Shilong If btrfs_find_all_roots() fails, 'roots' has been freed or 'roots' fails to allocate. we don't need to free it outside btrfs_find_all_roots() again.Fix it. Signed-off-by: Wang Shilong --- fs/btrfs/backref.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c index 5ff46ee..3ca413bb 100644 --- a/fs/btrfs/backref.c +++ b/fs/btrfs/backref.c @@ -1514,7 +1514,6 @@ int iterate_extent_inodes(struct btrfs_fs_info *fs_info, } free_leaf_list(refs); - ulist_free(roots); out: if (!search_commit_root) { btrfs_put_tree_mod_seq(fs_info, &tree_mod_seq_elem);