From patchwork Fri Mar 29 13:42:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Shilong X-Patchwork-Id: 2365391 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id ACAEADFB79 for ; Fri, 29 Mar 2013 13:42:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755437Ab3C2Nmm (ORCPT ); Fri, 29 Mar 2013 09:42:42 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:38306 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754585Ab3C2Nml (ORCPT ); Fri, 29 Mar 2013 09:42:41 -0400 Received: by mail-pd0-f179.google.com with SMTP id x11so264152pdj.10 for ; Fri, 29 Mar 2013 06:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:mime-version :content-type:content-transfer-encoding; bh=DP7U8yK5H/6vgbCiKp1hxUDrxU6IWV1XGrjXFmBqa2Y=; b=mfODt8Skqwh2IWd9VCHD8DZhLW2ePIf2UVE0H06OrMUwLLeNc3CLAYe/GaNOM9xe/r xZqVRU7fa+k+B1JcoLwoDvB4bXwIC6uG0TwpZNT4xgnqbBhjucDT3mOlmIOVhncwQQRn +EEX2AyNHFnGkupYQM1gNUX2M6zbBYCvONTPBRslAkuDl+yfK1SRZmu7bHL7oY98qxbB IlUsCB8ddUnbp3NF1U3kRQ/OryrWJRWs11Vcm8MltODa2Nm0ZoJiytpzae8fNyW/OsHt YlTDTs7W9q5Od1sZDdtwd2LDtn4gemngP2w0gCylRzin9Fhw9r62RTq6eSmkoUqeg4Ed bl7A== X-Received: by 10.66.242.73 with SMTP id wo9mr4535345pac.59.1364564561023; Fri, 29 Mar 2013 06:42:41 -0700 (PDT) Received: from localhost.localdomain.localdomain ([112.2.229.71]) by mx.google.com with ESMTPS id 4sm2899663pbn.23.2013.03.29.06.42.38 (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 29 Mar 2013 06:42:40 -0700 (PDT) From: Wang Shilong To: linux-btrfs@vger.kernel.org Cc: list.btrfs@jan-o-sch.net, wangsl-fnst@cn.fujitsu.com Subject: [PATCH] Btrfs: cleanup to remove reduplicate code in iterate_extent_inode() Date: Fri, 29 Mar 2013 21:42:34 +0800 Message-Id: <1364564554-1848-1-git-send-email-wangshilong1991@gmail.com> X-Mailer: git-send-email 1.7.11.7 MIME-Version: 1.0 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org From: Wang Shilong Just remove the unnecessary check and assignment. Signed-off-by: Wang Shilong --- fs/btrfs/backref.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c index 3ca413bb..e102b48 100644 --- a/fs/btrfs/backref.c +++ b/fs/btrfs/backref.c @@ -1499,7 +1499,7 @@ int iterate_extent_inodes(struct btrfs_fs_info *fs_info, if (ret) break; ULIST_ITER_INIT(&root_uiter); - while (!ret && (root_node = ulist_next(roots, &root_uiter))) { + while ((root_node = ulist_next(roots, &root_uiter))) { pr_debug("root %llu references leaf %llu, data list " "%#llx\n", root_node->val, ref_node->val, (long long)ref_node->aux); @@ -1510,7 +1510,6 @@ int iterate_extent_inodes(struct btrfs_fs_info *fs_info, iterate, ctx); } ulist_free(roots); - roots = NULL; } free_leaf_list(refs);