From patchwork Wed Apr 17 20:45:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Vincent_Stehl=C3=A9?= X-Patchwork-Id: 2456501 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 29D0C3FD8C for ; Wed, 17 Apr 2013 20:45:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965704Ab3DQUph (ORCPT ); Wed, 17 Apr 2013 16:45:37 -0400 Received: from smtp1-g21.free.fr ([212.27.42.1]:41464 "EHLO smtp1-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965067Ab3DQUpg (ORCPT ); Wed, 17 Apr 2013 16:45:36 -0400 Received: from romuald.bergerie (unknown [88.178.86.202]) by smtp1-g21.free.fr (Postfix) with ESMTP id 34EFC940184 for ; Wed, 17 Apr 2013 22:45:27 +0200 (CEST) Received: by romuald.bergerie (Postfix, from userid 65534) id 83D5B1C3E6; Wed, 17 Apr 2013 22:45:25 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on romuald.bergerie X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED, FH_FROMEML_NOTLD autolearn=no version=3.3.2 Received: from einstein.bergerie (localhost [IPv6:::1]) by romuald.bergerie (Postfix) with SMTP id 209551AF1A; Wed, 17 Apr 2013 22:45:20 +0200 (CEST) Received: by einstein.bergerie (sSMTP sendmail emulation); Wed, 17 Apr 2013 22:45:20 +0200 From: "Vincent" To: David Sterba Cc: =?UTF-8?q?Vincent=20Stehl=C3=A9?= , Chris Mason , linux-btrfs@vger.kernel.org Subject: [PATCH] Btrfs: fix reada debug code compilation Date: Wed, 17 Apr 2013 22:45:18 +0200 Message-Id: <1366231518-15243-1-git-send-email-vincent.stehle@laposte.net> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <20130416132834.GM18193@twin.jikos.cz> References: <20130416132834.GM18193@twin.jikos.cz> MIME-Version: 1.0 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org This fixes the following errors: fs/btrfs/reada.c: In function ‘btrfs_reada_wait’: fs/btrfs/reada.c:958:42: error: invalid operands to binary < (have ‘atomic_t’ and ‘int’) fs/btrfs/reada.c:961:41: error: invalid operands to binary < (have ‘atomic_t’ and ‘int’) Signed-off-by: Vincent Stehlé Reviewed-by: David Sterba Cc: Chris Mason Cc: linux-btrfs@vger.kernel.org --- Hi David, Thanks for your review; here is a resend with your 'Reviewed-by'. Best regards, V. fs/btrfs/reada.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/reada.c b/fs/btrfs/reada.c index 692185e..d1690c3 100644 --- a/fs/btrfs/reada.c +++ b/fs/btrfs/reada.c @@ -955,10 +955,11 @@ int btrfs_reada_wait(void *handle) while (atomic_read(&rc->elems)) { wait_event_timeout(rc->wait, atomic_read(&rc->elems) == 0, 5 * HZ); - dump_devs(rc->root->fs_info, rc->elems < 10 ? 1 : 0); + dump_devs(rc->root->fs_info, + atomic_read(&rc->elems) < 10 ? 1 : 0); } - dump_devs(rc->root->fs_info, rc->elems < 10 ? 1 : 0); + dump_devs(rc->root->fs_info, atomic_read(&rc->elems) < 10 ? 1 : 0); kref_put(&rc->refcnt, reada_control_release);