From patchwork Wed Sep 4 15:22:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Shilong X-Patchwork-Id: 2853746 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CEEA1C0AD3 for ; Wed, 4 Sep 2013 15:23:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B9C4A204CE for ; Wed, 4 Sep 2013 15:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93736204CB for ; Wed, 4 Sep 2013 15:22:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762873Ab3IDPWz (ORCPT ); Wed, 4 Sep 2013 11:22:55 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:37706 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756525Ab3IDPWy (ORCPT ); Wed, 4 Sep 2013 11:22:54 -0400 Received: by mail-pd0-f182.google.com with SMTP id r10so458895pdi.41 for ; Wed, 04 Sep 2013 08:22:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lpEDfTElYb9UlSyq/8MfS9TfLAmDZUJcGZrj3njnB5c=; b=oWlNYB9hX/7tA7O6PRFHuB9Gev8YoB5QRYapYnbquRNIFqfydgMzjGurCK9LXJxjNH QicQrXpOaDWrf51Blo3Br3gL7JsvYW9eVDkrXKdrjuax2Stovpuv2tNqOm4Jb8109mLJ wgd5SmUWmS/tQOs4tq8ML9TSHlm19cbCNaqcLuz0Rlw/jn6Pei7cD8aOwF9p0mXT8kaI 5xFviG4YvidzPjs8pDAp2RTUnY8Ze9gZzziU87V1iQZX38V9OCe6PQnCKgKaD882uDN3 2AQ1/FIiJOLcTvc+S0tbvXaafznwmPtVXzhElgEFC1UnjJcAAtm3XA8neLwNmE1caHy5 dM9Q== X-Received: by 10.68.170.227 with SMTP id ap3mr3796796pbc.162.1378308174190; Wed, 04 Sep 2013 08:22:54 -0700 (PDT) Received: from localhost.localdomain.localdomain ([223.65.191.73]) by mx.google.com with ESMTPSA id uw6sm29467271pbc.8.1969.12.31.16.00.00 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 04 Sep 2013 08:22:53 -0700 (PDT) From: Wang Shilong To: linux-btrfs@vger.kernel.org Cc: dsterba@suse.cz, sandeen@redhat.com Subject: [PATCH 04/20] Btrfs-progs: fix magic return value in cmds-dedup.c Date: Wed, 4 Sep 2013 23:22:21 +0800 Message-Id: <1378308157-4621-5-git-send-email-wangshilong1991@gmail.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1378308157-4621-1-git-send-email-wangshilong1991@gmail.com> References: <1378308157-4621-1-git-send-email-wangshilong1991@gmail.com> Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wang Shilong Signed-off-by: Wang Shilong --- cmds-dedup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cmds-dedup.c b/cmds-dedup.c index eb43414..674952a 100644 --- a/cmds-dedup.c +++ b/cmds-dedup.c @@ -39,7 +39,7 @@ int dedup_ctl(int cmd, int argc, char **argv) DIR *dirstream; if (check_argc_exact(argc, 2)) - return -1; + return -EINVAL; fd = open_file_or_dir(path, &dirstream); if (fd < 0) { @@ -71,7 +71,7 @@ static int cmd_dedup_enable(int argc, char **argv) int ret = dedup_ctl(BTRFS_DEDUP_CTL_REG, argc, argv); if (ret < 0) usage(cmd_dedup_enable_usage); - return ret; + return !!ret; } static const char * const cmd_dedup_disable_usage[] = { @@ -85,7 +85,7 @@ static int cmd_dedup_disable(int argc, char **argv) int ret = dedup_ctl(BTRFS_DEDUP_CTL_UNREG, argc, argv); if (ret < 0) usage(cmd_dedup_disable_usage); - return ret; + return !!ret; } const struct cmd_group dedup_cmd_group = {