From patchwork Tue Jan 28 01:40:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filipe Manana X-Patchwork-Id: 3544841 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 10E669F2E9 for ; Tue, 28 Jan 2014 01:41:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 03E6A2011E for ; Tue, 28 Jan 2014 01:41:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C380B200F0 for ; Tue, 28 Jan 2014 01:41:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428AbaA1BlG (ORCPT ); Mon, 27 Jan 2014 20:41:06 -0500 Received: from mail-wg0-f47.google.com ([74.125.82.47]:38970 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751425AbaA1BlE (ORCPT ); Mon, 27 Jan 2014 20:41:04 -0500 Received: by mail-wg0-f47.google.com with SMTP id m15so6557710wgh.2 for ; Mon, 27 Jan 2014 17:41:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=toc4gYQZcyXjRvOYr0DtKjJDL8Gq7WAbW6WRh+qbwvk=; b=Z9qsmNskBQJNA+lxo526tRYpgRRH54xM89ZXXR8YZusOgTpsX4RdYUaeaW5ES5qQv5 b3dT0IckknhA3wW/Ri0FbutKb5m+k1StQm/Y5UBuQqSTbTawcieHashHYcND7FX0uxDP DdDZlWFYWwbnHOOhfXeXO+1AkaCb62ZIwtMtBAa3R4sWUadnpa8rD9zhIQlyRxqw06oO UwU7zGeOElQWZYv4P7DWHB26kkzxN2pauThaWPpQcl6YI9lOx8lceRqJBrbGn7p98sXp 5ub95e79lTDpZT+7c4mgCcfUdEAbmhLgjraZdswLTS+XeGMZakCs4iF1QmOhnRq933Jq B6XQ== X-Received: by 10.180.82.193 with SMTP id k1mr2121273wiy.15.1390873263561; Mon, 27 Jan 2014 17:41:03 -0800 (PST) Received: from storm-desktop.lan (bl9-171-228.dsl.telepac.pt. [85.242.171.228]) by mx.google.com with ESMTPSA id fz5sm31676280wic.11.2014.01.27.17.40.58 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 27 Jan 2014 17:41:03 -0800 (PST) From: Filipe David Borba Manana To: xfs@oss.sgi.com Cc: linux-btrfs@vger.kernel.org, Filipe David Borba Manana Subject: [PATCH] xfstests: add test for btrfs incremental send data corruption Date: Tue, 28 Jan 2014 01:40:42 +0000 Message-Id: <1390873242-8723-1-git-send-email-fdmanana@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Btrfs incremental send had an issue where it would detect a non-existent file hole and then overwrite the file section that hole covers with zeroes, overriding file data that it shouldn't. The respective btrfs kernel patch that fixed this issue is titled: Btrfs: fix send file hole detection leading to data corruption (https://patchwork.kernel.org/patch/3544831/) Signed-off-by: Filipe David Borba Manana Reviewed-by: Josef Bacik --- tests/btrfs/034 | 101 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/034.out | 6 +++ tests/btrfs/group | 1 + 3 files changed, 108 insertions(+) create mode 100755 tests/btrfs/034 create mode 100644 tests/btrfs/034.out diff --git a/tests/btrfs/034 b/tests/btrfs/034 new file mode 100755 index 0000000..db792de --- /dev/null +++ b/tests/btrfs/034 @@ -0,0 +1,101 @@ +#! /bin/bash +# FS QA Test No. btrfs/034 +# +# Test for a btrfs incremental send data corruption issue due to +# bad detection of file holes. +# +#----------------------------------------------------------------------- +# Copyright (c) 2014 Filipe Manana. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +tmp=`mktemp -d` + +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + rm -fr $tmp +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs btrfs +_supported_os Linux +_require_scratch +_need_to_be_root + +rm -f $seqres.full + +_scratch_mkfs >/dev/null 2>&1 +_scratch_mount + +# Create a file such that its file extent items span at least 3 btree leafs. +# This is necessary to trigger a btrfs incremental send bug where file hole +# detection was not correct, leading to data corruption by overriding latest +# data regions of a file with zeroes. + +run_check $XFS_IO_PROG -f -c "truncate 104857600" $SCRATCH_MNT/foo + +for ((i = 0; i < 940; i++)) +do + OFFSET=$((32768 + i * 8192)) + LEN=$((OFFSET + 8192)) + run_check $XFS_IO_PROG -c "falloc -k $OFFSET $LEN" $SCRATCH_MNT/foo + run_check $XFS_IO_PROG -c "pwrite -S 0xf0 $OFFSET 4096" $SCRATCH_MNT/foo +done + +run_check $BTRFS_UTIL_PROG subvolume snapshot -r $SCRATCH_MNT \ + $SCRATCH_MNT/mysnap1 + +run_check $BTRFS_UTIL_PROG filesystem sync $SCRATCH_MNT +run_check $XFS_IO_PROG -c "truncate 3882008" $SCRATCH_MNT/foo + +run_check $BTRFS_UTIL_PROG subvolume snapshot -r $SCRATCH_MNT \ + $SCRATCH_MNT/mysnap2 + +run_check $BTRFS_UTIL_PROG send $SCRATCH_MNT/mysnap1 -f $tmp/1.snap +run_check $BTRFS_UTIL_PROG send -p $SCRATCH_MNT/mysnap1 $SCRATCH_MNT/mysnap2 \ + -f $tmp/2.snap + +md5sum $SCRATCH_MNT/foo | _filter_scratch +md5sum $SCRATCH_MNT/mysnap1/foo | _filter_scratch +md5sum $SCRATCH_MNT/mysnap2/foo | _filter_scratch + +_scratch_unmount +_check_btrfs_filesystem $SCRATCH_DEV +_scratch_mkfs >/dev/null 2>&1 +_scratch_mount + +run_check $BTRFS_UTIL_PROG receive $SCRATCH_MNT -f $tmp/1.snap +md5sum $SCRATCH_MNT/mysnap1/foo | _filter_scratch + +run_check $BTRFS_UTIL_PROG receive $SCRATCH_MNT -f $tmp/2.snap +md5sum $SCRATCH_MNT/mysnap2/foo | _filter_scratch + +_scratch_unmount +_check_btrfs_filesystem $SCRATCH_DEV + +status=0 +exit diff --git a/tests/btrfs/034.out b/tests/btrfs/034.out new file mode 100644 index 0000000..808e6b4 --- /dev/null +++ b/tests/btrfs/034.out @@ -0,0 +1,6 @@ +QA output created by 034 +9023ed93111c422d82e9cd54043a6fb0 SCRATCH_MNT/foo +8e58ce8749d203f29f6b8f6990da722f SCRATCH_MNT/mysnap1/foo +9023ed93111c422d82e9cd54043a6fb0 SCRATCH_MNT/mysnap2/foo +8e58ce8749d203f29f6b8f6990da722f SCRATCH_MNT/mysnap1/foo +9023ed93111c422d82e9cd54043a6fb0 SCRATCH_MNT/mysnap2/foo diff --git a/tests/btrfs/group b/tests/btrfs/group index 3f61799..b0a6b70 100644 --- a/tests/btrfs/group +++ b/tests/btrfs/group @@ -33,3 +33,4 @@ 028 auto quick 029 auto quick 030 auto quick +034 auto quick