diff mbox

btrfs-progs: fix build of static target

Message ID 1406121381-18611-1-git-send-email-dsterba@suse.cz (mailing list archive)
State Accepted
Headers show

Commit Message

David Sterba July 23, 2014, 1:16 p.m. UTC
A user repoted that static buid fails with

utils-lib.static.o: In function `arg_strtou64':
/home/dsterba/labs/btrfs-progs/utils-lib.c:17: multiple definition of `arg_strtou64'
utils-lib.static.o:/home/dsterba/labs/btrfs-progs/utils-lib.c:17: first defined here

utils-lib.o was mistakenly added to linker twice.

Signed-off-by: David Sterba <dsterba@suse.cz>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Satoru Takeuchi July 24, 2014, 3:22 a.m. UTC | #1
(2014/07/23 22:16), David Sterba wrote:
> A user repoted that static buid fails with
> 
> utils-lib.static.o: In function `arg_strtou64':
> /home/dsterba/labs/btrfs-progs/utils-lib.c:17: multiple definition of `arg_strtou64'
> utils-lib.static.o:/home/dsterba/labs/btrfs-progs/utils-lib.c:17: first defined here
> 
> utils-lib.o was mistakenly added to linker twice.
> 
> Signed-off-by: David Sterba <dsterba@suse.cz>

Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>

> ---
>   Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 8e14d4837520..3853b8734568 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -10,7 +10,7 @@ objects = ctree.o disk-io.o radix-tree.o extent-tree.o print-tree.o \
>   	  root-tree.o dir-item.o file-item.o inode-item.o inode-map.o \
>   	  extent-cache.o extent_io.o volumes.o utils.o repair.o \
>   	  qgroup.o raid6.o free-space-cache.o list_sort.o props.o \
> -	  utils-lib.o ulist.o qgroup-verify.o
> +	  ulist.o qgroup-verify.o
>   cmds_objects = cmds-subvolume.o cmds-filesystem.o cmds-device.o cmds-scrub.o \
>   	       cmds-inspect.o cmds-balance.o cmds-send.o cmds-receive.o \
>   	       cmds-quota.o cmds-qgroup.o cmds-replace.o cmds-check.o \
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 8e14d4837520..3853b8734568 100644
--- a/Makefile
+++ b/Makefile
@@ -10,7 +10,7 @@  objects = ctree.o disk-io.o radix-tree.o extent-tree.o print-tree.o \
 	  root-tree.o dir-item.o file-item.o inode-item.o inode-map.o \
 	  extent-cache.o extent_io.o volumes.o utils.o repair.o \
 	  qgroup.o raid6.o free-space-cache.o list_sort.o props.o \
-	  utils-lib.o ulist.o qgroup-verify.o
+	  ulist.o qgroup-verify.o
 cmds_objects = cmds-subvolume.o cmds-filesystem.o cmds-device.o cmds-scrub.o \
 	       cmds-inspect.o cmds-balance.o cmds-send.o cmds-receive.o \
 	       cmds-quota.o cmds-qgroup.o cmds-replace.o cmds-check.o \