diff mbox

Btrfs: properly clean up btrfs_end_io_wq_cache

Message ID 1413407999-1154-1-git-send-email-jbacik@fb.com (mailing list archive)
State Accepted
Headers show

Commit Message

Josef Bacik Oct. 15, 2014, 9:19 p.m. UTC
In one of Dave's cleanup commits he forgot to call btrfs_end_io_wq_exit on
unload, which makes us unable to unload and then re-load the btrfs module.  This
fixes the problem.  Thanks,

Signed-off-by: Josef Bacik <jbacik@fb.com>
---
 fs/btrfs/super.c | 1 +
 1 file changed, 1 insertion(+)

Comments

David Sterba Oct. 16, 2014, 9:18 a.m. UTC | #1
On Wed, Oct 15, 2014 at 05:19:59PM -0400, Josef Bacik wrote:
> In one of Dave's cleanup commits he forgot to call btrfs_end_io_wq_exit on
> unload, which makes us unable to unload and then re-load the btrfs module.  This
> fixes the problem.  Thanks,

Oh crap, sorry.

Reviewed-by: David Sterba <dsterba@suse.cz>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Miao Xie Oct. 23, 2014, 8:40 a.m. UTC | #2
On Wed, 15 Oct 2014 17:19:59 -0400, Josef Bacik wrote:
> In one of Dave's cleanup commits he forgot to call btrfs_end_io_wq_exit on
> unload, which makes us unable to unload and then re-load the btrfs module.  This
> fixes the problem.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@fb.com>

Reviewed-by: Miao Xie <miaox@cn.fujitsu.com>

> ---
>  fs/btrfs/super.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
> index b83ef15..c1d020f 100644
> --- a/fs/btrfs/super.c
> +++ b/fs/btrfs/super.c
> @@ -2151,6 +2151,7 @@ static void __exit exit_btrfs_fs(void)
>  	extent_map_exit();
>  	extent_io_exit();
>  	btrfs_interface_exit();
> +	btrfs_end_io_wq_exit();
>  	unregister_filesystem(&btrfs_fs_type);
>  	btrfs_exit_sysfs();
>  	btrfs_cleanup_fs_uuids();
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index b83ef15..c1d020f 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -2151,6 +2151,7 @@  static void __exit exit_btrfs_fs(void)
 	extent_map_exit();
 	extent_io_exit();
 	btrfs_interface_exit();
+	btrfs_end_io_wq_exit();
 	unregister_filesystem(&btrfs_fs_type);
 	btrfs_exit_sysfs();
 	btrfs_cleanup_fs_uuids();