| Message ID | 1426237126-9700-1-git-send-email-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote: > Building alpha:allmodconfig fails with > > fs/btrfs/inode.c: In function 'check_direct_IO': > fs/btrfs/inode.c:8050:2: error: implicit declaration of function 'iov_iter_alignment' > > due to a missing include file. > > Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h") > Cc: Christoph Hellwig <hch@lst.de> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- Forgot to mention: This is for -next. Guenter > fs/btrfs/inode.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c > index 37dc84c..5b6e5bd 100644 > --- a/fs/btrfs/inode.c > +++ b/fs/btrfs/inode.c > @@ -42,6 +42,7 @@ > #include <linux/btrfs.h> > #include <linux/blkdev.h> > #include <linux/posix_acl_xattr.h> > +#include <linux/uio.h> > #include "ctree.h" > #include "disk-io.h" > #include "transaction.h" > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote: > Building alpha:allmodconfig fails with > > fs/btrfs/inode.c: In function 'check_direct_IO': > fs/btrfs/inode.c:8050:2: error: implicit declaration of function 'iov_iter_alignment' > > due to a missing include file. > > Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h") > Cc: Christoph Hellwig <hch@lst.de> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> Acked-by: David Sterba <dsterba@suse.cz> Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote: > Building alpha:allmodconfig fails with > > fs/btrfs/inode.c: In function 'check_direct_IO': > fs/btrfs/inode.c:8050:2: error: implicit declaration of function 'iov_iter_alignment' > > due to a missing include file. > > Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h") > Cc: Christoph Hellwig <hch@lst.de> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- This problem still affects the following builds as of today. alpha:allmodconfig i386:allyesconfig i386:allmodconfig m68k:allmodconfig mips:allmodconfig xtensa:allmodconfig and thus probabably many other allmodconfig builds which I don't try to build. This is getting really annoying, and prevents us from finding and fixing other build problems. It has been more than two weeks since I submitted the patch. This suggests that the patch got lost otr that the Powers That Be don't care. Which one is it ? Should I request to revert 3737c63e1fb0 instead ? Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Mar 29, 2015 at 11:24 PM, Guenter Roeck <linux@roeck-us.net> wrote: > On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote: >> Building alpha:allmodconfig fails with >> >> fs/btrfs/inode.c: In function 'check_direct_IO': >> fs/btrfs/inode.c:8050:2: error: implicit declaration of function >> 'iov_iter_alignment' >> >> due to a missing include file. >> >> Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h") >> Cc: Christoph Hellwig <hch@lst.de> >> Signed-off-by: Guenter Roeck <linux@roeck-us.net> >> --- > > This problem still affects the following builds as of today. > > alpha:allmodconfig > i386:allyesconfig > i386:allmodconfig > m68k:allmodconfig > mips:allmodconfig > xtensa:allmodconfig > > and thus probabably many other allmodconfig builds which I don't try > to build. > > This is getting really annoying, and prevents us from finding and > fixing > other build problems. > > It has been more than two weeks since I submitted the patch. This > suggests > that the patch got lost otr that the Powers That Be don't care. Which > one > is it ? > > Should I request to revert 3737c63e1fb0 instead ? I'll put the include into my branch for -next, thanks! -chris -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/01/2015 12:28 PM, Chris Mason wrote: > On Sun, Mar 29, 2015 at 11:24 PM, Guenter Roeck <linux@roeck-us.net> wrote: >> On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote: >>> Building alpha:allmodconfig fails with >>> >>> fs/btrfs/inode.c: In function 'check_direct_Excellent idea. Done,IO': >>> fs/btrfs/inode.c:8050:2: error: implicit declaration of function 'iov_iter_alignment' >>> >>> due to a missing include file. >>> >>> Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h") >>> Cc: Christoph Hellwig <hch@lst.de> >>> Signed-off-by: Guenter Roeck <linux@roeck-us.net> >>> --- >> >> This problem still affects the following builds as of today. >> >> alpha:allmodconfig >> i386:allyesconfig >> i386:allmodconfig >> m68k:allmodconfig >> mips:allmodconfig >> xtensa:allmodconfig >> >> and thus probabably many other allmodconfig builds which I don't try to build. >> >> This is getting really annoying, and prevents us from finding and fixing >> other build problems. >> >> It has been more than two weeks since I submitted the patch. This suggests >> that the patch got lost otr that the Powers That Be don't care. Which one >> is it ? >> >> Should I request to revert 3737c63e1fb0 instead ? > > I'll put the include into my branch for -next, thanks! > I have not seen the problem in the latest -next build, which presumably means that some other patch must have fixed the problem or at least hides it now. No idea which one, though. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Apr 1, 2015 at 3:58 PM, Guenter Roeck <linux@roeck-us.net> wrote: > On 04/01/2015 12:28 PM, Chris Mason wrote: >> On Sun, Mar 29, 2015 at 11:24 PM, Guenter Roeck <linux@roeck-us.net> >> wrote: >>> On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote: >>>> Building alpha:allmodconfig fails with >>>> >>>> fs/btrfs/inode.c: In function 'check_direct_Excellent idea. >>>> Done,IO': >>>> fs/btrfs/inode.c:8050:2: error: implicit declaration of function >>>> 'iov_iter_alignment' >>>> >>>> due to a missing include file. >>>> >>>> Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h") >>>> Cc: Christoph Hellwig <hch@lst.de> >>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net> >>>> --- >>> >>> This problem still affects the following builds as of today. >>> >>> alpha:allmodconfig >>> i386:allyesconfig >>> i386:allmodconfig >>> m68k:allmodconfig >>> mips:allmodconfig >>> xtensa:allmodconfig >>> >>> and thus probabably many other allmodconfig builds which I don't >>> try to build. >>> >>> This is getting really annoying, and prevents us from finding and >>> fixing >>> other build problems. >>> >>> It has been more than two weeks since I submitted the patch. This >>> suggests >>> that the patch got lost otr that the Powers That Be don't care. >>> Which one >>> is it ? >>> >>> Should I request to revert 3737c63e1fb0 instead ? >> >> I'll put the include into my branch for -next, thanks! >> > > I have not seen the problem in the latest -next build, > which presumably means that some other patch must have > fixed the problem or at least hides it now. No idea > which one, though. It's not immediately obvious what might have fixed it, so I'll keep this patch in my -next for today at least ;) -chris -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 37dc84c..5b6e5bd 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -42,6 +42,7 @@ #include <linux/btrfs.h> #include <linux/blkdev.h> #include <linux/posix_acl_xattr.h> +#include <linux/uio.h> #include "ctree.h" #include "disk-io.h" #include "transaction.h"
Building alpha:allmodconfig fails with fs/btrfs/inode.c: In function 'check_direct_IO': fs/btrfs/inode.c:8050:2: error: implicit declaration of function 'iov_iter_alignment' due to a missing include file. Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h") Cc: Christoph Hellwig <hch@lst.de> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- fs/btrfs/inode.c | 1 + 1 file changed, 1 insertion(+)