From patchwork Thu Apr 30 09:59:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Jain X-Patchwork-Id: 6301101 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 86261BEEE1 for ; Thu, 30 Apr 2015 10:03:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B44B32015A for ; Thu, 30 Apr 2015 10:03:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C054F20107 for ; Thu, 30 Apr 2015 10:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750940AbbD3KDE (ORCPT ); Thu, 30 Apr 2015 06:03:04 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:20531 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751070AbbD3KC7 (ORCPT ); Thu, 30 Apr 2015 06:02:59 -0400 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t3UA2wNb007038 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 30 Apr 2015 10:02:58 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t3UA2v9D026944 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Thu, 30 Apr 2015 10:02:58 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t3UA2vOs004018; Thu, 30 Apr 2015 10:02:57 GMT Received: from OL.sg.oracle.com (/10.186.101.34) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 30 Apr 2015 03:02:56 -0700 From: Anand Jain To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org Subject: [PATCH] xfstests: btrfs: 020 is bit diverted from its objective Date: Thu, 30 Apr 2015 17:59:14 +0800 Message-Id: <1430387954-15682-1-git-send-email-anand.jain@oracle.com> X-Mailer: git-send-email 2.0.0.153.g79dcccc X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Not sure what this test case wanted to achieve by deleting the source device before the replace. As per the comments the objective of this test case seems to be ~~~~ btrfs device replace test on RO fs Regression test for commit: bbb651e Btrfs: don't allow the replace procedure on read only filesystems ~~~~~ Also there won't be EIO when you delete a loop device when its still mounted. as shown below. mount /dev/loop0 /mnt losetup -d /dev/loop0 echo $? 0 dd if=/dev/zero of=/mnt/tf1 count=1 1+0 records in 1+0 records out 512 bytes (512 B) copied, 0.00192936 s, 265 kB/s cd /mnt sync losetup -a /dev/loop0: [0802]:1291816 (/root/testdev/disk1) No errors in the dmesg as well. Instead of further confusing, I am deleting the delete loop device part Signed-off-by: Anand Jain Reviewed-by: Eryu Guan --- tests/btrfs/020 | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/btrfs/020 b/tests/btrfs/020 index 84251f3..3752dcf 100755 --- a/tests/btrfs/020 +++ b/tests/btrfs/020 @@ -76,8 +76,6 @@ loop_dev3=`_create_loop_device $fs_img3` _mkfs_dev -m raid1 -d raid1 $loop_dev1 $loop_dev2 >>$seqres.full 2>&1 _mount -o ro $loop_dev1 $loop_mnt -# Fail the second device and replace with the third -_destroy_loop_device $loop_dev2 $BTRFS_UTIL_PROG replace start -B 2 $loop_dev3 $loop_mnt >>$seqres.full 2>&1 && \ _fail "FAIL: Device replaced on RO btrfs"