| Message ID | 1466780914-23884-4-git-send-email-jeffm@suse.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Fri, Jun 24, 2016 at 11:08:34AM -0400, jeffm@suse.com wrote: > From: Jeff Mahoney <jeffm@suse.com> > > This tests the exporting of feature information from the kernel via > sysfs and ioctl. The first test works whether the sysfs permissions > are correct, if the information exported via sysfs matches > what the ioctls are reporting, and if they both match the on-disk > superblock's version of the feature sets. The second and third tests > test online setting and clearing of feature bits via the sysfs and > ioctl interfaces, checking whether they match the on-disk super on > each cycle. > > In every case, if the features are not present, it is not considered > a failure and a message indicating that will be dumped to the $num.full > file. > > Signed-off-by: Jeff Mahoney <jeffm@suse.com> > --- > tests/btrfs/126 | 269 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > tests/btrfs/126.out | 2 + > tests/btrfs/127 | 185 ++++++++++++++++++++++++++++++++++++ > tests/btrfs/127.out | 2 + > tests/btrfs/128 | 178 ++++++++++++++++++++++++++++++++++ > tests/btrfs/128.out | 2 + > tests/btrfs/group | 3 + > 7 files changed, 641 insertions(+) > create mode 100755 tests/btrfs/126 > create mode 100644 tests/btrfs/126.out > create mode 100755 tests/btrfs/127 > create mode 100644 tests/btrfs/127.out > create mode 100755 tests/btrfs/128 > create mode 100644 tests/btrfs/128.out > > diff --git a/tests/btrfs/126 b/tests/btrfs/126 > new file mode 100755 > index 0000000..3d660c5 > --- /dev/null > +++ b/tests/btrfs/126 > @@ -0,0 +1,269 @@ > +#!/bin/bash > +# FA QA Test No. 126 > +# > +# Test online feature publishing > +# > +# This test doesn't test the changing of features. It does test that > +# the proper publishing bits and permissions match up with > +# the expected values. > +# > +#----------------------------------------------------------------------- > +# Copyright (c) 2013 SUSE, All Rights Reserved. Copyright year 2016. > +# > +# This program is free software; you can redistribute it and/or > +# modify it under the terms of the GNU General Public License as > +# published by the Free Software Foundation. > +# > +# This program is distributed in the hope that it would be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program; if not, write the Free Software Foundation, > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > +#----------------------------------------------------------------------- > + > +seq=$(basename $0) > +seqres=$RESULT_DIR/$seq > +echo "== QA output created by $seq" > + > +here=$(pwd) > +tmp=/tmp/$$ > +status=1 Missing _cleanup() and trap, use './new btrfs' to create new btrfs tests. > + > +# get standard environment, filters and checks > +. ./common/rc > +. ./common/filter.btrfs > + > +_supported_fs btrfs > +_supported_os Linux > +_require_scratch > +_require_command $BTRFS_SHOW_SUPER_PROG _require_command "$BTRFS_SHOW_SUPER_PROG" btrfs-show-super > + > +_scratch_mkfs > /dev/null 2>&1 > +_scratch_mount > + > +check_features() { "{" on a seperate line > + reserved="$2" > + method="$3" > + if [ "$1" != 0 ]; then > + echo "$method: failed: $reserved" > + exit 1 > + fi No need to check return value. > + if [ "$reserved" = "Not implemented." ]; then > + echo "Skipping ioctl test. Not implemented." >> $seqres.full > + return > + fi Call _notrun if ioctl not implemented. Do the check before actual test starts. And you're mixing spaces and tabs for indention in this function. > +} > + > +error=false All the checks around error can be omitted. > + > +# test -w will always return true if root is making the call. > +# This would be true in most cases, but for sysfs files, the permissions > +# are enforced even for root. > +is_writeable() { "{" on a seperate line > + local file=$1 > + mode=$(stat -c "0%a" "$file") > + mode=$(( $mode & 0200 )) > + > + [ "$mode" -eq 0 ] && return 1 > + return 0 > +} > + > +# ioctl > +read -a features < <(src/btrfs_ioctl_helper $SCRATCH_MNT GET_FEATURES 2>&1) > +check_features $? "$features" "GET_FEATURES" > + > +test_ioctl=true > +[ "${features[*]}" = "Not implemented." ] && test_ioctl=false > + > +read -a supp_features < <(src/btrfs_ioctl_helper $SCRATCH_MNT GET_SUPPORTED_FEATURES 2>&1) > +check_features $? "$supp_features" "GET_SUPPORTED_FEATURES" > +[ "${supp_features[*]}" = "Not implemented." ] && test_ioctl=false These checks are not needed if the test was checked and _notrun properly before test. > + > +# Sysfs checks > +fsid=$(_btrfs_get_fsid $SCRATCH_DEV) > +sysfs_base="/sys/fs/btrfs" > + > +# TODO Add tool to enable and test unknown feature bits > +get_feature_mask() { > + class="" > + case "$attr" in > + mixed_backref) class=incompat; bit=0x1 ;; > + default_subvol) class=incompat; bit=0x2 ;; > + mixed_groups) class=incompat; bit=0x4 ;; > + compress_lzo) class=incompat; bit=0x8 ;; > + compress_lsov2) class=incompat; bit=0x10 ;; > + big_metadata) class=incompat; bit=0x20 ;; > + extended_iref) class=incompat; bit=0x40 ;; > + raid56) class=incompat; bit=0x80 ;; > + skinny_metadata)class=incompat; bit=0x100 ;; > + compat:*) class=compat; bit=${attr##compat:} ;; > + compat_ro:*) class=compat_ro; bit=${attr##compat_ro:} ;; > + incompat:*) class=incompat; bit=${attr##incompat:} ;; > + esac > + if [ -z "$class" ]; then > + echo "Unknown feature name $attr. xfstests needs updating." \ > + " Skipping the test of sysfs values to superblock values" \ > + >> $seqres.full Just echo this message to stdout and fail the test, so we know test needs update. > + return > + fi > + > + echo "$class $bit" > +} > + > +get_changeable_mask() { > + local class=$1 > + local index=0 > + if [ "$class" = "compat" ]; then > + index=0 > + elif [ "$class" = "compat_ro" ]; then > + index=1 > + elif [ "$class" = "incompat" ]; then > + index=2 > + fi > + local set_index=$(( $index + 3 )) > + local clear_index=$(( $index + 6 )) > + > + local mask=$(( ${supp_features[$set_index]} | \ > + ${supp_features[$clear_index]} )) > + > + echo $mask > +} This function needs comments to document it, and all the magic numbers (0 1 2 3 6). > + > +test_sysfs=false > +if [ -d "$sysfs_base/features" -a -d "$sysfs_base/$fsid/features" ]; then > + test_sysfs=true > +fi Call _notrun if there's no sysfs support. > + > +# Check enabled features in sysfs vs what the superblock claims > +sysfs_features=(0 0 0) > +for file in $sysfs_base/$fsid/features/*; do > + $test_sysfs || break > + attr=$(basename $file) > + val=$(cat $file) > + read class bit < <(get_feature_mask $attr) Avoid using "read" if possible, it's hiding error messages from get_feature_mask > + > + # A file that exists but has a 0 value means that it's changeable > + if [ "$val" -eq 0 ]; then > + if [ ! -e "$sysfs_base/features/$attr" ]; then > + echo "$fsid/$attr exists with a 0 value but" \ > + "features/$attr doesn't exist." > + error=true > + continue > + elif ! is_writeable "$file"; then > + echo "$attr is not writable but exists and has a" \ > + "0 value." > + error=true > + fi > + > + mask=$(get_changeable_mask $class) > + if [ "$(( $bit & ~$mask ))" -ne 0 ]; then > + echo "$attr is writable but GET_SUPPORTED_FEATURES" \ > + "ioctl claims it shouldn't be." > + error=true > + fi > + > + continue > + fi > + if [ "$class" = "compat" ]; then > + sysfs_features[0]=$(( ${sysfs_features[0]} | $bit )) > + elif [ "$class" = "compat_ro" ]; then > + sysfs_features[1]=$(( ${sysfs_features[1]} | $bit )) > + elif [ "$class" = "incompat" ]; then > + sysfs_features[2]=$(( ${sysfs_features[2]} | $bit )) > + else > + # We will end up with a bit set in the superblock that > + # doesn't have a matching bit here. The feature-bit to name > + # mapping must be kept up-to-date for this test to succeed. > + echo "Unknown feature name $attr. xfstests needs updating." \ > + "Skipping the test of sysfs values to superblock values" \ > + >> $seqres.full Again, echo this message to stdout. > + skip_sysfs_super_check=true Let it fail, don't skip > + fi > +done > + > +for file in $sysfs_base/features/*; do > + $test_sysfs || break > + attr=$(basename $file) > + val=$(cat $file) > + if [ "$val" -gt 0 ]; then > + if [ ! -e "$sysfs_base/$fsid/features/$attr" ]; then > + echo "features/$attr has a nonzero value ($val)" \ > + "but $fsid/features/$attr doesn't exist" > + error=true > + continue > + fi > + if ! is_writeable "$sysfs_base/$fsid/features/$attr"; then > + echo "features/$attr has a nonzero value ($val)" \ > + "but $fsid/features/$attr is not writable" > + error=true > + continue > + fi > + continue > + fi > + > + [ ! -e "$sysfs_base/$fsid/features/$attr" ] && continue > + > + if is_writeable "$sysfs_base/$fsid/features/$attr"; then > + echo "features/$attr has a zero value but" \ > + "$fsid/features/$attr is writable." > + error=true > + continue > + fi > + > + read class bit < <(get_feature_mask $attr) > + mask=$(get_changeable_mask $class) > + if [ "$(( $bit & $mask ))" -ne 0 ]; then > + echo "$attr isn't writable but GET_SUPPORTED_FEATURES" \ > + "ioctl claims it should be." > + error=true > + continue > + fi > +done > + > +umount $SCRATCH_MNT > /dev/null 2>&1 _scratch_unmount And btrfs/127,128 have almost the same set of issues, and I find them hard to review... Thanks, Eryu > + > +fields=("compat" "compat_ro" "incompat") > +declare -a disk_flags > + > +check_ioctl_flags() { > + local index=$1 > + local flags=${features[$index]} > + > + if [ "$flags" != "${disk_flags[$index]}" ]; then > + echo "ioctl returned different ${fields[$index]} flags" \ > + "($flags) than those contained in superblock" \ > + "(${disk_flags[$index]})" > + error=true > + fi > +} > + > +check_sysfs_flags() { > + local index=$1 > + $skip_sysfs_super_check || return > + > + flags=$(printf "0x%llx" ${sysfs_features[$index]}) > + if [ "$flags" != "${disk_flags[$index]}" ]; then > + echo "sysfs returned different ${fields[$index]}" \ > + "flags ($flags) than those contained in" \ > + "superblock (${disk_flags[$index]})" > + error=true > + fi > +} > + > + > +for index in $(seq 0 2); do > + class=${fields[$index]} > + disk_flags[$index]=$(_btrfs_get_feature_flags $SCRATCH_DEV $class) > + $test_ioctl && check_ioctl_flags "$index" > + $test_sysfs && check_sysfs_flags "$index" > +done > + > +$error && exit 1 > + > +# > +echo "Silence is golden" > +status=0 > +exit > diff --git a/tests/btrfs/126.out b/tests/btrfs/126.out > new file mode 100644 > index 0000000..fd12fb0 > --- /dev/null > +++ b/tests/btrfs/126.out > @@ -0,0 +1,2 @@ > +== QA output created by 126 > +Silence is golden > diff --git a/tests/btrfs/127 b/tests/btrfs/127 > new file mode 100755 > index 0000000..0a7eb91 > --- /dev/null > +++ b/tests/btrfs/127 > @@ -0,0 +1,185 @@ > +#!/bin/bash > +# FA QA Test No. 127 > +# > +# Test online feature changing via ioctl > +# > +#----------------------------------------------------------------------- > +# Copyright (c) 2013 SUSE, All Rights Reserved. > +# > +# This program is free software; you can redistribute it and/or > +# modify it under the terms of the GNU General Public License as > +# published by the Free Software Foundation. > +# > +# This program is distributed in the hope that it would be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program; if not, write the Free Software Foundation, > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > +#----------------------------------------------------------------------- > + > +seq=$(basename $0) > +seqres=$RESULT_DIR/$seq > +echo "== QA output created by $seq" > + > +here=$(pwd) > +tmp=/tmp/$$ > +status=1 > + > +# get standard environment, filters and checks > +. ./common/rc > +. ./common/filter.btrfs > + > +_supported_fs btrfs > +_supported_os Linux > +_require_scratch > +_require_command $BTRFS_SHOW_SUPER_PROG > + > +IOCTL=src/btrfs_ioctl_helper > + > +check_features() { > + reserved="$2" > + method="$3" > + if [ "$1" != 0 ]; then > + echo "$method: failed: $reserved" > + exit 1 > + fi > + if [ "$reserved" = "Not implemented." ]; then > + echo "Skipping ioctl $method test. Not implemented." \ > + >> $seqres.full > + echo "Silence is golden." > + exit 0 > + fi > +} > + > +# 3 values, one for each each of the fields > +update_features() { > + read -a features < <($IOCTL $SCRATCH_MNT GET_FEATURES 2>&1) > + check_features $? "${features[@]}" "GET_FEATURES" > +} > + > +set_feature() { > + local field=$1 > + local bits=$2 > + local class=${fields[$field]} > + local old=${features[$field]} > + msg=$($IOCTL $SCRATCH_MNT SET_FEATURES set $class $bits) > + check_features $? "$msg" "SET_FEATURES" > + update_features > + local new=${features[$field]} > + > + if [ "$old" = "$new" ]; then > + echo "Feature setting failed" > + exit 1 > + fi > + expected=$(( $old | $bits )) > + new=$(( $new )) > + if [ "$expected" -ne "$new" ]; then > + echo "Feature setting failed; Got $new, expected $expected" > + exit 1 > + fi > + echo $new > +} > + > +clear_feature() { > + local field=$1 > + local bits=$2 > + local class=${fields[$field]} > + local old=${features[$field]} > + msg=$($IOCTL $SCRATCH_MNT SET_FEATURES clear $class $bits) > + check_features $? "$msg" "SET_FEATURES" > + update_features > + local new="${features[$field]}" > + > + if [ "$old" = "$new" ]; then > + echo "Feature clearing failed" > + exit 1 > + fi > + expected=$(( $old & ~$bits )) > + new=$(( $new )) > + if [ "$expected" -ne "$new" ]; then > + echo "Feature clearing failed; Got $new, expected $expected" > + exit 1 > + fi > +} > + > +check_flags() { > + local index=$1 > + local expected=$(( $2 )) > + local class=${fields[$index]} > + disk_flags="$(( $(_btrfs_get_feature_flags $SCRATCH_DEV $class) ))" > + if [ "$disk_flags" -ne "$expected" ]; then > + echo "mismatch: $disk_flags-$expected" > + error=true > + fi > +} > + > +error=false > +fields=("compat" "compat_ro" "incompat") > + > +_scratch_mkfs > /dev/null 2>&1 > +_scratch_mount > + > +update_features > + > +# 9 values; 3 each for supported, settable, and clearable > +read -a supp_features < <($IOCTL $SCRATCH_MNT GET_SUPPORTED_FEATURES 2>&1) > +check_features $? "$supp_features" "GET_SUPPORTED_FEATURES" > + > +# Cycle through settable features. > +# Set the feature > +# Reload ioctl version and test against expected new value > +# Unmount and test against expected new value > +# Reount > +settable() { > + echo "${supp_features[$(( $1 + 3 ))]}" > +} > +did_set=false > +for field in $(seq 0 2); do > + fset="$(settable $field)" > + [ -z "$fset" ] && break > + for n in $(seq 0 63); do > + old="${features[$field]}" > + v="$(( $fset & (1 << $n) ))" > + [ "$v" -eq 0 ] && continue > + new="$(set_feature $field $v)" > + umount $SCRATCH_MNT > /dev/null 2>&1 > + expected="$(( $old | $v ))" > + check_flags "$field" "$expected" > + _scratch_mount > + did_set=true > + done > +done > +$did_set || echo "No online-settable features to test." >> $seqres.full > + > +# Repeat with clearing features > +clearable() { > + echo "${supp_features[$(( $1 + 6 ))]}" > +} > +did_clear=false > +for field in $(seq 0 2); do > + fclear="$(clearable $field)" > + [ -z "$fclear" ] && break > + for n in $(seq 0 63); do > + v="$(( $fclear & (1 << $n) ))" > + [ "$v" -eq 0 ] && continue > + > + new="$(clear_feature $field $v)" > + umount $SCRATCH_MNT > /dev/null 2>&1 > + expected=$(( $old &~ $v )) > + check_flags $field $expected > + _scratch_mount > + did_clear=true > + done > +done > +$did_clear || echo "No online-clearable features to test." >> $seqres.full > + > +umount $SCRATCH_MNT > /dev/null 2>&1 > + > +$error && exit 1 > + > +echo "Silence is golden" > +status=0 > +exit > diff --git a/tests/btrfs/127.out b/tests/btrfs/127.out > new file mode 100644 > index 0000000..2ff4733 > --- /dev/null > +++ b/tests/btrfs/127.out > @@ -0,0 +1,2 @@ > +== QA output created by 127 > +Silence is golden > diff --git a/tests/btrfs/128 b/tests/btrfs/128 > new file mode 100755 > index 0000000..7de780a > --- /dev/null > +++ b/tests/btrfs/128 > @@ -0,0 +1,178 @@ > +#!/bin/bash > +# FA QA Test No. 128 > +# > +# Test online feature changing via sysfs > +# > +#----------------------------------------------------------------------- > +# Copyright (c) 2013 SUSE, All Rights Reserved. > +# > +# This program is free software; you can redistribute it and/or > +# modify it under the terms of the GNU General Public License as > +# published by the Free Software Foundation. > +# > +# This program is distributed in the hope that it would be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program; if not, write the Free Software Foundation, > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > +#----------------------------------------------------------------------- > + > +seq=$(basename $0) > +seqres=$RESULT_DIR/$seq > +echo "== QA output created by $seq" > + > +here=$(pwd) > +tmp=/tmp/$$ > +status=1 > + > +# get standard environment, filters and checks > +. ./common/rc > +. ./common/filter.btrfs > + > +_supported_fs btrfs > +_supported_os Linux > +_require_scratch > +_require_command $BTRFS_SHOW_SUPER_PROG > + > +IOCTL=src/btrfs_ioctl_helper > + > +check_flags() { > + local class=$1 > + local expected=$2 > + disk_flags="$(_btrfs_get_feature_flags $SCRATCH_DEV $class)" > + disk_flags=$(printf 0x%llx $disk_flags) > + expected=$(printf 0x%llx $expected) > + if [ "$disk_flags" != "$expected" ]; then > + echo "mismatch: $disk_flags-$expected" > + error=true > + fi > +} > + > +get_feature_mask() { > + local attr=$1 > + local class="" > + local bit= > + case "$attr" in > + mixed_backref) class=incompat bit=0x1 ;; > + default_subvol) class=incompat bit=0x2 ;; > + mixed_groups) class=incompat bit=0x4 ;; > + compress_lzo) class=incompat bit=0x8 ;; > + compress_lsov2) class=incompat bit=0x10 ;; > + big_metadata) class=incompat bit=0x20 ;; > + extended_iref) class=incompat bit=0x40 ;; > + raid56) class=incompat bit=0x80 ;; > + skinny_metadata)class=incompat bit=0x100 ;; > + compat:*) class=compat; bit=${attr##compat:} ;; > + compat_ro:*) class=compat_ro; bit=${attr##compat_ro:} ;; > + incompat:*) class=incompat; bit=${attr##incompat:} ;; > + esac > + if [ -z "$class" ]; then > + echo "Unknown feature name $attr. xfstests needs updating." \ > + " Skipping the test of sysfs values to superblock values" \ > + >> $seqres.full > + return > + fi > + echo "$class $bit" > +} > + > + > +_scratch_mkfs > /dev/null 2>&1 > +error=false > +fields=("compat" "compat_ro" "incompat") > +sysfs_base="/sys/fs/btrfs" > +settable="" > +clearable="" > + > +if [ ! -d "$sysfs_base/features" ]; then > + echo "Silence is golden" > + echo "This kernel does not export $sysfs_base/features." \ > + "Nothing to test." >> $seqres.full > + exit 0 > +fi > + > +# Gather up the features the kernel knows about > +_scratch_mount > +for feature in $sysfs_base/features/*; do > + val=$(cat $feature) > + fname=$(basename $feature) > + if [ "$(( $val & 0x1 ))" -eq 1 ]; then > + settable="$settable $fname" > + fi > + if [ "$(( $val & 0x2 ))" -eq 2 ]; then > + clearable="$clearable $fname" > + fi > +done > +umount $SCRATCH_MNT > /dev/null 2>&1 > + > +# Set/clear tests do their own mount cycling > +sysfs_fs_base="$sysfs_base/$(_btrfs_get_fsid $SCRATCH_DEV)" > + > +if [ ! -d "$sysfs_fs_base/features" ]; then > + echo "Silence is golden" > + echo "This kernel does not export $sysfs_fs_base/features." \ > + "Nothing to test." >> $seqres.full > + exit 0 > +fi > + > +did_set=false > +for feature in $settable; do > + read class bit < <(get_feature_mask $feature) > + [ -z "$class" ] && continue > + flags=$(_btrfs_get_feature_flags $SCRATCH_DEV $class) > + _scratch_mount > + val=$(cat $sysfs_fs_base/features/$feature) > + [ "$val" -ne 0 ] && continue > + echo 1 > $sysfs_fs_base/features/$feature > + if [ $? -ne 0 ] ; then > + echo "Error while setting $feature - $st" > + error=true > + umount $SCRATCH_MNT > /dev/null 2>&1 > + continue > + fi > + newval=$(cat $sysfs_fs_base/features/$feature) > + if [ "$newval" -ne 1 ]; then > + echo "Setting feature $feature was ignored." > + error=true > + fi > + umount $SCRATCH_MNT > /dev/null 2>&1 > + check_flags $class $(( $flags | $bit )) > + did_set=true > +done > +$did_set || echo "No online-settable features to test." >> $seqres.full > + > +did_clear=false > +for feature in $clearable; do > + read class bit < <(get_feature_mask $feature) > + [ -z "$class" ] && continue > + flags=$(_btrfs_get_feature_flags $SCRATCH_DEV $class) > + _scratch_mount > + val=$(cat $sysfs_fs_base/features/$feature) > + [ "$val" -ne 1 ] && continue > + echo 0 > $sysfs_fs_base/features/$feature > + if [ $? -ne 0 ] ; then > + echo "Error while clearing $feature - $st" > + error=true > + umount $SCRATCH_MNT > /dev/null 2>&1 > + continue > + fi > + newval=$(cat $sysfs_fs_base/features/$feature) > + if [ "$newval" -ne 0 ]; then > + echo "Clearing feature $feature was ignored." > + error=true > + fi > + umount $SCRATCH_MNT > /dev/null 2>&1 > + check_flags $class $(( $flags & ~$bit )) > + did_clear=true > +done > +$did_clear || echo "No online-clearable features to test." >> $seqres.full > + > +# Still umounted from set/clear tests > + > +$error && exit 1 > + > +echo "Silence is golden" > +status=0 > +exit > diff --git a/tests/btrfs/128.out b/tests/btrfs/128.out > new file mode 100644 > index 0000000..1b86f92 > --- /dev/null > +++ b/tests/btrfs/128.out > @@ -0,0 +1,2 @@ > +== QA output created by 128 > +Silence is golden > diff --git a/tests/btrfs/group b/tests/btrfs/group > index 3535f02..e76265d 100644 > --- a/tests/btrfs/group > +++ b/tests/btrfs/group > @@ -128,3 +128,6 @@ > 123 auto quick qgroup > 124 auto quick metadata > 125 auto quick metadata > +126 auto quick metadata > +127 auto quick metadata > +128 auto quick metadata > -- > 1.8.5.6 > > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tests/btrfs/126 b/tests/btrfs/126 new file mode 100755 index 0000000..3d660c5 --- /dev/null +++ b/tests/btrfs/126 @@ -0,0 +1,269 @@ +#!/bin/bash +# FA QA Test No. 126 +# +# Test online feature publishing +# +# This test doesn't test the changing of features. It does test that +# the proper publishing bits and permissions match up with +# the expected values. +# +#----------------------------------------------------------------------- +# Copyright (c) 2013 SUSE, All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- + +seq=$(basename $0) +seqres=$RESULT_DIR/$seq +echo "== QA output created by $seq" + +here=$(pwd) +tmp=/tmp/$$ +status=1 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter.btrfs + +_supported_fs btrfs +_supported_os Linux +_require_scratch +_require_command $BTRFS_SHOW_SUPER_PROG + +_scratch_mkfs > /dev/null 2>&1 +_scratch_mount + +check_features() { + reserved="$2" + method="$3" + if [ "$1" != 0 ]; then + echo "$method: failed: $reserved" + exit 1 + fi + if [ "$reserved" = "Not implemented." ]; then + echo "Skipping ioctl test. Not implemented." >> $seqres.full + return + fi +} + +error=false + +# test -w will always return true if root is making the call. +# This would be true in most cases, but for sysfs files, the permissions +# are enforced even for root. +is_writeable() { + local file=$1 + mode=$(stat -c "0%a" "$file") + mode=$(( $mode & 0200 )) + + [ "$mode" -eq 0 ] && return 1 + return 0 +} + +# ioctl +read -a features < <(src/btrfs_ioctl_helper $SCRATCH_MNT GET_FEATURES 2>&1) +check_features $? "$features" "GET_FEATURES" + +test_ioctl=true +[ "${features[*]}" = "Not implemented." ] && test_ioctl=false + +read -a supp_features < <(src/btrfs_ioctl_helper $SCRATCH_MNT GET_SUPPORTED_FEATURES 2>&1) +check_features $? "$supp_features" "GET_SUPPORTED_FEATURES" +[ "${supp_features[*]}" = "Not implemented." ] && test_ioctl=false + +# Sysfs checks +fsid=$(_btrfs_get_fsid $SCRATCH_DEV) +sysfs_base="/sys/fs/btrfs" + +# TODO Add tool to enable and test unknown feature bits +get_feature_mask() { + class="" + case "$attr" in + mixed_backref) class=incompat; bit=0x1 ;; + default_subvol) class=incompat; bit=0x2 ;; + mixed_groups) class=incompat; bit=0x4 ;; + compress_lzo) class=incompat; bit=0x8 ;; + compress_lsov2) class=incompat; bit=0x10 ;; + big_metadata) class=incompat; bit=0x20 ;; + extended_iref) class=incompat; bit=0x40 ;; + raid56) class=incompat; bit=0x80 ;; + skinny_metadata)class=incompat; bit=0x100 ;; + compat:*) class=compat; bit=${attr##compat:} ;; + compat_ro:*) class=compat_ro; bit=${attr##compat_ro:} ;; + incompat:*) class=incompat; bit=${attr##incompat:} ;; + esac + if [ -z "$class" ]; then + echo "Unknown feature name $attr. xfstests needs updating." \ + " Skipping the test of sysfs values to superblock values" \ + >> $seqres.full + return + fi + + echo "$class $bit" +} + +get_changeable_mask() { + local class=$1 + local index=0 + if [ "$class" = "compat" ]; then + index=0 + elif [ "$class" = "compat_ro" ]; then + index=1 + elif [ "$class" = "incompat" ]; then + index=2 + fi + local set_index=$(( $index + 3 )) + local clear_index=$(( $index + 6 )) + + local mask=$(( ${supp_features[$set_index]} | \ + ${supp_features[$clear_index]} )) + + echo $mask +} + +test_sysfs=false +if [ -d "$sysfs_base/features" -a -d "$sysfs_base/$fsid/features" ]; then + test_sysfs=true +fi + +# Check enabled features in sysfs vs what the superblock claims +sysfs_features=(0 0 0) +for file in $sysfs_base/$fsid/features/*; do + $test_sysfs || break + attr=$(basename $file) + val=$(cat $file) + read class bit < <(get_feature_mask $attr) + + # A file that exists but has a 0 value means that it's changeable + if [ "$val" -eq 0 ]; then + if [ ! -e "$sysfs_base/features/$attr" ]; then + echo "$fsid/$attr exists with a 0 value but" \ + "features/$attr doesn't exist." + error=true + continue + elif ! is_writeable "$file"; then + echo "$attr is not writable but exists and has a" \ + "0 value." + error=true + fi + + mask=$(get_changeable_mask $class) + if [ "$(( $bit & ~$mask ))" -ne 0 ]; then + echo "$attr is writable but GET_SUPPORTED_FEATURES" \ + "ioctl claims it shouldn't be." + error=true + fi + + continue + fi + if [ "$class" = "compat" ]; then + sysfs_features[0]=$(( ${sysfs_features[0]} | $bit )) + elif [ "$class" = "compat_ro" ]; then + sysfs_features[1]=$(( ${sysfs_features[1]} | $bit )) + elif [ "$class" = "incompat" ]; then + sysfs_features[2]=$(( ${sysfs_features[2]} | $bit )) + else + # We will end up with a bit set in the superblock that + # doesn't have a matching bit here. The feature-bit to name + # mapping must be kept up-to-date for this test to succeed. + echo "Unknown feature name $attr. xfstests needs updating." \ + "Skipping the test of sysfs values to superblock values" \ + >> $seqres.full + skip_sysfs_super_check=true + fi +done + +for file in $sysfs_base/features/*; do + $test_sysfs || break + attr=$(basename $file) + val=$(cat $file) + if [ "$val" -gt 0 ]; then + if [ ! -e "$sysfs_base/$fsid/features/$attr" ]; then + echo "features/$attr has a nonzero value ($val)" \ + "but $fsid/features/$attr doesn't exist" + error=true + continue + fi + if ! is_writeable "$sysfs_base/$fsid/features/$attr"; then + echo "features/$attr has a nonzero value ($val)" \ + "but $fsid/features/$attr is not writable" + error=true + continue + fi + continue + fi + + [ ! -e "$sysfs_base/$fsid/features/$attr" ] && continue + + if is_writeable "$sysfs_base/$fsid/features/$attr"; then + echo "features/$attr has a zero value but" \ + "$fsid/features/$attr is writable." + error=true + continue + fi + + read class bit < <(get_feature_mask $attr) + mask=$(get_changeable_mask $class) + if [ "$(( $bit & $mask ))" -ne 0 ]; then + echo "$attr isn't writable but GET_SUPPORTED_FEATURES" \ + "ioctl claims it should be." + error=true + continue + fi +done + +umount $SCRATCH_MNT > /dev/null 2>&1 + +fields=("compat" "compat_ro" "incompat") +declare -a disk_flags + +check_ioctl_flags() { + local index=$1 + local flags=${features[$index]} + + if [ "$flags" != "${disk_flags[$index]}" ]; then + echo "ioctl returned different ${fields[$index]} flags" \ + "($flags) than those contained in superblock" \ + "(${disk_flags[$index]})" + error=true + fi +} + +check_sysfs_flags() { + local index=$1 + $skip_sysfs_super_check || return + + flags=$(printf "0x%llx" ${sysfs_features[$index]}) + if [ "$flags" != "${disk_flags[$index]}" ]; then + echo "sysfs returned different ${fields[$index]}" \ + "flags ($flags) than those contained in" \ + "superblock (${disk_flags[$index]})" + error=true + fi +} + + +for index in $(seq 0 2); do + class=${fields[$index]} + disk_flags[$index]=$(_btrfs_get_feature_flags $SCRATCH_DEV $class) + $test_ioctl && check_ioctl_flags "$index" + $test_sysfs && check_sysfs_flags "$index" +done + +$error && exit 1 + +# +echo "Silence is golden" +status=0 +exit diff --git a/tests/btrfs/126.out b/tests/btrfs/126.out new file mode 100644 index 0000000..fd12fb0 --- /dev/null +++ b/tests/btrfs/126.out @@ -0,0 +1,2 @@ +== QA output created by 126 +Silence is golden diff --git a/tests/btrfs/127 b/tests/btrfs/127 new file mode 100755 index 0000000..0a7eb91 --- /dev/null +++ b/tests/btrfs/127 @@ -0,0 +1,185 @@ +#!/bin/bash +# FA QA Test No. 127 +# +# Test online feature changing via ioctl +# +#----------------------------------------------------------------------- +# Copyright (c) 2013 SUSE, All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- + +seq=$(basename $0) +seqres=$RESULT_DIR/$seq +echo "== QA output created by $seq" + +here=$(pwd) +tmp=/tmp/$$ +status=1 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter.btrfs + +_supported_fs btrfs +_supported_os Linux +_require_scratch +_require_command $BTRFS_SHOW_SUPER_PROG + +IOCTL=src/btrfs_ioctl_helper + +check_features() { + reserved="$2" + method="$3" + if [ "$1" != 0 ]; then + echo "$method: failed: $reserved" + exit 1 + fi + if [ "$reserved" = "Not implemented." ]; then + echo "Skipping ioctl $method test. Not implemented." \ + >> $seqres.full + echo "Silence is golden." + exit 0 + fi +} + +# 3 values, one for each each of the fields +update_features() { + read -a features < <($IOCTL $SCRATCH_MNT GET_FEATURES 2>&1) + check_features $? "${features[@]}" "GET_FEATURES" +} + +set_feature() { + local field=$1 + local bits=$2 + local class=${fields[$field]} + local old=${features[$field]} + msg=$($IOCTL $SCRATCH_MNT SET_FEATURES set $class $bits) + check_features $? "$msg" "SET_FEATURES" + update_features + local new=${features[$field]} + + if [ "$old" = "$new" ]; then + echo "Feature setting failed" + exit 1 + fi + expected=$(( $old | $bits )) + new=$(( $new )) + if [ "$expected" -ne "$new" ]; then + echo "Feature setting failed; Got $new, expected $expected" + exit 1 + fi + echo $new +} + +clear_feature() { + local field=$1 + local bits=$2 + local class=${fields[$field]} + local old=${features[$field]} + msg=$($IOCTL $SCRATCH_MNT SET_FEATURES clear $class $bits) + check_features $? "$msg" "SET_FEATURES" + update_features + local new="${features[$field]}" + + if [ "$old" = "$new" ]; then + echo "Feature clearing failed" + exit 1 + fi + expected=$(( $old & ~$bits )) + new=$(( $new )) + if [ "$expected" -ne "$new" ]; then + echo "Feature clearing failed; Got $new, expected $expected" + exit 1 + fi +} + +check_flags() { + local index=$1 + local expected=$(( $2 )) + local class=${fields[$index]} + disk_flags="$(( $(_btrfs_get_feature_flags $SCRATCH_DEV $class) ))" + if [ "$disk_flags" -ne "$expected" ]; then + echo "mismatch: $disk_flags-$expected" + error=true + fi +} + +error=false +fields=("compat" "compat_ro" "incompat") + +_scratch_mkfs > /dev/null 2>&1 +_scratch_mount + +update_features + +# 9 values; 3 each for supported, settable, and clearable +read -a supp_features < <($IOCTL $SCRATCH_MNT GET_SUPPORTED_FEATURES 2>&1) +check_features $? "$supp_features" "GET_SUPPORTED_FEATURES" + +# Cycle through settable features. +# Set the feature +# Reload ioctl version and test against expected new value +# Unmount and test against expected new value +# Reount +settable() { + echo "${supp_features[$(( $1 + 3 ))]}" +} +did_set=false +for field in $(seq 0 2); do + fset="$(settable $field)" + [ -z "$fset" ] && break + for n in $(seq 0 63); do + old="${features[$field]}" + v="$(( $fset & (1 << $n) ))" + [ "$v" -eq 0 ] && continue + new="$(set_feature $field $v)" + umount $SCRATCH_MNT > /dev/null 2>&1 + expected="$(( $old | $v ))" + check_flags "$field" "$expected" + _scratch_mount + did_set=true + done +done +$did_set || echo "No online-settable features to test." >> $seqres.full + +# Repeat with clearing features +clearable() { + echo "${supp_features[$(( $1 + 6 ))]}" +} +did_clear=false +for field in $(seq 0 2); do + fclear="$(clearable $field)" + [ -z "$fclear" ] && break + for n in $(seq 0 63); do + v="$(( $fclear & (1 << $n) ))" + [ "$v" -eq 0 ] && continue + + new="$(clear_feature $field $v)" + umount $SCRATCH_MNT > /dev/null 2>&1 + expected=$(( $old &~ $v )) + check_flags $field $expected + _scratch_mount + did_clear=true + done +done +$did_clear || echo "No online-clearable features to test." >> $seqres.full + +umount $SCRATCH_MNT > /dev/null 2>&1 + +$error && exit 1 + +echo "Silence is golden" +status=0 +exit diff --git a/tests/btrfs/127.out b/tests/btrfs/127.out new file mode 100644 index 0000000..2ff4733 --- /dev/null +++ b/tests/btrfs/127.out @@ -0,0 +1,2 @@ +== QA output created by 127 +Silence is golden diff --git a/tests/btrfs/128 b/tests/btrfs/128 new file mode 100755 index 0000000..7de780a --- /dev/null +++ b/tests/btrfs/128 @@ -0,0 +1,178 @@ +#!/bin/bash +# FA QA Test No. 128 +# +# Test online feature changing via sysfs +# +#----------------------------------------------------------------------- +# Copyright (c) 2013 SUSE, All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- + +seq=$(basename $0) +seqres=$RESULT_DIR/$seq +echo "== QA output created by $seq" + +here=$(pwd) +tmp=/tmp/$$ +status=1 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter.btrfs + +_supported_fs btrfs +_supported_os Linux +_require_scratch +_require_command $BTRFS_SHOW_SUPER_PROG + +IOCTL=src/btrfs_ioctl_helper + +check_flags() { + local class=$1 + local expected=$2 + disk_flags="$(_btrfs_get_feature_flags $SCRATCH_DEV $class)" + disk_flags=$(printf 0x%llx $disk_flags) + expected=$(printf 0x%llx $expected) + if [ "$disk_flags" != "$expected" ]; then + echo "mismatch: $disk_flags-$expected" + error=true + fi +} + +get_feature_mask() { + local attr=$1 + local class="" + local bit= + case "$attr" in + mixed_backref) class=incompat bit=0x1 ;; + default_subvol) class=incompat bit=0x2 ;; + mixed_groups) class=incompat bit=0x4 ;; + compress_lzo) class=incompat bit=0x8 ;; + compress_lsov2) class=incompat bit=0x10 ;; + big_metadata) class=incompat bit=0x20 ;; + extended_iref) class=incompat bit=0x40 ;; + raid56) class=incompat bit=0x80 ;; + skinny_metadata)class=incompat bit=0x100 ;; + compat:*) class=compat; bit=${attr##compat:} ;; + compat_ro:*) class=compat_ro; bit=${attr##compat_ro:} ;; + incompat:*) class=incompat; bit=${attr##incompat:} ;; + esac + if [ -z "$class" ]; then + echo "Unknown feature name $attr. xfstests needs updating." \ + " Skipping the test of sysfs values to superblock values" \ + >> $seqres.full + return + fi + echo "$class $bit" +} + + +_scratch_mkfs > /dev/null 2>&1 +error=false +fields=("compat" "compat_ro" "incompat") +sysfs_base="/sys/fs/btrfs" +settable="" +clearable="" + +if [ ! -d "$sysfs_base/features" ]; then + echo "Silence is golden" + echo "This kernel does not export $sysfs_base/features." \ + "Nothing to test." >> $seqres.full + exit 0 +fi + +# Gather up the features the kernel knows about +_scratch_mount +for feature in $sysfs_base/features/*; do + val=$(cat $feature) + fname=$(basename $feature) + if [ "$(( $val & 0x1 ))" -eq 1 ]; then + settable="$settable $fname" + fi + if [ "$(( $val & 0x2 ))" -eq 2 ]; then + clearable="$clearable $fname" + fi +done +umount $SCRATCH_MNT > /dev/null 2>&1 + +# Set/clear tests do their own mount cycling +sysfs_fs_base="$sysfs_base/$(_btrfs_get_fsid $SCRATCH_DEV)" + +if [ ! -d "$sysfs_fs_base/features" ]; then + echo "Silence is golden" + echo "This kernel does not export $sysfs_fs_base/features." \ + "Nothing to test." >> $seqres.full + exit 0 +fi + +did_set=false +for feature in $settable; do + read class bit < <(get_feature_mask $feature) + [ -z "$class" ] && continue + flags=$(_btrfs_get_feature_flags $SCRATCH_DEV $class) + _scratch_mount + val=$(cat $sysfs_fs_base/features/$feature) + [ "$val" -ne 0 ] && continue + echo 1 > $sysfs_fs_base/features/$feature + if [ $? -ne 0 ] ; then + echo "Error while setting $feature - $st" + error=true + umount $SCRATCH_MNT > /dev/null 2>&1 + continue + fi + newval=$(cat $sysfs_fs_base/features/$feature) + if [ "$newval" -ne 1 ]; then + echo "Setting feature $feature was ignored." + error=true + fi + umount $SCRATCH_MNT > /dev/null 2>&1 + check_flags $class $(( $flags | $bit )) + did_set=true +done +$did_set || echo "No online-settable features to test." >> $seqres.full + +did_clear=false +for feature in $clearable; do + read class bit < <(get_feature_mask $feature) + [ -z "$class" ] && continue + flags=$(_btrfs_get_feature_flags $SCRATCH_DEV $class) + _scratch_mount + val=$(cat $sysfs_fs_base/features/$feature) + [ "$val" -ne 1 ] && continue + echo 0 > $sysfs_fs_base/features/$feature + if [ $? -ne 0 ] ; then + echo "Error while clearing $feature - $st" + error=true + umount $SCRATCH_MNT > /dev/null 2>&1 + continue + fi + newval=$(cat $sysfs_fs_base/features/$feature) + if [ "$newval" -ne 0 ]; then + echo "Clearing feature $feature was ignored." + error=true + fi + umount $SCRATCH_MNT > /dev/null 2>&1 + check_flags $class $(( $flags & ~$bit )) + did_clear=true +done +$did_clear || echo "No online-clearable features to test." >> $seqres.full + +# Still umounted from set/clear tests + +$error && exit 1 + +echo "Silence is golden" +status=0 +exit diff --git a/tests/btrfs/128.out b/tests/btrfs/128.out new file mode 100644 index 0000000..1b86f92 --- /dev/null +++ b/tests/btrfs/128.out @@ -0,0 +1,2 @@ +== QA output created by 128 +Silence is golden diff --git a/tests/btrfs/group b/tests/btrfs/group index 3535f02..e76265d 100644 --- a/tests/btrfs/group +++ b/tests/btrfs/group @@ -128,3 +128,6 @@ 123 auto quick qgroup 124 auto quick metadata 125 auto quick metadata +126 auto quick metadata +127 auto quick metadata +128 auto quick metadata