| Message ID | 1467580946-2899-1-git-send-email-hans.van.kranenburg@mendix.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Sun, Jul 03, 2016 at 11:22:26PM +0200, Hans van Kranenburg wrote: > BTRFS_IOC_LOGICAL_INO takes a btrfs_ioctl_logical_ino_args as argument, > not a btrfs_ioctl_ino_path_args. The lines were probably copy/pasted > when the code was written. > > Since btrfs_ioctl_logical_ino_args and btrfs_ioctl_ino_path_args have > the same size, the actual IOCTL definition here does not change. > > But, it makes the code less confusing for the reader. > > Signed-off-by: Hans van Kranenburg <hans.van.kranenburg@mendix.com> Applied, thanks. Same fix is needed for kernel, care to send a patch? -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jul 04, 2016 at 02:13:18PM +0200, David Sterba wrote: > On Sun, Jul 03, 2016 at 11:22:26PM +0200, Hans van Kranenburg wrote: > > BTRFS_IOC_LOGICAL_INO takes a btrfs_ioctl_logical_ino_args as argument, > > not a btrfs_ioctl_ino_path_args. The lines were probably copy/pasted > > when the code was written. > > > > Since btrfs_ioctl_logical_ino_args and btrfs_ioctl_ino_path_args have > > the same size, the actual IOCTL definition here does not change. > > > > But, it makes the code less confusing for the reader. > > > > Signed-off-by: Hans van Kranenburg <hans.van.kranenburg@mendix.com> > > Applied, thanks. Same fix is needed for kernel, care to send a patch? Apparenly you did that, sorry. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/ioctl.h b/ioctl.h index 5f18bcb..620dd3d 100644 --- a/ioctl.h +++ b/ioctl.h @@ -685,7 +685,7 @@ static inline char *btrfs_err_str(enum btrfs_err_code err_code) #define BTRFS_IOC_INO_PATHS _IOWR(BTRFS_IOCTL_MAGIC, 35, \ struct btrfs_ioctl_ino_path_args) #define BTRFS_IOC_LOGICAL_INO _IOWR(BTRFS_IOCTL_MAGIC, 36, \ - struct btrfs_ioctl_ino_path_args) + struct btrfs_ioctl_logical_ino_args) #define BTRFS_IOC_SET_RECEIVED_SUBVOL _IOWR(BTRFS_IOCTL_MAGIC, 37, \ struct btrfs_ioctl_received_subvol_args) #define BTRFS_IOC_SEND _IOW(BTRFS_IOCTL_MAGIC, 38, struct btrfs_ioctl_send_args)
BTRFS_IOC_LOGICAL_INO takes a btrfs_ioctl_logical_ino_args as argument, not a btrfs_ioctl_ino_path_args. The lines were probably copy/pasted when the code was written. Since btrfs_ioctl_logical_ino_args and btrfs_ioctl_ino_path_args have the same size, the actual IOCTL definition here does not change. But, it makes the code less confusing for the reader. Signed-off-by: Hans van Kranenburg <hans.van.kranenburg@mendix.com> --- ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)