From patchwork Tue Aug 23 10:25:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Sterba X-Patchwork-Id: 9295431 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4952660757 for ; Tue, 23 Aug 2016 10:45:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 371CF28BBC for ; Tue, 23 Aug 2016 10:45:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2BF2228BDD; Tue, 23 Aug 2016 10:45:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C9EBA28BBC for ; Tue, 23 Aug 2016 10:45:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757437AbcHWKpT (ORCPT ); Tue, 23 Aug 2016 06:45:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:59407 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756490AbcHWKnp (ORCPT ); Tue, 23 Aug 2016 06:43:45 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id EA302ADB4 for ; Tue, 23 Aug 2016 10:26:26 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id CC496DAA2A; Tue, 23 Aug 2016 12:25:20 +0200 (CEST) From: David Sterba To: linux-btrfs@vger.kernel.org Cc: David Sterba Subject: [PATCH 09/13] btrfs-progs: document all btrfs_open_ctree_flags Date: Tue, 23 Aug 2016 12:25:13 +0200 Message-Id: <1471947917-5324-10-git-send-email-dsterba@suse.com> X-Mailer: git-send-email 2.7.1 In-Reply-To: <1471947917-5324-1-git-send-email-dsterba@suse.com> References: <1471947917-5324-1-git-send-email-dsterba@suse.com> Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Document and add unsigned type to the values. Signed-off-by: David Sterba --- disk-io.h | 41 +++++++++++++++++++++++++---------------- 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/disk-io.h b/disk-io.h index a73dede1e8d0..c404d3f4fdfe 100644 --- a/disk-io.h +++ b/disk-io.h @@ -29,21 +29,29 @@ #define BTRFS_SUPER_MIRROR_SHIFT 12 enum btrfs_open_ctree_flags { - OPEN_CTREE_WRITES = (1 << 0), - OPEN_CTREE_PARTIAL = (1 << 1), - OPEN_CTREE_BACKUP_ROOT = (1 << 2), - OPEN_CTREE_RECOVER_SUPER = (1 << 3), - OPEN_CTREE_RESTORE = (1 << 4), - OPEN_CTREE_NO_BLOCK_GROUPS = (1 << 5), - OPEN_CTREE_EXCLUSIVE = (1 << 6), - OPEN_CTREE_NO_DEVICES = (1 << 7), + /* Open filesystem for writes */ + OPEN_CTREE_WRITES = (1U << 0), + /* Allow to open filesystem with some broken tree roots (eg log root) */ + OPEN_CTREE_PARTIAL = (1U << 1), + /* If primary root pinters are invalid, try backup copies */ + OPEN_CTREE_BACKUP_ROOT = (1U << 2), + /* Allow reading all superblock sopies if the primary is damaged */ + OPEN_CTREE_RECOVER_SUPER = (1U << 3), + /* Restoring filesystem image */ + OPEN_CTREE_RESTORE = (1U << 4), + /* Do not read block groups (extent tree) */ + OPEN_CTREE_NO_BLOCK_GROUPS = (1U << 5), + /* Open all devices in O_EXCL mode */ + OPEN_CTREE_EXCLUSIVE = (1U << 6), + /* Do not scan devices */ + OPEN_CTREE_NO_DEVICES = (1U << 7), /* * Don't print error messages if bytenr or checksums do not match in * tree block headers. Turn on by OPEN_CTREE_SUPPRESS_ERROR */ - OPEN_CTREE_SUPPRESS_CHECK_BLOCK_ERRORS = (1 << 8), - /* Return chunk root */ - __OPEN_CTREE_RETURN_CHUNK_ROOT = (1 << 9), + OPEN_CTREE_SUPPRESS_CHECK_BLOCK_ERRORS = (1U << 8), + /* Return the chunk root */ + __OPEN_CTREE_RETURN_CHUNK_ROOT = (1U << 9), OPEN_CTREE_CHUNK_ROOT_ONLY = OPEN_CTREE_PARTIAL + OPEN_CTREE_SUPPRESS_CHECK_BLOCK_ERRORS + __OPEN_CTREE_RETURN_CHUNK_ROOT, @@ -53,18 +61,19 @@ enum btrfs_open_ctree_flags { * Like split PARTIAL into SKIP_CSUM/SKIP_EXTENT */ - OPEN_CTREE_IGNORE_FSID_MISMATCH = (1 << 10), + /* Ignore UUID mismatches */ + OPEN_CTREE_IGNORE_FSID_MISMATCH = (1U << 10), /* - * Allow open_ctree_fs_info() to return a incomplete fs_info with + * Allow open_ctree_fs_info() to return an incomplete fs_info with * system chunks from super block only. - * It's useful for chunk corruption case. + * It's useful when chunks are corrupted. * Makes no sense for open_ctree variants returning btrfs_root. */ - OPEN_CTREE_IGNORE_CHUNK_TREE_ERROR = (1 << 11), + OPEN_CTREE_IGNORE_CHUNK_TREE_ERROR = (1U << 11), /* Allow to open a partially created filesystem */ - OPEN_CTREE_FS_PARTIAL = (1 << 12), + OPEN_CTREE_FS_PARTIAL = (1U << 12), }; /*