| Message ID | 1473818547-615-1-git-send-email-bo.li.liu@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 09/14/16 04:02, Liu Bo wrote: > The extent buffer 'next' needs to be free'd conditionally. > > Signed-off-by: Liu Bo <bo.li.liu@oracle.com> > --- > fs/btrfs/extent-tree.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c > index 5a940ab..779fd72 100644 > --- a/fs/btrfs/extent-tree.c > +++ b/fs/btrfs/extent-tree.c > @@ -8882,6 +8882,7 @@ static noinline int do_walk_down(struct btrfs_trans_handle *trans, > &wc->flags[level - 1]); > if (ret < 0) { > btrfs_tree_unlock(next); > + free_extent_buffer(next); > return ret; > } > > This was fixed a long time ago by the following patch by Josef: "Btrfs: don't BUG() during drop snapshot" https://patchwork.kernel.org/patch/7002791/ ..which never got merged. I've been using it since 4.1.x until today without problems. Note that apparently Patchwork got confused here: downloading only the "patch" fragment won't work; you'll need the full "mbox" attachment. It also seems to have been sorted into the wrong list bucket for some reason. -h -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Sep 14, 2016 at 03:19:18PM +0200, Holger Hoffstätte wrote: > On 09/14/16 04:02, Liu Bo wrote: > > The extent buffer 'next' needs to be free'd conditionally. > > > > Signed-off-by: Liu Bo <bo.li.liu@oracle.com> > > --- > > fs/btrfs/extent-tree.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c > > index 5a940ab..779fd72 100644 > > --- a/fs/btrfs/extent-tree.c > > +++ b/fs/btrfs/extent-tree.c > > @@ -8882,6 +8882,7 @@ static noinline int do_walk_down(struct btrfs_trans_handle *trans, > > &wc->flags[level - 1]); > > if (ret < 0) { > > btrfs_tree_unlock(next); > > + free_extent_buffer(next); > > return ret; > > } > > > > > > This was fixed a long time ago by the following patch by Josef: > > "Btrfs: don't BUG() during drop snapshot" > https://patchwork.kernel.org/patch/7002791/ > > ..which never got merged. The patch was buried in some thread, not even a subject gives a hint there's a patch, but anyway thanks for pointing it out. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Sep 13, 2016 at 07:02:27PM -0700, Liu Bo wrote: > The extent buffer 'next' needs to be free'd conditionally. > > Signed-off-by: Liu Bo <bo.li.liu@oracle.com> Reviewed-by: David Sterba <dsterba@suse.com> Josef's patch contained this fix but mixed with other (removing BUG_ON). I've removed it so we can merge both patches, for sake of better change separation. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Sep 22, 2016 at 05:10:25PM +0200, David Sterba wrote: > On Tue, Sep 13, 2016 at 07:02:27PM -0700, Liu Bo wrote: > > The extent buffer 'next' needs to be free'd conditionally. > > > > Signed-off-by: Liu Bo <bo.li.liu@oracle.com> > > Reviewed-by: David Sterba <dsterba@suse.com> > > Josef's patch contained this fix but mixed with other (removing BUG_ON). > I've removed it so we can merge both patches, for sake of better change > separation. Good to know that, thank you for the efforts. Thanks, -liubo -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 5a940ab..779fd72 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -8882,6 +8882,7 @@ static noinline int do_walk_down(struct btrfs_trans_handle *trans, &wc->flags[level - 1]); if (ret < 0) { btrfs_tree_unlock(next); + free_extent_buffer(next); return ret; }
The extent buffer 'next' needs to be free'd conditionally. Signed-off-by: Liu Bo <bo.li.liu@oracle.com> --- fs/btrfs/extent-tree.c | 1 + 1 file changed, 1 insertion(+)