From patchwork Fri Aug 25 05:15:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naohiro Aota X-Patchwork-Id: 9921227 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B7D6F60349 for ; Fri, 25 Aug 2017 05:17:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A6C7E23B24 for ; Fri, 25 Aug 2017 05:17:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9B61923B34; Fri, 25 Aug 2017 05:17:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DA95E23B24 for ; Fri, 25 Aug 2017 05:17:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751508AbdHYFQR (ORCPT ); Fri, 25 Aug 2017 01:16:17 -0400 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:44245 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411AbdHYFQQ (ORCPT ); Fri, 25 Aug 2017 01:16:16 -0400 X-IronPort-AV: E=Sophos;i="5.41,424,1498492800"; d="scan'208";a="45022610" Received: from mail-cys01nam02lp0054.outbound.protection.outlook.com (HELO NAM02-CY1-obe.outbound.protection.outlook.com) ([207.46.163.54]) by ob1.hgst.iphmx.com with ESMTP; 25 Aug 2017 13:15:30 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=cp8T/QjrITffb00U4kM3Kk5pVZIpvApNx2Ywpywmor4=; b=kMk/SRIVNxtDfrGsWgo7aV9mcCDaMfwuYUam3l52U0qo4wXJmM9m9twCBcLcDyvd6y86pB/jdZsDTrjK1kpKOaUlYWnAbYGIiN4zcS/HUURCpQ3YlBmaKpHfM+AOWQxHXlVEqnBUhkohRZhnJhErJmE7TSAP/tI18dFlRQCD9A4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Naohiro.Aota@wdc.com; Received: from naota.dhcp.fujisawa.hgst.com (199.255.47.10) by DM5PR04MB0666.namprd04.prod.outlook.com (10.172.187.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9; Fri, 25 Aug 2017 05:15:28 +0000 Subject: [PATCH] btrfs: fix NULL pointer dereference from free_reloc_roots() From: Naohiro Aota To: linux-btrfs@vger.kernel.org Cc: jbacik@fb.com, clm@fb.com, dsterba@suse.com Date: Fri, 25 Aug 2017 14:15:14 +0900 Message-ID: <150363811494.24591.5585689547237978902.stgit@naota.dhcp.fujisawa.hgst.com> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Originating-IP: [199.255.47.10] X-ClientProxiedBy: OS2PR01CA0119.jpnprd01.prod.outlook.com (10.174.152.13) To DM5PR04MB0666.namprd04.prod.outlook.com (10.172.187.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0c9d5bcb-3569-4197-7271-08d4eb784d7b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR04MB0666; X-Microsoft-Exchange-Diagnostics: 1; DM5PR04MB0666; 3:YEUswc3m7745ucap0pLgsExZ8aym6UV066cUXRS641W5VfmWeQAsINJ1LpDI6L0KBZn18H046jE5NFNQSn+HT1oSmadCUsiLmpFWKQWoClnoV03LbIyPFNEGA4UtIufhSXnXuU0nfL+/Z9F3QDX52RPtL5dXCCLcAMYeM2AeQtn9ud9XeUdSr/l59ecv1Ym6dSOtIpuSlvQba04emBPpRUpYE07hsYGp4JLr5+HloeVhCoKmYCCaJRu2hwHAbRDP; 25:qXgEENT4oD4XR+vUNwZqq6S61bQXzf9XQum55gTgUDRjHtCMuAuImrcZRHTlCqq5XDWcArqvaRXc1a4HoWU3uqNa3oU3S6XE1qUXkWCA4Q//zKXLVCWl15+bnqkiIbRTPWDZz8T8JYDX4ZtK0mVoUSE5EZmz+oc53/Fnqo0pUyflBTA7HftU5MKUDjTpooG+0stnNKXmQBJvDu977I5lQVAn8YwVA+au7V+A7h4Rc3xQ8zjZZ3VPt7O9/ThP0JIpk1G8APk5GkskCB+XVYvnvcmaHVjnRmaR7oZlFZFQ3kJ9rV3CzdWEUv9omhVyoAJu3hk7MEGhbNOqI2Z6OGohfg==; 31:3XuOexCjBkTd2viLk4Ls7H65UF3jfeewMcGDlveiXFuupNyLmaaOYnlv4nX910zrgfzXYUr1HP0RQgMDNXxyq7M3PD6ClEiV9lS+db+3toH3e7S/iq6eZ8+wVxZBQCLl4ql/GQHfW2Yll9o890CQ3C6at8NJW1TtN3TgQH9j/Km0K82auU8I1vfwFgL9QJb/oGT9IpPv2r0H8gXRO2JzfMo4KGHD6NyJEggVSBHaxTA= X-MS-TrafficTypeDiagnostic: DM5PR04MB0666: WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; DM5PR04MB0666; 20:VF1BCLaH477DzXb3gtxsndqRx4EYA8JgLon4zLjr7QIGSfPcFzLI0LemXM97TbXoL4MNZ8vXenmpAWGag0UzEUx/+ah8R2lOXgZVmanqWHszKtz5HUhNytQX7pG5dlqw2gF3xbro9912tULsXkspdlkd17QYxtzCPZ66MK3hFl6YuHwkLH2BvSJcJ0BFSQXCnn07maJEr4TwJijtW/NsopXmmQzh1mg1IRkkfJGIYmYu8y0fqbGk3Htud9ttuNA/c6bqygzQtjVniTAdxEyB5FfH/0x4FIyxQoP+QJT7HG+QeNFrS4rhq+YT032g7R+tx6HE+H2HuPEWBtHLxG+t/lS8+KsTi3A2QbBusijSrQx9xs7pa3aJqwvjVYTlBHsc5azyaeSIX6Tq2jfC88mAcjU1UoMgzSkfue7AQWr1C8CizoZtCN1Xh46YiVeXTvBF7iaMp0uFeI53nHhxeZSkjE0ARlKowGOoOOHxiQSGC2DSTUmvaUyqww9IoghkwsWq; 4:EmEgH378RBV8oU06o8ggoLN90NExPJe/Lx+5/zlBRs9nQD5WODMLlKL9GwURfWO/qzpL2d8PMCT+p5qT30BFm/semxls5voCH3lP/d0Ay/ep8Mn9ktRmsNsrUg1FVTxb0gnxtIuA8/7FejbHZo0y+TBTKOHDBuSDysUvydsLXg2jhkUHLEPw9cnUhPkuZIokiz3IZcaQI6IRfUrgCJRPOkABbwpu5bj1QGvnZ/pTDgiiZ2gMoqFganDFnrspsi8M X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR04MB0666; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR04MB0666; X-Forefront-PRVS: 041032FF37 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(7370300001)(4630300001)(6009001)(39860400002)(189002)(199003)(53936002)(81166006)(103116003)(54356999)(81156014)(189998001)(2906002)(101416001)(6116002)(7350300001)(3846002)(9686003)(83506001)(50986999)(25786009)(86362001)(66066001)(478600001)(2361001)(47776003)(4326008)(42186005)(8676002)(33646002)(2351001)(106356001)(230700001)(105586002)(110136004)(6666003)(4001350100001)(50466002)(97736004)(6506006)(72206003)(5660300001)(305945005)(55016002)(68736007)(6916009)(23676002)(7736002); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR04MB0666; H:naota.dhcp.fujisawa.hgst.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: wdc.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjA0TUIwNjY2OzIzOmZEU1ZwUndXYlBLYldSeXg3OTJrdFkzSDUz?= =?utf-8?B?YUNQVmtFTlErNXg0b1NSWm1qc3VTSUdEVmNJM3lxTGtieVFWck56dW12allH?= =?utf-8?B?ZUJpcHgydmlFSVFPRDQrejBleUl3Z0lNVzNWdzlnclc1akRnNitrYzR0VmR2?= =?utf-8?B?cFc2NkY4MGVwWDFYL0xwUklKWEM1czlNRU40T29hcURIWUxXRE5tSXF3aWM3?= =?utf-8?B?N0wvckhDZy9YTEZKUDRNRFhWeWEwQTVkbTIvNW9CZnA1Uys3OFdmRmxiUTBU?= =?utf-8?B?VTBTeUVCUm1OSit0ZGQ1Z01VOWxwMEk4OERTaEs2WXJzNEovS1ZQYmxzcGRM?= =?utf-8?B?WlFDTkZQTVpDeDc1RE9KOW01ZkhVbU5BelFQa01MN3NwUXRMVXBUMkc1S0s4?= =?utf-8?B?dm1KaFQ1cElHVUpVVUc5NWM5VVFnMExPTVJpbytmWElYNlJ6VWozZ2QzK2lo?= =?utf-8?B?ZnUxWXdMSk5OV094WnZ0TFE2UG1rQnZWWitRcGw0TEQzVGxGTldXYytuQ1l5?= =?utf-8?B?ZnRSTUZMdGp0UG1VWjJ2L1NHZ1REWU9EbkI3Wmc5UUx5VzNtTHRvaFplRGdV?= =?utf-8?B?K2p3MGZYV0pJWER0WjhOaS9PTGRXREVad25PblNKODVOWGtjZDNOb3kxenp5?= =?utf-8?B?WGNNeXIweE9Wc1lSTmtHQVE2Z2d6WVcvbi8wblA3WVJIZ0hHMWVjdjd5NWYy?= =?utf-8?B?VCtxM2ZqMGVHSGdtSXpYNjhWTVhYUDV0M0xJbTEybzQ0S2J4WXdETUNWWHpS?= =?utf-8?B?encwWkhOcnJrTEQwekNBS3VqZWtRMEgweXRLWDJ2UXN0QVlkTXgzemNhZ0kz?= =?utf-8?B?eXAxY1lBUjBOKzRKN2lPVFk1T3NSUzd1M3N5UGZ2dHRNZEhHSkRrUEtNUUF0?= =?utf-8?B?T2VOblRFRHlTOFA4RjFpZ01wTXNjRVlUbGR6dkRLd1FjV2RTZkY0MmRCV25E?= =?utf-8?B?NGcxc1BQWWl1bEhjRDYwQ3Q0NnkwUHMzYms0d1JLbGNTNUdMZXZlYUtDZVBo?= =?utf-8?B?V09ycUhtS1Y2c2c5ajhSdm9OMW5KUkRDTDdUL25TbmpOVVQ4dWNDVUkxWUlj?= =?utf-8?B?Z1JmdmYyVUx0OGhoaFVFZHFvUXFIc21sUkw4RHlhelhCWnk1RUVLNjlVSTdV?= =?utf-8?B?SDY1VWVXc29EVFFpeTZocDZyNVJSY2tlTGdXTHkrdDVqeUNrZE4yaUZrajhw?= =?utf-8?B?enpuZmJXN1dnYlB4Q0cwMzErUE4xUkVobnJDc3RGaFMyY3NjSFV5RjIzNEh0?= =?utf-8?B?Z3hoUG1Ic3p2QVRpbkh1OXdJQmpBM0duazEvbk13WGo5a1RYR0gycHRjdUVr?= =?utf-8?B?Snd5OFg5M2hEZlZUUWtGTWtDK29aU042WFFKa1FzWnEwdkZpMEl2clZ2Z0Fn?= =?utf-8?B?QklPMFBjeGlRZHNrK285MmFJNklFTU4yellzMXY4VkpVaXRrNE85ZlNJYmZa?= =?utf-8?B?bXp1L2VnRnV6dDRZVkMvcUNLL2dyc1FBVEF1OUtTMmRZdnBQdVlYTU5oVUFO?= =?utf-8?B?NDEza3lVdXNhKzZ2U3FlWXR1WHhVTmtONTIzVUdibmlsMUZGYjFqdU9QSVE2?= =?utf-8?B?Y1dTRnlNZGp3RDNQL2JWcjhlYnBwVGc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR04MB0666; 6:kBly/wH62LOP6tGyMBCTa4HhKp3G4bkbUyVcUGIjwNw6892aOP8dJYOwMfDLWaiGFYohxgbxcGVPA8pQlD/pJpq16dXdHg+inxcyBpfhsHWTBsXYU9VLIgMmi/GiIzpjpSH7SkQSPtm+huAayexh1ixhte9N/QdSlz3+pa28mg+xgbapYX33uevUVyr6cT+EdmgqiE0t1vZ1lmU1OQmLk9nyC7kf4OYbpoBStdKaIBqlK2yxeX14Cipi3GXrl+I6cKsdYKZ2rzciF8vITFD24qHB/4JPMwiE+8sjNDTfSlaUsbKMVOw2/e3iCDElCdMB5RFRhLXuVek3bBF57SbSug==; 5:zIB5jGwfpLniPCaZPa07IMDs3JufWBNPIv2goLDfhijJj1lPeOVUUOePWWN/7/C0g1R6+d1ALXbBnaud+hs7yu/u0WI642r/G2SNGVw/w6oVFaHmeKv9DotTBqtyE1b3thB6iDrGQHQDngxJTnpHzw==; 24:nNoVoHz+YjjhtnRsKrLC+86ZDLizdp4Gv6irKw+/AvXHyVjjbSbz7MeczAQOzlwSpkvpA65yiuhQoe4lg9UHcKmFdwfnMWFu5d2CPUMzWgw=; 7:v3hIxKT29wqA51DX1pej3pWIZgSEUAsr32zurXoISiYdh8j6+tvy19nRozJgpLnC9Or9EUG9xN/435GNs2rhXSRW4KYcA8IJftM+j46zdDRlSoaVclwDIL1a0rsgVNKQ4NFaafm2mrnABzSZdUK8ogVkrHeKKjPZFmeFSfhg4U9FhuoUXMDGlgTmhyUsMXQxhJuAu+rUo9R6YlfWYFbCM/9Og47v4pskX+B8CeoW5cg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR04MB0666; 20:KJZKbPovOYp3A6qIQnOsY7oHeUFFqhVtpqdABadXTt4/WvlnPzzGMD3OK18hQzi2Nc8JtgeCrD5MUrmTEAz9XE3zE2oE3t2EZG0Q5tmlvxhD0u5P3Ccu0NQpkMdmLBoTLPLOv0DgkC8QbnvVPd1woIqcC6QjnxpmcSG2sThIM9I= X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2017 05:15:28.4464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB0666 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP __del_reloc_root should be called before freeing up reloc_root->node. If not, calling __del_reloc_root() dereference reloc_root->node, causing the system BUG. Signed-off-by: Naohiro Aota Reviewed-by: Nikolay Borisov Reviewed-by: David Sterba --- fs/btrfs/relocation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index 65661d1aae4e..6445de8e9ece 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -2393,11 +2393,11 @@ void free_reloc_roots(struct list_head *list) while (!list_empty(list)) { reloc_root = list_entry(list->next, struct btrfs_root, root_list); + __del_reloc_root(reloc_root); free_extent_buffer(reloc_root->node); free_extent_buffer(reloc_root->commit_root); reloc_root->node = NULL; reloc_root->commit_root = NULL; - __del_reloc_root(reloc_root); } }