| Message ID | 1545555435-24576-12-git-send-email-Julia.Lawall@lip6.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drop useless LIST_HEAD | expand |
On Sun, Dec 23, 2018 at 09:57:06AM +0100, Julia Lawall wrote: > Drop LIST_HEAD where the variable it declares is never used. > > The uses were removed in 3fd0a5585eb9 ("Btrfs: Metadata ENOSPC > handling for balance"), but not the declaration. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > identifier x; > @@ > - LIST_HEAD(x); > ... when != x > // </smpl> > > Fixes: 3fd0a5585eb9 ("Btrfs: Metadata ENOSPC handling for balance") > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Added to patch queue, thanks. I've dropepd the Fixes: line as it's not really a fix that would need to go to stable. The original commit is mentioned in the changelog which is IMHO sufficient.
diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index 272b287f8cf0..de802ba35a34 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -2128,7 +2128,6 @@ static noinline_for_stack int merge_reloc_root(struct reloc_control *rc, struct btrfs_root *root) { struct btrfs_fs_info *fs_info = rc->extent_root->fs_info; - LIST_HEAD(inode_list); struct btrfs_key key; struct btrfs_key next_key; struct btrfs_trans_handle *trans = NULL;
Drop LIST_HEAD where the variable it declares is never used. The uses were removed in 3fd0a5585eb9 ("Btrfs: Metadata ENOSPC handling for balance"), but not the declaration. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier x; @@ - LIST_HEAD(x); ... when != x // </smpl> Fixes: 3fd0a5585eb9 ("Btrfs: Metadata ENOSPC handling for balance") Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- Successfully 0-day tested on 151 configurations. fs/btrfs/relocation.c | 1 - 1 file changed, 1 deletion(-)